Merge toolkit-cleanup into develop

.github/workflows/ci.yml

@@ -8,6 +8,8 @@ jobs:
     runs-on: ubuntu-latest
     steps:
       - uses: actions/checkout@v2
+        with:
+          fetch-depth: 150
 
       # This action reads the Ruby version from .ruby-version
       - uses: ruby/setup-ruby@v1

.gitignore

@@ -1,6 +1,9 @@
 .DS_Store
 /tmp
 
+# JetBrains IDE files
+.idea
+
 # Ruby / Bundler
 .bundle/
 vendor/bundle
@@ -10,16 +13,19 @@ fastlane/README.md
 fastlane/report.xml
 
 # Testing
-/test_results
-/coverage
+test_results/
+coverage/
+
+# YARD Documentation
+yard-doc/
 
 # DrawText
-/lib/drawText
-/lib/drawText.bundle
-/ext/drawText/drawText.xcodeproj/xcuserdata
-/ext/drawText/drawText.xcodeproj/project.xcworkspace/xcuserdata
-/ext/drawText/test-output
-/default.profraw
+lib/drawText
+lib/drawText.bundle
+ext/drawText/drawText.xcodeproj/xcuserdata
+ext/drawText/drawText.xcodeproj/project.xcworkspace/xcuserdata
+ext/drawText/test-output
+default.profraw
 
 # L10n Linter
 vendor/swiftgen

.rspec

@@ -0,0 +1,2 @@
+--color
+--format documentation

.rubocop.yml

@@ -1,6 +1,61 @@
+inherit_from: .rubocop_todo.yml
+
 require: 
 - rubocop-rspec
 
-Metrics/BlockLength:
+########## Lint / CodeStyle
+
+# This gem is included as part of the `Pluginfile`, which is `required` separately,
+# so makes it hard to keep it ordered with the rest of the gems
+Gemspec/OrderedDependencies:
   Exclude:
-    - 'spec/**/*.rb'
+    - 'fastlane-plugin-wpmreleasetoolkit.gemspec'
+
+# Especially for actions and methods like `self.run(params)` it's common to have the argument unused; but that
+# comes with the parent class API / contract, so we feel it more readable to avoid the _ unused prefix for those.
+Lint/UnusedMethodArgument:
+  Enabled: false
+
+Style/EmptyMethod:
+  EnforcedStyle: expanded
+
+Style/TrailingCommaInArrayLiteral:
+  EnforcedStyleForMultiline: consistent_comma
+
+# Enabling the 'frozen_string_literal: true' comment is nice but should be done with extra care
+# because enabling it on code that accidentally mutates string literals will crash at runtime
+# (e.g. `name = 'Hello'` then later `name << ' world'` will crash if the comment is enabled)
+# So we might enable it at some point, be we will need very careful review that this doesn't break everything.
+Style/FrozenStringLiteralComment:
+  Enabled: false
+
+########## Metrics / Max Lengths Rules
+
+Metrics/LineLength:
+  Max: 300
+
+Metrics/AbcSize:
+  Max: 140
+
+Metrics/BlockLength:
+  Max: 80
+
+Metrics/ClassLength:
+  Max: 300
+
+Metrics/MethodLength:
+  Max: 100
+
+Metrics/ModuleLength:
+  Max: 300
+
+Metrics/ParameterLists:
+  Max: 10
+
+########## Metrics / Complexity
+
+Metrics/CyclomaticComplexity:
+  Max: 20
+
+Metrics/PerceivedComplexity:
+  Max: 20