Merge toolkit-cleanup into develop

[AliSoftware]

⚠️ Please review and merge #217 first.

Once #217 is merged into toolkit-cleanup, I think it's time to merge all the intermediate work back to develop (and start using it next time we do a release).

Note: I'll still continue to do other PRs for that project but probably directly on develop by now, and better not keep the long-lived branch too long.

[mokagio]

I only skimmed the diff, since all the work that made into toolkit-cleanup already went through code review.

Approving to avoid congestions, even though this is pending #217, which I just approved with a question.

[mokagio]

Yes for 🎨 !

I think I came across a study (or maybe just an anecdote 🤔 ) on the value of having red for failed and green for passing tests from a psychological point of view. Something like green is calmer so you'll want to get to green fast. Maybe.

[AliSoftware]

The only issue with this, especially with a distributed company like us, is that colors might have different meanings depending on cultures; especially, in China, red is positive and green is negative (*), so the opposite meaning of what western culture is used to. I wonder if rspec and similar tools take the locale into account and switch those accordingly, but I doubt it. AFAIK we don't have anyone working on this codebase living in China, but still a good anecdote to know about.

(*) that's why, for example, in Apple's Stocks app, if you have your device's locale and region set to China, the colors used for positive vs negative fluctuations are switched compared to a device set in any other region.

[loremattei]

Everything here seems to come from reviewed PRs, so I'm ok with

Thanks for all this amazing clean-up @AliSoftware 🙇

[codecov-io]

Codecov Report

Merging #218 (228044e) into develop (0e3e8d3) will increase coverage by 1.47%.
The diff coverage is 27.48%.

@@             Coverage Diff             @@
##           develop     #218      +/-   ##
===========================================
+ Coverage    45.26%   46.73%   +1.47%     
===========================================
  Files           96       96              
  Lines         4072     3931     -141     
===========================================
- Hits          1843     1837       -6     
+ Misses        2229     2094     -135     

Impacted Files	Coverage Δ
...ctions/android/an_update_metadata_source_action.rb	31.34% <0.00%> (+0.46%)	⬆️
...kit/actions/android/android_betabuild_prechecks.rb	25.53% <0.00%> (+0.53%)	⬆️
...toolkit/actions/android/android_build_prechecks.rb	36.66% <0.00%> (+3.33%)	⬆️
...toolkit/actions/android/android_build_preflight.rb	50.00% <0.00%> (ø)
...ctions/android/android_create_xml_release_notes.rb	36.00% <0.00%> (ø)
...ctions/android/android_current_branch_is_hotfix.rb	65.00% <0.00%> (ø)
...oolkit/actions/android/android_hotifx_prechecks.rb	35.48% <0.00%> (+3.13%)	⬆️
...toolkit/actions/android/android_update_metadata.rb	68.42% <0.00%> (ø)
...lkit/actions/common/circleci_trigger_job_action.rb	46.66% <0.00%> (ø)
...common/extract_release_notes_for_version_action.rb	34.21% <0.00%> (+0.87%)	⬆️
... and 87 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0e3e8d3...228044e. Read the comment docs.