Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge toolkit-cleanup into develop #218

Merged
merged 163 commits into from
Feb 25, 2021
Merged

Merge toolkit-cleanup into develop #218

merged 163 commits into from
Feb 25, 2021

Commits on Feb 1, 2021

  1. Update CONTRIBUTING.md + rspec & yard default opts

    @AliSoftware
    AliSoftware committed Feb 1, 2021
    Configuration menu
    Copy the full SHA
    729ea28 View commit details
    Browse the repository at this point in the history

  2. [yard] ios_version_helper

    @AliSoftware
    AliSoftware committed Feb 1, 2021
    Configuration menu
    Copy the full SHA
    85656d6 View commit details
    Browse the repository at this point in the history

  3. Ruby convention for bool-returning methods

    @AliSoftware
    AliSoftware committed Feb 1, 2021
    Configuration menu
    Copy the full SHA
    6aaa05d View commit details
    Browse the repository at this point in the history

  4. small renames

    @AliSoftware
    AliSoftware committed Feb 1, 2021
    Configuration menu
    Copy the full SHA
    ed58b2d View commit details
    Browse the repository at this point in the history

  5. nit refactorings

    @AliSoftware
    AliSoftware committed Feb 1, 2021
    Configuration menu
    Copy the full SHA
    0091bb5 View commit details
    Browse the repository at this point in the history

  6. Fix @example tags in yard doc

    @AliSoftware
    AliSoftware committed Feb 1, 2021
    Configuration menu
    Copy the full SHA
    229a8d5 View commit details
    Browse the repository at this point in the history

  7. Fix @throws -> @raise yard tags

    @AliSoftware
    AliSoftware committed Feb 1, 2021
    Configuration menu
    Copy the full SHA
    5d64c7b View commit details
    Browse the repository at this point in the history

  8. yard nit fixes

    @AliSoftware
    AliSoftware committed Feb 1, 2021
    Configuration menu
    Copy the full SHA
    6fd7b24 View commit details
    Browse the repository at this point in the history

  9. [yard] android_version_helper

    @AliSoftware
    AliSoftware committed Feb 1, 2021
    Configuration menu
    Copy the full SHA
    635249c View commit details
    Browse the repository at this point in the history

  10. [yard] ios_version_helper (nits)

    @AliSoftware
    AliSoftware committed Feb 1, 2021
    Configuration menu
    Copy the full SHA
    0da5978 View commit details
    Browse the repository at this point in the history

  11. yardopts @env

    @AliSoftware
    AliSoftware committed Feb 1, 2021
    Configuration menu
    Copy the full SHA
    3296e3d View commit details
    Browse the repository at this point in the history

  12. Improve @env documentation

    @AliSoftware
    AliSoftware committed Feb 1, 2021
    Configuration menu
    Copy the full SHA
    749e7a2 View commit details
    Browse the repository at this point in the history

  13. [yard] android_version_helper: constants

    @AliSoftware
    AliSoftware committed Feb 1, 2021
    Configuration menu
    Copy the full SHA
    024d971 View commit details
    Browse the repository at this point in the history

  14. [yard] android_version_helper (finalize)

    @AliSoftware
    AliSoftware committed Feb 1, 2021
    Configuration menu
    Copy the full SHA
    05ddd9e View commit details
    Browse the repository at this point in the history

  15. Fix parameter names in screenshots_helpers

    @AliSoftware
    AliSoftware committed Feb 1, 2021
    Configuration menu
    Copy the full SHA
    e52ec0d View commit details
    Browse the repository at this point in the history

  16. formatting fix

    @AliSoftware
    AliSoftware committed Feb 1, 2021
    Configuration menu
    Copy the full SHA
    4ccc052 View commit details
    Browse the repository at this point in the history

  17. module [Platform]::VersionHelper

    @AliSoftware
    AliSoftware committed Feb 1, 2021
    Configuration menu
    Copy the full SHA
    48b2067 View commit details
    Browse the repository at this point in the history

  18. module Ios::L10nHelper

    @AliSoftware
    AliSoftware committed Feb 1, 2021
    Configuration menu
    Copy the full SHA
    05ab6a6 View commit details
    Browse the repository at this point in the history

  19. module [Platform]::GitHelper

    @AliSoftware
    AliSoftware committed Feb 1, 2021
    Configuration menu
    Copy the full SHA
    f2ffe85 View commit details
    Browse the repository at this point in the history

  20. rename module Helpers -> Helper

    @AliSoftware
    AliSoftware committed Feb 1, 2021
    Configuration menu
    Copy the full SHA
    aa30ec4 View commit details
    Browse the repository at this point in the history

  21. module Ios::ADCAppSizesHelper

    @AliSoftware
    AliSoftware committed Feb 1, 2021
    Configuration menu
    Copy the full SHA
    2bdd8d6 View commit details
    Browse the repository at this point in the history

  22. android_localize_helper: split module tree

    @AliSoftware
    AliSoftware committed Feb 1, 2021
    Configuration menu
    Copy the full SHA
    7a5fa31 View commit details
    Browse the repository at this point in the history

  23. android_localize_helper: move file

    @AliSoftware
    AliSoftware committed Feb 1, 2021
    Configuration menu
    Copy the full SHA
    b9c2cad View commit details
    Browse the repository at this point in the history

Commits on Feb 2, 2021

  1. Fix typos/formatting

    @AliSoftware
    AliSoftware committed Feb 2, 2021
    Configuration menu
    Copy the full SHA
    3b280f9 View commit details
    Browse the repository at this point in the history

  2. yardopts CRLF at EOF

    @AliSoftware
    AliSoftware committed Feb 2, 2021
    Configuration menu
    Copy the full SHA
    2bc0401 View commit details
    Browse the repository at this point in the history

  3. abort if PROJECT_ROOT_FOLDER undefined 

    Instead of guessing a possibly wrong default value
    @AliSoftware
    AliSoftware committed Feb 2, 2021
    Configuration menu
    Copy the full SHA
    0813fe6 View commit details
    Browse the repository at this point in the history

  4. Remove constants @group, not really useful

    @AliSoftware
    AliSoftware committed Feb 2, 2021
    Configuration menu
    Copy the full SHA
    263ab3d View commit details
    Browse the repository at this point in the history

  5. Merge pull request #198 from wordpress-mobile/yard-doc/step1 

    [Toolkit Cleanup] Yard doc: step 1 – config cleanup
    @AliSoftware
    AliSoftware authored Feb 2, 2021
    Configuration menu
    Copy the full SHA
    5d8271a View commit details
    Browse the repository at this point in the history

  6. Merge pull request #199 from wordpress-mobile/yard-doc/step2 

    [Toolkit Cleanup] Yard doc: step 2 – rename module Helpers -> Helper
    @AliSoftware
    AliSoftware authored Feb 2, 2021
    Configuration menu
    Copy the full SHA
    57ca5ca View commit details
    Browse the repository at this point in the history

  7. Merge branch 'toolkit-cleanup' into yard-doc/step3

    @AliSoftware
    AliSoftware authored Feb 2, 2021
    Configuration menu
    Copy the full SHA
    fe447cd View commit details
    Browse the repository at this point in the history

  8. Merge pull request #200 from wordpress-mobile/yard-doc/step3 

    [Toolkit Cleanup] Yard doc: step 3 - reorganize modules for helpers
    @AliSoftware
    AliSoftware authored Feb 2, 2021
    Configuration menu
    Copy the full SHA
    5891fe3 View commit details
    Browse the repository at this point in the history

Commits on Feb 4, 2021

  1. git_checkout_and_pull[_release_branch_for]

    @AliSoftware
    AliSoftware committed Feb 4, 2021
    Configuration menu
    Copy the full SHA
    a65adac View commit details
    Browse the repository at this point in the history

  2. branch_for_hotfix

    @AliSoftware
    AliSoftware committed Feb 4, 2021
    Configuration menu
    Copy the full SHA
    6e7ada6 View commit details
    Browse the repository at this point in the history

  3. tag_and_push

    @AliSoftware
    AliSoftware committed Feb 4, 2021
    Configuration menu
    Copy the full SHA
    f6d3535 View commit details
    Browse the repository at this point in the history

  4. tag_build

    @AliSoftware
    AliSoftware committed Feb 4, 2021
    Configuration menu
    Copy the full SHA
    a4bf563 View commit details
    Browse the repository at this point in the history

  5. final_tag

    @AliSoftware
    AliSoftware committed Feb 4, 2021
    Configuration menu
    Copy the full SHA
    65e2275 View commit details
    Browse the repository at this point in the history

  6. is_head_on_tag + has_final_tag_for

    @AliSoftware
    AliSoftware committed Feb 4, 2021
    Configuration menu
    Copy the full SHA
    9b1ba06 View commit details
    Browse the repository at this point in the history

  7. do_release_branch

    @AliSoftware
    AliSoftware committed Feb 4, 2021
    Configuration menu
    Copy the full SHA
    15f622d View commit details
    Browse the repository at this point in the history

  8. create_branch_for_hotfix -> cut_hotfix_branch

    @AliSoftware
    AliSoftware committed Feb 4, 2021
    Configuration menu
    Copy the full SHA
    850cf6b View commit details
    Browse the repository at this point in the history

  9. check_on_branch

    @AliSoftware
    AliSoftware committed Feb 4, 2021
    Configuration menu
    Copy the full SHA
    2bd0cca View commit details
    Browse the repository at this point in the history

  10. cut_[release|hotfix]_branch -> create_branch

    @AliSoftware
    AliSoftware committed Feb 4, 2021
    Configuration menu
    Copy the full SHA
    ad48226 View commit details
    Browse the repository at this point in the history

  11. Android::GitHelper::bump_version_*

    @AliSoftware
    AliSoftware committed Feb 4, 2021
    Configuration menu
    Copy the full SHA
    ba703f7 View commit details
    Browse the repository at this point in the history

  12. Ios::GitHelper.bump_version_*

    @AliSoftware
    AliSoftware committed Feb 4, 2021
    Configuration menu
    Copy the full SHA
    320bc4d View commit details
    Browse the repository at this point in the history

  13. commit_version_bump YARD doc

    @AliSoftware
    AliSoftware committed Feb 4, 2021
    Configuration menu
    Copy the full SHA
    22a8cea View commit details
    Browse the repository at this point in the history

  14. delete_tags

    @AliSoftware
    AliSoftware committed Feb 4, 2021
    Configuration menu
    Copy the full SHA
    7347b54 View commit details
    Browse the repository at this point in the history

  15. move update_metadata for consistency with iOS

    @AliSoftware
    AliSoftware committed Feb 4, 2021
    Configuration menu
    Copy the full SHA
    289369c View commit details
    Browse the repository at this point in the history

  16. Ios::GitHelper.localize_project

    @AliSoftware
    AliSoftware committed Feb 4, 2021
    Configuration menu
    Copy the full SHA
    754d901 View commit details
    Browse the repository at this point in the history

  17. update_metadata()

    @AliSoftware
    AliSoftware committed Feb 4, 2021
    Configuration menu
    Copy the full SHA
    4c82a0d View commit details
    Browse the repository at this point in the history

  18. YARD doc for remaining git_helper methods

    @AliSoftware
    AliSoftware committed Feb 4, 2021
    Configuration menu
    Copy the full SHA
    e68f6a1 View commit details
    Browse the repository at this point in the history

  19. YARD doc for Git* modules

    @AliSoftware
    AliSoftware committed Feb 4, 2021
    Configuration menu
    Copy the full SHA
    e94273b View commit details
    Browse the repository at this point in the history

Commits on Feb 8, 2021

  1. Typo in YARD comment

    @AliSoftware
    AliSoftware committed Feb 8, 2021
    Configuration menu
    Copy the full SHA
    237746d View commit details
    Browse the repository at this point in the history

Commits on Feb 9, 2021

  1. Add todo in *_git_helper methods calling scripts

    @AliSoftware
    AliSoftware committed Feb 9, 2021
    Configuration menu
    Copy the full SHA
    e3264c7 View commit details
    Browse the repository at this point in the history

  2. Merge pull request #206 from wordpress-mobile/cleanup/git-helpers 

    [Tooling/Cleanup] Cleanup git helpers
    @AliSoftware
    AliSoftware authored Feb 9, 2021
    Configuration menu
    Copy the full SHA
    34ed934 View commit details
    Browse the repository at this point in the history

  3. Configure rubocop rules and list of violations to fix

    @AliSoftware
    AliSoftware committed Feb 9, 2021
    Configuration menu
    Copy the full SHA
    b5308c0 View commit details
    Browse the repository at this point in the history

  4. git ignore .idea (RubyMine files)

    @AliSoftware
    AliSoftware committed Feb 9, 2021
    Configuration menu
    Copy the full SHA
    e876196 View commit details
    Browse the repository at this point in the history

  5. Rename GHHelperHelper>GithubHelper and GHClient

    @AliSoftware
    AliSoftware committed Feb 9, 2021
    Configuration menu
    Copy the full SHA
    c01f0f7 View commit details
    Browse the repository at this point in the history

  6. Fix rubocop offenses in github_helper.rb

    @AliSoftware
    AliSoftware committed Feb 9, 2021
    Configuration menu
    Copy the full SHA
    1c784b7 View commit details
    Browse the repository at this point in the history

  7. [rubocop] fix Layout/LeadingCommentSpace

    @AliSoftware
    AliSoftware committed Feb 9, 2021
    Configuration menu
    Copy the full SHA
    2d070a6 View commit details
    Browse the repository at this point in the history

  8. [rubocop] fix Layout/SpaceAfterComma

    @AliSoftware
    AliSoftware committed Feb 9, 2021
    Configuration menu
    Copy the full SHA
    9cb90ca View commit details
    Browse the repository at this point in the history

  9. [rubocop] fix Layout/SpaceAroundBlockParameters

    @AliSoftware
    AliSoftware committed Feb 9, 2021
    Configuration menu
    Copy the full SHA
    0652acb View commit details
    Browse the repository at this point in the history

  10. [rubocop] fix Layout/SpaceAroundKeyword

    @AliSoftware
    AliSoftware committed Feb 9, 2021
    Configuration menu
    Copy the full SHA
    76de887 View commit details
    Browse the repository at this point in the history

  11. [rubocop] fix Layout/SpaceAroundOperators

    @AliSoftware
    AliSoftware committed Feb 9, 2021
    Configuration menu
    Copy the full SHA
    d3f121f View commit details
    Browse the repository at this point in the history

  12. [rubocop] fix Layout/SpaceBeforeBlockBraces

    @AliSoftware
    AliSoftware committed Feb 9, 2021
    Configuration menu
    Copy the full SHA
    651a3d9 View commit details
    Browse the repository at this point in the history

  13. [rubocop] fix Layout/SpaceInLambdaLiteral

    @AliSoftware
    AliSoftware committed Feb 9, 2021
    Configuration menu
    Copy the full SHA
    3524996 View commit details
    Browse the repository at this point in the history

  14. [rubocop] fix Layout/SpaceInsideArrayLiteralBrackets

    @AliSoftware
    AliSoftware committed Feb 9, 2021
    Configuration menu
    Copy the full SHA
    bb862da View commit details
    Browse the repository at this point in the history

  15. [rubocop] fix Layout/SpaceInsideBlockBraces

    @AliSoftware
    AliSoftware committed Feb 9, 2021
    Configuration menu
    Copy the full SHA
    3f63ddf View commit details
    Browse the repository at this point in the history

  16. [rubocop] fix Layout/SpaceInsideHashLiteralBraces

    @AliSoftware
    AliSoftware committed Feb 9, 2021
    Configuration menu
    Copy the full SHA
    2084482 View commit details
    Browse the repository at this point in the history

  17. [rubocop] fix Layout/SpaceInsideParens

    @AliSoftware
    AliSoftware committed Feb 9, 2021
    Configuration menu
    Copy the full SHA
    3047fb8 View commit details
    Browse the repository at this point in the history

  18. [rubocop] fix Layout/TrailingBlankLines

    @AliSoftware
    AliSoftware committed Feb 9, 2021
    Configuration menu
    Copy the full SHA
    f8f5e19 View commit details
    Browse the repository at this point in the history

  19. [rubocop] fix Layout/TrailingWhitespace

    @AliSoftware
    AliSoftware committed Feb 9, 2021
    Configuration menu
    Copy the full SHA
    5b7fe81 View commit details
    Browse the repository at this point in the history

  20. [rubocop] fix Style/ColonMethodCall

    @AliSoftware
    AliSoftware committed Feb 9, 2021
    Configuration menu
    Copy the full SHA
    4eb8cb5 View commit details
    Browse the repository at this point in the history

  21. [rubocop] fix Layout/CommentIndentation

    @AliSoftware
    AliSoftware committed Feb 9, 2021
    Configuration menu
    Copy the full SHA
    e47e1fa View commit details
    Browse the repository at this point in the history

  22. [rubocop] fix Layout/MultilineMethodCallIndentation

    @AliSoftware
    AliSoftware committed Feb 9, 2021
    Configuration menu
    Copy the full SHA
    1441c8e View commit details
    Browse the repository at this point in the history

  23. [rubocop] fix Layout/MultilineMethodCallBraceLayout

    @AliSoftware
    AliSoftware committed Feb 9, 2021
    Configuration menu
    Copy the full SHA
    acbf3f8 View commit details
    Browse the repository at this point in the history

  24. [rubocop] Re-run --auto-gen-config

    @AliSoftware
    AliSoftware committed Feb 9, 2021
    Configuration menu
    Copy the full SHA
    764d779 View commit details
    Browse the repository at this point in the history

  25. Fix gitignore comment

    @AliSoftware
    AliSoftware committed Feb 9, 2021
    Configuration menu
    Copy the full SHA
    622b99c View commit details
    Browse the repository at this point in the history

  26. Move "Style/StringLiterals" to todo rules

    @AliSoftware
    AliSoftware committed Feb 9, 2021
    Configuration menu
    Copy the full SHA
    f6559c4 View commit details
    Browse the repository at this point in the history

  27. Increase the checkout/fetch depth for Danger action

    @AliSoftware
    AliSoftware committed Feb 9, 2021
    Configuration menu
    Copy the full SHA
    d893cdf View commit details
    Browse the repository at this point in the history

  28. Merge pull request #207 from wordpress-mobile/rubocop-fixes/step-1 

    [Tooling/Cleanup] Enable Rubocop and fixes first steps
    @AliSoftware
    AliSoftware authored Feb 9, 2021
    Configuration menu
    Copy the full SHA
    89de96c View commit details
    Browse the repository at this point in the history

Commits on Feb 11, 2021

  1. [rubocop] fix Style/StringLiterals

    @AliSoftware
    AliSoftware committed Feb 11, 2021
    Configuration menu
    Copy the full SHA
    b1a256f View commit details
    Browse the repository at this point in the history

  2. fix ext/drawText/extconf.rb path constructors

    @AliSoftware
    AliSoftware committed Feb 11, 2021
    Configuration menu
    Copy the full SHA
    15c2400 View commit details
    Browse the repository at this point in the history

  3. [rubocop] fix Layout/AlignArray

    @AliSoftware
    AliSoftware committed Feb 11, 2021
    Configuration menu
    Copy the full SHA
    427db8f View commit details
    Browse the repository at this point in the history

  4. [rubocop] fix Layout/CaseIndentation

    @AliSoftware
    AliSoftware committed Feb 11, 2021
    Configuration menu
    Copy the full SHA
    3cdc4a8 View commit details
    Browse the repository at this point in the history

  5. [rubocop] fix Layout/IndentationConsistency

    @AliSoftware
    AliSoftware committed Feb 11, 2021
    Configuration menu
    Copy the full SHA
    75ef6a6 View commit details
    Browse the repository at this point in the history

  6. [rubocop] fix Layout/EmptyLines

    @AliSoftware
    AliSoftware committed Feb 11, 2021
    Configuration menu
    Copy the full SHA
    53659f7 View commit details
    Browse the repository at this point in the history

  7. [rubocop] fix Layout/AlignHash

    @AliSoftware
    AliSoftware committed Feb 11, 2021
    Configuration menu
    Copy the full SHA
    1ffb07a View commit details
    Browse the repository at this point in the history

  8. [rubocop] fix Layout/BlockAlignment

    @AliSoftware
    AliSoftware committed Feb 11, 2021
    Configuration menu
    Copy the full SHA
    85af547 View commit details
    Browse the repository at this point in the history

  9. [rubocop] fix Layout/IndentationWidth

    @AliSoftware
    AliSoftware committed Feb 11, 2021
    Configuration menu
    Copy the full SHA
    66f3019 View commit details
    Browse the repository at this point in the history

  10. [rubocop] fix Layout/IndentFirstArrayElement

    @AliSoftware
    AliSoftware committed Feb 11, 2021
    Configuration menu
    Copy the full SHA
    4749cfa View commit details
    Browse the repository at this point in the history

  11. [rubocop] fix Layout/IndentFirstHashElement

    @AliSoftware
    AliSoftware committed Feb 11, 2021
    Configuration menu
    Copy the full SHA
    b6eea80 View commit details
    Browse the repository at this point in the history

  12. [rubocop] fix Layout/IndentHeredoc

    @AliSoftware
    AliSoftware committed Feb 11, 2021
    Configuration menu
    Copy the full SHA
    8ef35af View commit details
    Browse the repository at this point in the history

  13. [rubocop] fix Layout/EndAlignment

    @AliSoftware
    AliSoftware committed Feb 11, 2021
    Configuration menu
    Copy the full SHA
    71c72f6 View commit details
    Browse the repository at this point in the history

  14. [rubocop] fix Layout/Tab

    @AliSoftware
    AliSoftware committed Feb 11, 2021
    Configuration menu
    Copy the full SHA
    ba0c4fc View commit details
    Browse the repository at this point in the history

  15. [rubocop] fix Layout/EmptyLineAfterGuardClause

    @AliSoftware
    AliSoftware committed Feb 11, 2021
    Configuration menu
    Copy the full SHA
    2fe7b5a View commit details
    Browse the repository at this point in the history

  16. [rubocop] fix Layout/EmptyLinesAroundAccessModifier

    @AliSoftware
    AliSoftware committed Feb 11, 2021
    Configuration menu
    Copy the full SHA
    21926b3 View commit details
    Browse the repository at this point in the history

  17. [rubocop] fix Layout/EmptyLinesAroundArguments

    @AliSoftware
    AliSoftware committed Feb 11, 2021
    Configuration menu
    Copy the full SHA
    197566f View commit details
    Browse the repository at this point in the history

  18. [rubocop] fix Layout/EmptyLinesAroundBlockBody

    @AliSoftware
    AliSoftware committed Feb 11, 2021
    Configuration menu
    Copy the full SHA
    785275c View commit details
    Browse the repository at this point in the history

  19. [rubocop] fix Layout/EmptyLinesAroundClassBody

    @AliSoftware
    AliSoftware committed Feb 11, 2021
    Configuration menu
    Copy the full SHA
    52df694 View commit details
    Browse the repository at this point in the history

  20. [rubocop] fix Layout/EmptyLinesAroundExceptionHandlingKeywords

    @AliSoftware
    AliSoftware committed Feb 11, 2021
    Configuration menu
    Copy the full SHA
    32af96f View commit details
    Browse the repository at this point in the history

  21. [rubocop] fix Layout/EmptyLinesAroundMethodBody

    @AliSoftware
    AliSoftware committed Feb 11, 2021
    Configuration menu
    Copy the full SHA
    a4c7d53 View commit details
    Browse the repository at this point in the history

  22. [rubocop] fix Layout/EmptyLinesAroundModuleBody

    @AliSoftware
    AliSoftware committed Feb 11, 2021
    Configuration menu
    Copy the full SHA
    7f6558d View commit details
    Browse the repository at this point in the history

  23. [rubocop] fix Layout/ExtraSpacing

    @AliSoftware
    AliSoftware committed Feb 11, 2021
    Configuration menu
    Copy the full SHA
    aad7637 View commit details
    Browse the repository at this point in the history

  24. [rubocop] fix Layout/LeadingBlankLines

    @AliSoftware
    AliSoftware committed Feb 11, 2021
    Configuration menu
    Copy the full SHA
    7ec4c5e View commit details
    Browse the repository at this point in the history

Commits on Feb 12, 2021

  1. Merge pull request #210 from wordpress-mobile/cleanup/rubocop/step2 

    [Cleanup/rubocop] Step2: Indentation and Alignment violations
    @AliSoftware
    AliSoftware authored Feb 12, 2021
    Configuration menu
    Copy the full SHA
    a093c06 View commit details
    Browse the repository at this point in the history

  2. Merge pull request #211 from wordpress-mobile/cleanup/rubocop/step3 

    [Cleanup/rubocop] Step3: Spacing and Empty Lines
    @AliSoftware
    AliSoftware authored Feb 12, 2021
    Configuration menu
    Copy the full SHA
    9ae4e2d View commit details
    Browse the repository at this point in the history

Commits on Feb 15, 2021

  1. [rubocop] fix Lint/AssignmentInCondition

    @AliSoftware
    AliSoftware committed Feb 15, 2021
    Configuration menu
    Copy the full SHA
    5d91148 View commit details
    Browse the repository at this point in the history

  2. [rubocop] fix Lint/DeprecatedClassMethods

    @AliSoftware
    AliSoftware committed Feb 15, 2021
    Configuration menu
    Copy the full SHA
    75a35ea View commit details
    Browse the repository at this point in the history

  3. [rubocop] fix Lint/StringConversionInInterpolation

    @AliSoftware
    AliSoftware committed Feb 15, 2021
    Configuration menu
    Copy the full SHA
    9972c26 View commit details
    Browse the repository at this point in the history

  4. [rubocop] fix Lint/UnusedBlockArgument

    @AliSoftware
    AliSoftware committed Feb 15, 2021
    Configuration menu
    Copy the full SHA
    19ac40b View commit details
    Browse the repository at this point in the history

  5. [rubocop] disable Lint/UnusedMethodArgument (manual)

    @AliSoftware
    AliSoftware committed Feb 15, 2021
    Configuration menu
    Copy the full SHA
    86f4f0b View commit details
    Browse the repository at this point in the history

  6. [rubocop] fix Lint/ParenthesesAsGroupedExpression (manual)

    @AliSoftware
    AliSoftware committed Feb 15, 2021
    Configuration menu
    Copy the full SHA
    c748791 View commit details
    Browse the repository at this point in the history

  7. [rubocop] fix Lint/ShadowingOuterLocalVariable (manual)

    @AliSoftware
    AliSoftware committed Feb 15, 2021
    Configuration menu
    Copy the full SHA
    3b81d20 View commit details
    Browse the repository at this point in the history

Commits on Feb 18, 2021

  1. [rubocop] fix Style/AndOr

    @AliSoftware
    AliSoftware committed Feb 18, 2021
    Configuration menu
    Copy the full SHA
    9a604f2 View commit details
    Browse the repository at this point in the history

  2. [rubocop] fix Style/BarePercentLiterals

    @AliSoftware
    AliSoftware committed Feb 18, 2021
    Configuration menu
    Copy the full SHA
    3c24919 View commit details
    Browse the repository at this point in the history

  3. [rubocop] fix Style/BlockDelimiters

    @AliSoftware
    AliSoftware committed Feb 18, 2021
    Configuration menu
    Copy the full SHA
    604b017 View commit details
    Browse the repository at this point in the history

  4. [rubocop] fix Style/BracesAroundHashParameters

    @AliSoftware
    AliSoftware committed Feb 18, 2021
    Configuration menu
    Copy the full SHA
    70c7b6e View commit details
    Browse the repository at this point in the history

  5. [rubocop] fix Style/ClassAndModuleChildren

    @AliSoftware
    AliSoftware committed Feb 18, 2021
    Configuration menu
    Copy the full SHA
    75c9583 View commit details
    Browse the repository at this point in the history

  6. Merge pull request #213 from wordpress-mobile/cleanup/rubocop/step4 

    Cleanup - Step 4
    @AliSoftware
    AliSoftware authored Feb 18, 2021
    Configuration menu
    Copy the full SHA
    c3efa66 View commit details
    Browse the repository at this point in the history

  7. [rubocop] fix Style/ClassCheck

    @AliSoftware
    AliSoftware committed Feb 18, 2021
    Configuration menu
    Copy the full SHA
    a9d818d View commit details
    Browse the repository at this point in the history

  8. [rubocop] fix Style/ConditionalAssignment

    @AliSoftware
    AliSoftware committed Feb 18, 2021
    Configuration menu
    Copy the full SHA
    3bb7aed View commit details
    Browse the repository at this point in the history

  9. [rubocop] fix Style/DefWithParentheses

    @AliSoftware
    AliSoftware committed Feb 18, 2021
    Configuration menu
    Copy the full SHA
    bfb40c9 View commit details
    Browse the repository at this point in the history

  10. [rubocop] fix Style/EmptyLiteral

    @AliSoftware
    AliSoftware committed Feb 18, 2021
    Configuration menu
    Copy the full SHA
    bda5e57 View commit details
    Browse the repository at this point in the history

  11. [rubocop] configure Style/EmptyMethod

    @AliSoftware
    AliSoftware committed Feb 18, 2021
    Configuration menu
    Copy the full SHA
    2a93320 View commit details
    Browse the repository at this point in the history

  12. [rubocop] fix Style/Encoding

    @AliSoftware
    AliSoftware committed Feb 18, 2021
    Configuration menu
    Copy the full SHA
    9c77eca View commit details
    Browse the repository at this point in the history

  13. [rubocop] fix Style/ExpandPathArguments

    @AliSoftware
    AliSoftware committed Feb 18, 2021
    Configuration menu
    Copy the full SHA
    9f2c690 View commit details
    Browse the repository at this point in the history

  14. [rubocop] fix Style/FormatString

    @AliSoftware
    AliSoftware committed Feb 18, 2021
    Configuration menu
    Copy the full SHA
    4a56484 View commit details
    Browse the repository at this point in the history

  15. [rubocop] disable Style/FrozenStringLiteralComment 

    Because enabling it, even if it's recommended, require very careful tests and review to avoid accidental runtime crashes
    @AliSoftware
    AliSoftware committed Feb 18, 2021
    Configuration menu
    Copy the full SHA
    191e9e5 View commit details
    Browse the repository at this point in the history

  16. [rubocop] fix Style/HashSyntax

    @AliSoftware
    AliSoftware committed Feb 18, 2021
    Configuration menu
    Copy the full SHA
    5830fc7 View commit details
    Browse the repository at this point in the history

  17. [rubocop] fix Style/IfUnlessModifier

    @AliSoftware
    AliSoftware committed Feb 18, 2021
    Configuration menu
    Copy the full SHA
    a882be7 View commit details
    Browse the repository at this point in the history

  18. [rubocop] fix Style/InverseMethods

    @AliSoftware
    AliSoftware committed Feb 18, 2021
    Configuration menu
    Copy the full SHA
    7fe4b1a View commit details
    Browse the repository at this point in the history

  19. [rubocop] fix Style/ParenthesesAroundCondition

    @AliSoftware
    AliSoftware committed Feb 18, 2021
    Configuration menu
    Copy the full SHA
    4cb320a View commit details
    Browse the repository at this point in the history

  20. [rubocop] fix Style/MultilineIfThen

    @AliSoftware
    AliSoftware committed Feb 18, 2021
    Configuration menu
    Copy the full SHA
    0250763 View commit details
    Browse the repository at this point in the history

  21. [rubocop] fix Style/NegatedIf

    @AliSoftware
    AliSoftware committed Feb 18, 2021
    Configuration menu
    Copy the full SHA
    3750c49 View commit details
    Browse the repository at this point in the history

  22. [rubocop] fix Style/NegatedUnless

    @AliSoftware
    AliSoftware committed Feb 18, 2021
    Configuration menu
    Copy the full SHA
    0bc24dc View commit details
    Browse the repository at this point in the history

  23. [rubocop] fix Style/NilComparison

    @AliSoftware
    AliSoftware committed Feb 18, 2021
    Configuration menu
    Copy the full SHA
    79995c3 View commit details
    Browse the repository at this point in the history

  24. [rubocop] fix Style/NonNilCheck (safe-auto-correct)

    @AliSoftware
    AliSoftware committed Feb 18, 2021
    Configuration menu
    Copy the full SHA
    6de7f59 View commit details
    Browse the repository at this point in the history

  25. [rubocop] fix Style/NonNilCheck (manual fixes) ⚠️

    @AliSoftware
    AliSoftware committed Feb 18, 2021
    Configuration menu
    Copy the full SHA
    b7691b6 View commit details
    Browse the repository at this point in the history

  26. [rubocop] ⚠️ Manual fix of Metrics/AbcSize 

    Used RubyMine's refactoring feature to extract the big chunk of code building the entries into its private method, to reduce the self.run(…)'s complexity
    @AliSoftware
    AliSoftware committed Feb 18, 2021
    Configuration menu
    Copy the full SHA
    f84285d View commit details
    Browse the repository at this point in the history

  27. [rubocop] fix Style/Not

    @AliSoftware
    AliSoftware committed Feb 18, 2021
    Configuration menu
    Copy the full SHA
    27fd9d1 View commit details
    Browse the repository at this point in the history

  28. [rubocop] fix Style/NumericLiteralPrefix

    @AliSoftware
    AliSoftware committed Feb 18, 2021
    Configuration menu
    Copy the full SHA
    7976a90 View commit details
    Browse the repository at this point in the history

  29. [rubocop] fix Style/PercentLiteralDelimiters

    @AliSoftware
    AliSoftware committed Feb 18, 2021
    Configuration menu
    Copy the full SHA
    9d47d7d View commit details
    Browse the repository at this point in the history

  30. [rubocop] fix Style/RegexpLiteral

    @AliSoftware
    AliSoftware committed Feb 18, 2021
    Configuration menu
    Copy the full SHA
    461eb41 View commit details
    Browse the repository at this point in the history

  31. [rubocop] fix Style/Semicolon

    @AliSoftware
    AliSoftware committed Feb 18, 2021
    Configuration menu
    Copy the full SHA
    16a9ecb View commit details
    Browse the repository at this point in the history

  32. [rubocop] fix Style/StringLiteralsInInterpolation

    @AliSoftware
    AliSoftware committed Feb 18, 2021
    Configuration menu
    Copy the full SHA
    dc044c3 View commit details
    Browse the repository at this point in the history

  33. [rubocop] fix Style/TrailingCommaInArguments

    @AliSoftware
    AliSoftware committed Feb 18, 2021
    Configuration menu
    Copy the full SHA
    9c5080d View commit details
    Browse the repository at this point in the history

  34. [rubocop] fix Style/TrailingCommaInArrayLiteral

    @AliSoftware
    AliSoftware committed Feb 18, 2021
    Configuration menu
    Copy the full SHA
    3b6252c View commit details
    Browse the repository at this point in the history

  35. [rubocop] fix Style/TrailingCommaInHashLiteral

    @AliSoftware
    AliSoftware committed Feb 18, 2021
    Configuration menu
    Copy the full SHA
    17b1e76 View commit details
    Browse the repository at this point in the history

  36. Merge branch 'cleanup/rubocop/step5' into merge-develop-into-cleanup 

    # Conflicts:
#	Gemfile
#	Gemfile.lock
    @AliSoftware
    AliSoftware committed Feb 18, 2021
    Configuration menu
    Copy the full SHA
    da50f50 View commit details
    Browse the repository at this point in the history

  37. [rubocop] auto-correct new code from develop

    @AliSoftware
    AliSoftware committed Feb 18, 2021
    Configuration menu
    Copy the full SHA
    4b68f3b View commit details
    Browse the repository at this point in the history

  38. [rubocop] fix Metrics/LineLength (in new code from develop)

    @AliSoftware
    AliSoftware committed Feb 18, 2021
    Configuration menu
    Copy the full SHA
    c89d683 View commit details
    Browse the repository at this point in the history

  39. [rubocop] Regen todo config for code from develop

    @AliSoftware
    AliSoftware committed Feb 18, 2021
    Configuration menu
    Copy the full SHA
    fe48a8c View commit details
    Browse the repository at this point in the history

Commits on Feb 24, 2021

  1. Add comment about octal notation for chmod-like flags

    @AliSoftware
    AliSoftware authored Feb 24, 2021
    Configuration menu
    Copy the full SHA
    4492cc7 View commit details
    Browse the repository at this point in the history

  2. [rubocop] fix Style/TrailingCommaInArrayLiteral 

    Change the setting of the rule from the default (no_comma) to consistent_comma, which better matches our style
    @AliSoftware
    AliSoftware committed Feb 24, 2021
    Configuration menu
    Copy the full SHA
    f6499f7 View commit details
    Browse the repository at this point in the history

  3. build_entries doesn't need the whole config Hash

    @AliSoftware
    AliSoftware committed Feb 24, 2021
    Configuration menu
    Copy the full SHA
    fd8d9bd View commit details
    Browse the repository at this point in the history

  4. Merge pull request #214 from wordpress-mobile/cleanup/rubocop/step5 

    [rubocop] Step 5
    @AliSoftware
    AliSoftware authored Feb 24, 2021
    Configuration menu
    Copy the full SHA
    6fffd84 View commit details
    Browse the repository at this point in the history

  5. Merge pull request #215 from wordpress-mobile/merge-develop-into-cleanup 

    Merge develop into cleanup
    @AliSoftware
    AliSoftware authored Feb 24, 2021
    Configuration menu
    Copy the full SHA
    74a3982 View commit details
    Browse the repository at this point in the history

  6. [rubocop] disable Style/AsciiComments rule

    @AliSoftware
    AliSoftware committed Feb 24, 2021
    Configuration menu
    Copy the full SHA
    e9cbc69 View commit details
    Browse the repository at this point in the history

  7. [rubocop] fix Style/Lambda

    @AliSoftware
    AliSoftware committed Feb 24, 2021
    Configuration menu
    Copy the full SHA
    d096f63 View commit details
    Browse the repository at this point in the history

  8. [rubocop] fix Style/UnneededInterpolation

    @AliSoftware
    AliSoftware committed Feb 24, 2021
    Configuration menu
    Copy the full SHA
    83a4d0d View commit details
    Browse the repository at this point in the history

  9. [ruboco] run safe-auto-correct + auto-gen-config after rebase

    @AliSoftware
    AliSoftware committed Feb 24, 2021
    Configuration menu
    Copy the full SHA
    ee543ca View commit details
    Browse the repository at this point in the history

Commits on Feb 25, 2021

  1. Remove some extra .to_s calls 

    Co-authored-by: Gio Lodi <[email protected]>
    @AliSoftware @mokagio
    AliSoftware and mokagio authored Feb 25, 2021
    Configuration menu
    Copy the full SHA
    98af7e7 View commit details
    Browse the repository at this point in the history

  2. Provide some rationale for custom Style rules

    @AliSoftware
    AliSoftware committed Feb 25, 2021
    Configuration menu
    Copy the full SHA
    70fb5d5 View commit details
    Browse the repository at this point in the history

  3. Merge pull request #217 from wordpress-mobile/cleanup/rubocop/6 

    [Cleanup/rubocop] Step 6
    @AliSoftware
    AliSoftware authored Feb 25, 2021
    Configuration menu
    Copy the full SHA
    228044e View commit details
    Browse the repository at this point in the history