fix: correctly codegen maps with enum keys #1052
Conversation
|
|
||
| val sparseMapSymbol = provider.toSymbol(model.expectShape<MapShape>("${TestModelDefault.NAMESPACE}#MySparseMap")) | ||
|
|
||
| assertEquals("Map<String, Record?>", sparseMapSymbol.name) | ||
|
|
||
| // collections should contain a reference to the member type | ||
| assertEquals("Record", sparseMapSymbol.references[0].symbol.name) | ||
| val sparseRefNames = mapSymbol.references.map { it.symbol.fullName } |
There was a problem hiding this comment.
question: is this supposed to use sparseMapSymbol instead of mapSymbol?
There was a problem hiding this comment.
Yes it is, good catch!
BREAKING-CHANGE.tmp.md
Outdated
|
|
||
| # Release date | ||
|
|
||
| This feature will ship with the **v1.0.80** release planned for **3/18/2024**. |
There was a problem hiding this comment.
Are we doing a minor version bump?
There was a problem hiding this comment.
Oh yep, we are. I guess this will ship with v1.1.0.
|
| { | ||
| "id": "a7f82a33-11f1-4184-97af-ff713e922dfc", | ||
| "type": "bugfix", | ||
| "description": "⚠️ **IMPORTANT**: Fix codegen for map shapes which use string enums as map keys. See the Map Enum Keys breaking change announcement (link coming soon) for more details", |
There was a problem hiding this comment.
Looks good! I have a question, will this ship with the link or will it be added after?
There was a problem hiding this comment.
It will ship with the link. Now that the PR is approved, I'll remove the BREAKING-CHANGE.tmp.md file, post it as a GH discussion, update the changelog to include a link, and then merge the code to main.
Issue #
#1045
Description of changes
This change fixes the accidental generation of all map keys as strings when keys can also be string enums.
This change also adds a new flag to our
KotlinSettingstype used in smithy-build.json files calleddebug. When enabled, it will turn on stack frame emission in codegen which aids in codegen debug.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.