fix: correctly codegen maps which use nested maps that contain enum keys #1054
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ianbotsf
added
the
no-changelog
lauzadis
approved these changes
Mar 18, 2024
tkhill-AWS
pushed a commit
to tkhill-AWS/smithy-kotlin
that referenced
this pull request
Mar 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #
Missed in #1052 which addresses #1045
Description of changes
Correctly handle nested maps in codegen. (e.g.,
Map<OuterEnumType, Map<InnerEnumType, String>>) and add a unit test to verify.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.