Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: correctly codegen maps with enum keys #1052

Merged
merged 5 commits into from
Mar 15, 2024
Merged

fix: correctly codegen maps with enum keys #1052

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
2f0a9e0
fix: correctly codegen maps with enum keys
ianbotsf Mar 12, 2024
e7e2096
fix bug in tests
ianbotsf Mar 13, 2024
6aeecf8
include draft breaking change announcement
ianbotsf Mar 13, 2024
4cd52d5
correct breaking version number
ianbotsf Mar 14, 2024
e614dda
updating changelog to final revision, removing temporary breaking cha…
ianbotsf Mar 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions .changes/a7f82a33-11f1-4184-97af-ff713e922dfc.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
{
"id": "a7f82a33-11f1-4184-97af-ff713e922dfc",
"type": "bugfix",
"description": "⚠️ **IMPORTANT**: Fix codegen for map shapes which use string enums as map keys. See the Map Enum Keys breaking change announcement (link coming soon) for more details",
Copy link
Contributor

@0marperez 0marperez Mar 14, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I have a question, will this ship with the link or will it be added after?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It will ship with the link. Now that the PR is approved, I'll remove the BREAKING-CHANGE.tmp.md file, post it as a GH discussion, update the changelog to include a link, and then merge the code to main.

"issues": [
"awslabs/smithy-kotlin#1045"
],
"requiresMinorVersionBump": true
}
Loading
Loading