Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Cleanup/rubocop] 6 #217

Merged
merged 6 commits into from
Feb 25, 2021
Merged

[Cleanup/rubocop] 6 #217

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
e9cbc69
[rubocop] disable Style/AsciiComments rule
AliSoftware Feb 24, 2021
d096f63
[rubocop] fix Style/Lambda
AliSoftware Feb 24, 2021
83a4d0d
[rubocop] fix Style/UnneededInterpolation
AliSoftware Feb 24, 2021
ee543ca
[ruboco] run safe-auto-correct + auto-gen-config after rebase
AliSoftware Feb 24, 2021
98af7e7
Remove some extra .to_s calls
AliSoftware Feb 25, 2021
70fb5d5
Provide some rationale for custom Style rules
AliSoftware Feb 25, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions .rubocop.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,9 +16,13 @@ Gemspec/OrderedDependencies:
Lint/UnusedMethodArgument:
Enabled: false

# We have a couple of empty methods especially when we implement an API contract on our Action subclasses
# and those look nicer to us when still written as expended (in separate lines) to suggest us to fill them at some point
# rather than the compact representation of having them one-liner `def foo; end` that is rubocop's default.
Style/EmptyMethod:
EnforcedStyle: expanded

# Trailing commas in array literals helps having smaller diffs when we want to add additional parameters
Copy link
Contributor

@mokagio mokagio Feb 26, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Totally out of topic and not really a Ruby friendly thing, but I do love how Elm does trailing commas

[ "this"
, "makes"
, "for"
, "clear"
, "diffs"
]

Style/TrailingCommaInArrayLiteral:
EnforcedStyleForMultiline: consistent_comma

Expand All @@ -29,6 +33,8 @@ Style/TrailingCommaInArrayLiteral:
Style/FrozenStringLiteralComment:
Enabled: false

# Unicode is pretty standard by now, and we want to be able to use em-dash, ellipsis, and unicode characters
# to provide nice Monodraw.app graphs and similar, without being limited only by ascii.
Style/AsciiComments:
Enabled: false

Expand Down