-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Cleanup/rubocop] 6 #217
[Cleanup/rubocop] 6 #217
Changes from all commits
e9cbc69
d096f63
83a4d0d
ee543ca
98af7e7
70fb5d5
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -16,9 +16,13 @@ Gemspec/OrderedDependencies: | |
Lint/UnusedMethodArgument: | ||
Enabled: false | ||
|
||
# We have a couple of empty methods especially when we implement an API contract on our Action subclasses | ||
# and those look nicer to us when still written as expended (in separate lines) to suggest us to fill them at some point | ||
# rather than the compact representation of having them one-liner `def foo; end` that is rubocop's default. | ||
Style/EmptyMethod: | ||
EnforcedStyle: expanded | ||
|
||
# Trailing commas in array literals helps having smaller diffs when we want to add additional parameters | ||
Style/TrailingCommaInArrayLiteral: | ||
EnforcedStyleForMultiline: consistent_comma | ||
|
||
|
@@ -29,6 +33,11 @@ Style/TrailingCommaInArrayLiteral: | |
Style/FrozenStringLiteralComment: | ||
Enabled: false | ||
|
||
# Unicode is pretty standard by now, and we want to be able to use em-dash, ellipsis, and unicode characters | ||
# to provide nice Monodraw.app graphs and similar, without being limited only by ascii. | ||
Style/AsciiComments: | ||
Enabled: false | ||
Comment on lines
+38
to
+39
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I'm happy with this but I'm curious about the rationale? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Generally, I'd like to have a rationale for every disabled rule or any other variation from the default. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. My rationale is:
I'll add a comment to explain that rationale in the config file anyway indeed. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Rationale added as comment in 70fb5d5 There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🤣 👍 |
||
|
||
########## Metrics / Max Lengths Rules | ||
|
||
Metrics/LineLength: | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Totally out of topic and not really a Ruby friendly thing, but I do love how Elm does trailing commas