-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Diff between wp-fork branch and main repo's default branch #3
base: trunk-2.9.1
Are you sure you want to change the base?
Commits on May 22, 2020
-
Configuration menu - View commit details
-
Copy full SHA for 7e621e9 - Browse repository at this point
Copy the full SHA 7e621e9View commit details
Commits on Jul 16, 2020
-
Configuration menu - View commit details
-
Copy full SHA for 0d88e03 - Browse repository at this point
Copy the full SHA 0d88e03View commit details
Commits on Jul 17, 2020
-
Configuration menu - View commit details
-
Copy full SHA for ed48f51 - Browse repository at this point
Copy the full SHA ed48f51View commit details
Commits on Jun 9, 2021
-
Configuration menu - View commit details
-
Copy full SHA for fff585a - Browse repository at this point
Copy the full SHA fff585aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 047ae60 - Browse repository at this point
Copy the full SHA 047ae60View commit details
Commits on Jun 22, 2021
-
Configuration menu - View commit details
-
Copy full SHA for 2811e99 - Browse repository at this point
Copy the full SHA 2811e99View commit details -
Configuration menu - View commit details
-
Copy full SHA for 54ec21e - Browse repository at this point
Copy the full SHA 54ec21eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 1e482d8 - Browse repository at this point
Copy the full SHA 1e482d8View commit details
Commits on Aug 11, 2021
-
Configuration menu - View commit details
-
Copy full SHA for e1072f2 - Browse repository at this point
Copy the full SHA e1072f2View commit details -
Configuration menu - View commit details
-
Copy full SHA for 743da1b - Browse repository at this point
Copy the full SHA 743da1bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 2af50a6 - Browse repository at this point
Copy the full SHA 2af50a6View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5a827f5 - Browse repository at this point
Copy the full SHA 5a827f5View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2b720c4 - Browse repository at this point
Copy the full SHA 2b720c4View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4006af9 - Browse repository at this point
Copy the full SHA 4006af9View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5cfc32c - Browse repository at this point
Copy the full SHA 5cfc32cView commit details
Commits on Aug 16, 2021
-
Merge pull request #4 from wordpress-mobile/upgrade-to-gradle-7.1.1
Upgrade to gradle 7.1.1
Configuration menu - View commit details
-
Copy full SHA for 4f4aa06 - Browse repository at this point
Copy the full SHA 4f4aa06View commit details
Commits on Sep 3, 2021
-
Configuration menu - View commit details
-
Copy full SHA for 43df945 - Browse repository at this point
Copy the full SHA 43df945View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1334c80 - Browse repository at this point
Copy the full SHA 1334c80View commit details -
Configuration menu - View commit details
-
Copy full SHA for c3bf525 - Browse repository at this point
Copy the full SHA c3bf525View commit details -
Configuration menu - View commit details
-
Copy full SHA for 206c77c - Browse repository at this point
Copy the full SHA 206c77cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 4f4e01e - Browse repository at this point
Copy the full SHA 4f4e01eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 023b341 - Browse repository at this point
Copy the full SHA 023b341View commit details -
Configuration menu - View commit details
-
Copy full SHA for a34868d - Browse repository at this point
Copy the full SHA a34868dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 866b76f - Browse repository at this point
Copy the full SHA 866b76fView commit details
Commits on Sep 8, 2021
-
Configuration menu - View commit details
-
Copy full SHA for 1848b3b - Browse repository at this point
Copy the full SHA 1848b3bView commit details
Commits on Sep 9, 2021
-
Configuration menu - View commit details
-
Copy full SHA for 520f624 - Browse repository at this point
Copy the full SHA 520f624View commit details -
Configuration menu - View commit details
-
Copy full SHA for ccb8ab6 - Browse repository at this point
Copy the full SHA ccb8ab6View commit details -
Configuration menu - View commit details
-
Copy full SHA for ed2c575 - Browse repository at this point
Copy the full SHA ed2c575View commit details
Commits on Sep 14, 2021
-
Configuration menu - View commit details
-
Copy full SHA for 560064d - Browse repository at this point
Copy the full SHA 560064dView commit details -
Configuration menu - View commit details
-
Copy full SHA for c8d0a99 - Browse repository at this point
Copy the full SHA c8d0a99View commit details -
Configuration menu - View commit details
-
Copy full SHA for 363d56e - Browse repository at this point
Copy the full SHA 363d56eView commit details -
Configuration menu - View commit details
-
Copy full SHA for aa6f837 - Browse repository at this point
Copy the full SHA aa6f837View commit details
Commits on Sep 16, 2021
-
Configuration menu - View commit details
-
Copy full SHA for 12101be - Browse repository at this point
Copy the full SHA 12101beView commit details -
Configuration menu - View commit details
-
Copy full SHA for 9707403 - Browse repository at this point
Copy the full SHA 9707403View commit details
Commits on Sep 24, 2021
-
Configuration menu - View commit details
-
Copy full SHA for 1e8662d - Browse repository at this point
Copy the full SHA 1e8662dView commit details
Commits on Oct 13, 2021
-
Configuration menu - View commit details
-
Copy full SHA for 8a947ce - Browse repository at this point
Copy the full SHA 8a947ceView commit details
Commits on Oct 29, 2021
-
Configuration menu - View commit details
-
Copy full SHA for d4026e9 - Browse repository at this point
Copy the full SHA d4026e9View commit details -
Configuration menu - View commit details
-
Copy full SHA for 902aba8 - Browse repository at this point
Copy the full SHA 902aba8View commit details
Commits on Nov 22, 2021
-
Configuration menu - View commit details
-
Copy full SHA for d9db520 - Browse repository at this point
Copy the full SHA d9db520View commit details
Commits on Nov 23, 2021
-
Configuration menu - View commit details
-
Copy full SHA for 90fe108 - Browse repository at this point
Copy the full SHA 90fe108View commit details -
Configuration menu - View commit details
-
Copy full SHA for 22b84a2 - Browse repository at this point
Copy the full SHA 22b84a2View commit details
Commits on Nov 30, 2021
-
Merge pull request #6 from wordpress-mobile/chore/upgrade-to-react-na…
…tive-0.66 Update to RN 0.66.2
Configuration menu - View commit details
-
Copy full SHA for e8ac7f2 - Browse repository at this point
Copy the full SHA e8ac7f2View commit details
Commits on Dec 3, 2021
-
Configuration menu - View commit details
-
Copy full SHA for c6458c7 - Browse repository at this point
Copy the full SHA c6458c7View commit details -
Merge pull request #7 from wordpress-mobile/update/ci-branch
Update CI branch from master to trunk
Configuration menu - View commit details
-
Copy full SHA for c3fee6b - Browse repository at this point
Copy the full SHA c3fee6bView commit details
Commits on Feb 25, 2022
-
Merge branch 'upstream-2.2.4' into wp-fork-2.2.4
# Conflicts: # android/build.gradle # package.json
Configuration menu - View commit details
-
Copy full SHA for 64bb89f - Browse repository at this point
Copy the full SHA 64bb89fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 11233e4 - Browse repository at this point
Copy the full SHA 11233e4View commit details -
Configuration menu - View commit details
-
Copy full SHA for bd880dd - Browse repository at this point
Copy the full SHA bd880ddView commit details -
Configuration menu - View commit details
-
Copy full SHA for 2a8fca6 - Browse repository at this point
Copy the full SHA 2a8fca6View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2c998a4 - Browse repository at this point
Copy the full SHA 2c998a4View commit details -
Configuration menu - View commit details
-
Copy full SHA for b675a7e - Browse repository at this point
Copy the full SHA b675a7eView commit details -
Configuration menu - View commit details
-
Copy full SHA for a72b2d6 - Browse repository at this point
Copy the full SHA a72b2d6View commit details -
Configuration menu - View commit details
-
Copy full SHA for 984cc98 - Browse repository at this point
Copy the full SHA 984cc98View commit details -
Simplify android-npm build configuration
The original configuration tries to fetch the RN version of the app and find a matching AAR. In our case, since we control the RN version, we can simplify the configuration by providing a single and specific RN version.
Configuration menu - View commit details
-
Copy full SHA for 49114ff - Browse repository at this point
Copy the full SHA 49114ffView commit details -
Configuration menu - View commit details
-
Copy full SHA for 039e3c8 - Browse repository at this point
Copy the full SHA 039e3c8View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5326984 - Browse repository at this point
Copy the full SHA 5326984View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0e90c7a - Browse repository at this point
Copy the full SHA 0e90c7aView commit details
Commits on Feb 28, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 6f4e0a4 - Browse repository at this point
Copy the full SHA 6f4e0a4View commit details -
Merge pull request #10 from wordpress-mobile/upstream-2.2.4
Update `trunk` with upstream version `2.2.4`
Configuration menu - View commit details
-
Copy full SHA for 06051c0 - Browse repository at this point
Copy the full SHA 06051c0View commit details -
Merge pull request #11 from wordpress-mobile/wp-fork-2.2.4
Update wp-fork to version `2.2.4`
Configuration menu - View commit details
-
Copy full SHA for 2c4242f - Browse repository at this point
Copy the full SHA 2c4242fView commit details -
Configuration menu - View commit details
-
Copy full SHA for f1cd9fd - Browse repository at this point
Copy the full SHA f1cd9fdView commit details
Commits on Mar 10, 2022
-
Merge branch 'upstream-2.4.1' into update-version-2.4.1
# Conflicts: # .github/workflows/main.yml # Common/cpp/Tools/JSIStoreValueUser.cpp # Common/cpp/headers/Tools/JSIStoreValueUser.h # Example/android/app/src/main/java/com/swmansion/reanimated/example/MainApplication.java # Example/android/build.gradle # Example/android/gradle.properties # Example/android/gradle/wrapper/gradle-wrapper.properties # Example/android/settings.gradle # Example/ios/Podfile.lock # Example/package.json # Example/yarn.lock # RNReanimated.podspec # android-npm/build.gradle # android/build.gradle # android/gradle/wrapper/gradle-wrapper.jar # android/gradle/wrapper/gradle-wrapper.properties # android/gradlew # android/gradlew.bat # createNPMPackage.sh # ios/native/NativeProxy.mm # ios/native/REAInitializer.h # ios/native/REAInitializer.mm # ios/native/UIResponder+Reanimated.mm # package.json # src/reanimated2/js-reanimated/index.web.ts # yarn.lock
Configuration menu - View commit details
-
Copy full SHA for d8af169 - Browse repository at this point
Copy the full SHA d8af169View commit details -
Configuration menu - View commit details
-
Copy full SHA for e3cffea - Browse repository at this point
Copy the full SHA e3cffeaView commit details -
Add reactInstanceManager getter (software-mansion#2863)
## Description This PR adds a getter for `ReactInstanceManager`. The motivation for this PR is to fix issues software-mansion#2719 and software-mansion#2801 Those Android apps whose application class does not implement `ReactApplication` or simply have a different mechanism for storing a `ReactInstanceManager`, currently they have an incompatibility with `react-native-reanimated` ending in a crash when launching the app, as the issues indicates. Normally, those apps are where [React Native is integrated with existing Android apps](https://reactnative.dev/docs/integration-with-existing-apps) So, introducing this getter allows us to override this getter and implement a custom way to return the `ReactInstanceManager` to be used by `react-native-reanimated`. <!-- Description and motivation for this PR. Inlude Fixes #<number> if this is fixing some issue. Fixes # . --> ## Changes - Added `getReactInstanceManager` method for android. <!-- Please describe things you've changed here, make a **high level** overview, if change is simple you can omit this section. For example: - Added `foo` method which add bouncing animation - Updated `about.md` docs - Added caching in CI builds --> <!-- ## Screenshots / GIFs Here you can add screenshots / GIFs documenting your change. You can add before / after section if you're changing some behavior. ### Before ### After --> ## Test code and steps to reproduce This is an example of how to use and override this getter. It is necessary to manually link `react-native-reanimated` before to be able to do it. ```java public class MainActivity extends Activity implements DefaultHardwareBackBtnHandler { private static ReactInstanceManager mReactInstanceManager; ... @OverRide protected void onCreate(Bundle savedInstanceState) { ... List<ReactPackage> packages = new PackageList(getApplication()).getPackages(); // Adding manually Reanimated package here, with overriding getReactInstanceManager method packages.add(new ReanimatedPackage() { @OverRide public ReactInstanceManager getReactInstanceManager(ReactApplicationContext reactContext) { // Implement here your way to get the ReactInstanceManager return MainActivity.getReactInstanceManager(); } }); mReactInstanceManager = ReactInstanceManager.builder() .setApplication(getApplication()) .setCurrentActivity(this) .setBundleAssetName("index.android.bundle") .setJSMainModulePath("index") .setJSIModulesPackage(new ReanimatedJSIModulePackage()) // Adding ReanimatedJSIModulePackage here .addPackages(packages) .setUseDeveloperSupport(BuildConfig.DEBUG) .setInitialLifecycleState(LifecycleState.RESUMED) .build(); ... } ... } ``` <!-- Please include code that can be used to test this change and short description how this example should work. This snippet should be as minimal as possible and ready to be pasted into editor (don't exclude exports or remove "not important" parts of reproduction example) --> ## Checklist - [x] Included code example that can be used to test this change - [ ] Updated TS types - [ ] Added TS types tests - [ ] Added unit / integration tests - [ ] Updated documentation - [ ] Ensured that CI passes
Configuration menu - View commit details
-
Copy full SHA for c9eaeb6 - Browse repository at this point
Copy the full SHA c9eaeb6View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3038a45 - Browse repository at this point
Copy the full SHA 3038a45View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5d6e245 - Browse repository at this point
Copy the full SHA 5d6e245View commit details -
Configuration menu - View commit details
-
Copy full SHA for d12d210 - Browse repository at this point
Copy the full SHA d12d210View commit details
Commits on Mar 15, 2022
-
Merge pull request #13 from wordpress-mobile/update-version-2.4.1
Update `wp-fork` to version `2.4.1`
Configuration menu - View commit details
-
Copy full SHA for bc9354d - Browse repository at this point
Copy the full SHA bc9354dView commit details -
Merge branch 'trunk' into upstream-2.4.1
# Conflicts: # .github/workflows/main.yml # Common/cpp/Tools/JSIStoreValueUser.cpp # Common/cpp/headers/Tools/JSIStoreValueUser.h # Example/android/app/src/main/java/com/swmansion/reanimated/example/MainApplication.java # Example/android/build.gradle # Example/android/gradle.properties # Example/android/gradle/wrapper/gradle-wrapper.properties # Example/android/settings.gradle # Example/ios/Podfile.lock # Example/package.json # Example/yarn.lock # RNReanimated.podspec # android-npm/build.gradle # android/build.gradle # createNPMPackage.sh # ios/native/NativeProxy.mm # ios/native/REAInitializer.h # ios/native/REAInitializer.mm # ios/native/UIResponder+Reanimated.mm # package.json # src/reanimated2/js-reanimated/index.web.ts # yarn.lock
Configuration menu - View commit details
-
Copy full SHA for 2f34f2b - Browse repository at this point
Copy the full SHA 2f34f2bView commit details -
Merge pull request #12 from wordpress-mobile/upstream-2.4.1
Update `trunk` with upstream version `2.4.1`
Configuration menu - View commit details
-
Copy full SHA for 56b511a - Browse repository at this point
Copy the full SHA 56b511aView commit details -
Merge branch 'trunk' into wp-fork
# Conflicts: # RNReanimated.podspec # android-npm/build.gradle # android/build.gradle # createNPMPackage.sh # package.json # yarn.lock
Configuration menu - View commit details
-
Copy full SHA for f575b73 - Browse repository at this point
Copy the full SHA f575b73View commit details
Commits on May 3, 2022
-
fix: android layout reanimation null pointer exception (2959) (softwa…
…re-mansion#3162) ## Description ReactApplicationContext.getCurentContext sometimes return null. This causes a crash (NullPointerException) in reanimated due to not checking if context exists. As per react native's examples, we can only measure device metrics when current activity is not null (https://github.com/facebook/react-native/blob/8bd3edec88148d0ab1f225d2119435681fbbba33/ReactCommon/react/nativemodule/samples/platform/android/SampleTurboModule.java#L56) Fixes software-mansion#2959. ## Changes Check if current activity is not null before measuring the device.
Configuration menu - View commit details
-
Copy full SHA for 6f900e0 - Browse repository at this point
Copy the full SHA 6f900e0View commit details -
Configuration menu - View commit details
-
Copy full SHA for 22ef6a0 - Browse repository at this point
Copy the full SHA 22ef6a0View commit details
Commits on May 4, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 998fbb6 - Browse repository at this point
Copy the full SHA 998fbb6View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9e63336 - Browse repository at this point
Copy the full SHA 9e63336View commit details -
Merge pull request #15 from wordpress-mobile/fix-android-layout-reani…
…mation-crash Fix crash related to Android layout reanimation due to `NullPointerException`
Configuration menu - View commit details
-
Copy full SHA for e83e1f2 - Browse repository at this point
Copy the full SHA e83e1f2View commit details
Commits on Jun 1, 2022
-
Invalidate display link instead of pausing it when invalidating the n…
…odes manager Pausing the display link on invalidation will still make it call the onAnimationFrame selector one more time as its already schedule. When this happens animation blocks will be called and crash while accessing the jsi runtime thats already dealloced.
Gerardo committedJun 1, 2022 Configuration menu - View commit details
-
Copy full SHA for ba1cf8e - Browse repository at this point
Copy the full SHA ba1cf8eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 4f771ab - Browse repository at this point
Copy the full SHA 4f771abView commit details -
Configuration menu - View commit details
-
Copy full SHA for f3a68eb - Browse repository at this point
Copy the full SHA f3a68ebView commit details -
Merge pull request #16 from wordpress-mobile/fix/invalidation-display…
…-link Invalidate display link instead of pausing it when invalidating the nodes manager
Configuration menu - View commit details
-
Copy full SHA for 0f902a0 - Browse repository at this point
Copy the full SHA 0f902a0View commit details
Commits on Aug 11, 2022
-
Merge branch 'upstream-2.9.1' into wp-fork-2.9.1
# Conflicts: # RNReanimated.podspec # android-npm/build.gradle # android/build.gradle # android/gradle.properties # createNPMPackage.sh # package.json # yarn.lock
Gerardo committedAug 11, 2022 Configuration menu - View commit details
-
Copy full SHA for f192704 - Browse repository at this point
Copy the full SHA f192704View commit details -
Add React Native Reanimated 0.69 hermes binary
Gerardo committedAug 11, 2022 Configuration menu - View commit details
-
Copy full SHA for 1eebd5b - Browse repository at this point
Copy the full SHA 1eebd5bView commit details -
Gerardo committed
Aug 11, 2022 Configuration menu - View commit details
-
Copy full SHA for c9175c8 - Browse repository at this point
Copy the full SHA c9175c8View commit details
Commits on Aug 24, 2022
-
Gerardo committed
Aug 24, 2022 Configuration menu - View commit details
-
Copy full SHA for 8e4b343 - Browse repository at this point
Copy the full SHA 8e4b343View commit details
Commits on Oct 4, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 97a359d - Browse repository at this point
Copy the full SHA 97a359dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 7b1512b - Browse repository at this point
Copy the full SHA 7b1512bView commit details
Commits on Oct 10, 2022
-
Remove previous version tarball
Gerardo committedOct 10, 2022 Configuration menu - View commit details
-
Copy full SHA for 2193fe1 - Browse repository at this point
Copy the full SHA 2193fe1View commit details
Commits on Oct 11, 2022
-
Merge pull request #18 from wordpress-mobile/wp-fork-2.9.1
Update wp-fork to version `2.9.1`
Gerardo Pacheco authoredOct 11, 2022 Configuration menu - View commit details
-
Copy full SHA for edab86e - Browse repository at this point
Copy the full SHA edab86eView commit details -
Merge pull request #17 from wordpress-mobile/upstream-2.9.1
Update `trunk` with upstream version `2.9.1`
Gerardo Pacheco authoredOct 11, 2022 Configuration menu - View commit details
-
Copy full SHA for c1e7a1b - Browse repository at this point
Copy the full SHA c1e7a1bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 353392d - Browse repository at this point
Copy the full SHA 353392dView commit details -
Gerardo committed
Oct 11, 2022 Configuration menu - View commit details
-
Copy full SHA for 8f6aa5a - Browse repository at this point
Copy the full SHA 8f6aa5aView commit details -
Merge pull request #20 from wordpress-mobile/wp-fork-2.9.1-update-tar…
…ball Update tarball for `2.9.1`
Gerardo Pacheco authoredOct 11, 2022 Configuration menu - View commit details
-
Copy full SHA for 7cc8603 - Browse repository at this point
Copy the full SHA 7cc8603View commit details
Commits on Oct 13, 2022
-
Merge pull request #19 from wordpress-mobile/update/android-12
Upgrade compile and target sdk version to Android API 31
Configuration menu - View commit details
-
Copy full SHA for 4810d26 - Browse repository at this point
Copy the full SHA 4810d26View commit details
Commits on Oct 17, 2022
-
Merge branch 'wp-fork' into update-android-12-wp-fork
# Conflicts: # android-npm/expo/linking.gradle # android/build.gradle # package.json # react-native-reanimated-2.4.1-wp-4.tgz
Configuration menu - View commit details
-
Copy full SHA for 3c1f3fc - Browse repository at this point
Copy the full SHA 3c1f3fcView commit details
Commits on Oct 18, 2022
-
Updates createNPMPackage.sh to fix an issue after merge, it removes u…
…nneeded code comparing the changes from the original repo's file in 2.9.1.
Gerardo committedOct 18, 2022 Configuration menu - View commit details
-
Copy full SHA for ca442f7 - Browse repository at this point
Copy the full SHA ca442f7View commit details -
Merge pull request #22 from wordpress-mobile/fix/create-npm-package
Updates createNPMPackage.sh to fix an issue after merge
Configuration menu - View commit details
-
Copy full SHA for 98d9719 - Browse repository at this point
Copy the full SHA 98d9719View commit details -
Configuration menu - View commit details
-
Copy full SHA for 13348e1 - Browse repository at this point
Copy the full SHA 13348e1View commit details -
Configuration menu - View commit details
-
Copy full SHA for dfc2668 - Browse repository at this point
Copy the full SHA dfc2668View commit details -
Merge pull request #21 from wordpress-mobile/update-android-12-wp-fork
Upgrade compile and target sdk version to Android API 31 (version 2.9.1)
Configuration menu - View commit details
-
Copy full SHA for 2a8952c - Browse repository at this point
Copy the full SHA 2a8952cView commit details
Commits on Jan 25, 2023
-
Fix Jest 28+
expect.extend is not a function
error (software-mansio……n#3559) Reanimated is not fully compatible with Jest 28+ even after the PR software-mansion#3347. Using it with Jest 28+ leads to this error: <img width="796" alt="Ekran Resmi 2022-09-10 15 00 33" src="https://user-images.githubusercontent.com/22980987/189482337-cc2655f6-9463-4a05-9998-5fc3592f5cc0.png"> The reason is, the "expect" module's export approach has changed starting from Jest 28. It used to export the `expect` function directly, as can be seen [here](https://github.com/facebook/jest/blob/v27.5.1/packages/expect/src/index.ts#L441). This means, requiring the "expect" module like this ```ts const expect = require('expect') ``` was providing direct access to the `expect` function alongside with its attached methods, like `extend`. This has [changed with Jest 28](https://github.com/facebook/jest/blob/v28.0.0/packages/expect/src/index.ts#L449). `export default expect` is the new export statement, which means requiring the "expect" package returns the module object, instead of the function. software-mansion#3347 PR attempts to fix this error by assuming "expect" package should throw an error with Jest 28 and it can catch that and require the "expect" from the `@jest/globals` package for Jest 28+ project but it's not the case in reality. "expect" package is still shipped with Jest 28, so, requiring it doesn't throw an error as expected in the PR. By knowing the export difference, I checked if the value of the module is object or not after requiring it. If it's an object, it means user is on Jest 28+ codebase. The rest is the same with the previous PR. I require the "expect" function from `@jest/globals` and use it. Tested on Jest 29 and Jest 27.5.1 Fixes software-mansion#3553 and software-mansion#3215.
Configuration menu - View commit details
-
Copy full SHA for d0009ba - Browse repository at this point
Copy the full SHA d0009baView commit details -
Gerardo committed
Jan 25, 2023 Configuration menu - View commit details
-
Copy full SHA for 455061b - Browse repository at this point
Copy the full SHA 455061bView commit details
Commits on Jan 30, 2023
-
Merge pull request #23 from wordpress-mobile/wp-fork-add-jest-28-support
Add support for Jest 28+
Gerardo Pacheco authoredJan 30, 2023 Configuration menu - View commit details
-
Copy full SHA for d1e7674 - Browse repository at this point
Copy the full SHA d1e7674View commit details
Commits on May 18, 2023
-
Configuration menu - View commit details
-
Copy full SHA for f72ca56 - Browse repository at this point
Copy the full SHA f72ca56View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6984fe2 - Browse repository at this point
Copy the full SHA 6984fe2View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7c6ac39 - Browse repository at this point
Copy the full SHA 7c6ac39View commit details
Commits on May 22, 2023
-
Merge pull request #24 from wordpress-mobile/update/android-13
Upgrade compile and target sdk version to Android API 33
Configuration menu - View commit details
-
Copy full SHA for e328656 - Browse repository at this point
Copy the full SHA e328656View commit details