Diff between wp-fork branch and main repo's default branch #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Upgrade to gradle 7.1.1
Update wp-fork to version `2.9.1`
Update `trunk` with upstream version `2.9.1`
…ball Update tarball for `2.9.1`
Upgrade compile and target sdk version to Android API 31
# Conflicts: # android-npm/expo/linking.gradle # android/build.gradle # package.json # react-native-reanimated-2.4.1-wp-4.tgz
…nneeded code comparing the changes from the original repo's file in 2.9.1.
Updates createNPMPackage.sh to fix an issue after merge
Upgrade compile and target sdk version to Android API 31 (version 2.9.1)
…n#3559) Reanimated is not fully compatible with Jest 28+ even after the PR software-mansion#3347. Using it with Jest 28+ leads to this error: <img width="796" alt="Ekran Resmi 2022-09-10 15 00 33" src="https://user-images.githubusercontent.com/22980987/189482337-cc2655f6-9463-4a05-9998-5fc3592f5cc0.png"> The reason is, the "expect" module's export approach has changed starting from Jest 28. It used to export the `expect` function directly, as can be seen [here](https://github.com/facebook/jest/blob/v27.5.1/packages/expect/src/index.ts#L441). This means, requiring the "expect" module like this ```ts const expect = require('expect') ``` was providing direct access to the `expect` function alongside with its attached methods, like `extend`. This has [changed with Jest 28](https://github.com/facebook/jest/blob/v28.0.0/packages/expect/src/index.ts#L449). `export default expect` is the new export statement, which means requiring the "expect" package returns the module object, instead of the function. software-mansion#3347 PR attempts to fix this error by assuming "expect" package should throw an error with Jest 28 and it can catch that and require the "expect" from the `@jest/globals` package for Jest 28+ project but it's not the case in reality. "expect" package is still shipped with Jest 28, so, requiring it doesn't throw an error as expected in the PR. By knowing the export difference, I checked if the value of the module is object or not after requiring it. If it's an object, it means user is on Jest 28+ codebase. The rest is the same with the previous PR. I require the "expect" function from `@jest/globals` and use it. Tested on Jest 29 and Jest 27.5.1 Fixes software-mansion#3553 and software-mansion#3215.
Add support for Jest 28+
Upgrade compile and target sdk version to Android API 33
fluiddot
force-pushed
the
trunk
branch
2 times, most recently
from
c1e7a1b
to
70fea4d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bump React Native version (updated by @fluiddot )
Check the following instructions for updating the RN version: #3 (comment)
Tweaks applied to the fork
trunkbranch instead ofmain.sourceto point to the forked repository.android-npmbuild.gradlefile to publish the Android binaries.android/build.gradleandroid/gradle.propertiesandroid/settings.gradlecreateNPMPackagescript