Avoid casting to NSError in favor of WordPressApiError
#779
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See discussion at #777 (comment) with @crazytonyli
2 tasks
crazytonyli
requested changes
Apr 5, 2024
| let jetpackError = JetpackInstallError( | ||
| title: endpointError.localizedDescription, | ||
| code: endpointError.errorCode, | ||
| key: endpointError.errorUserInfo[WordPressComRestApi.ErrorKeyErrorCode] as? String |
There was a problem hiding this comment.
I believe you can do endpointError.apiErrorCode instead of using errorUserInfo.
| return | ||
| } | ||
|
|
||
| let status = RewindStatus(state: .unavailable) | ||
| success(status) | ||
| failure(endpointError) |
There was a problem hiding this comment.
The original code returns error. But there it's changed to endpointError. I don't think we should change it here?
crazytonyli
reviewed
Apr 17, 2024
| // FIXME: A hack to support free WPCom sites and Rewind. | ||
| // Should be obsolete as soon as the backend stops returning 412's for those sites. | ||
| guard error.castedToEndpointErrorWitCode(.preconditionFailure) != nil else { | ||
| success(RewindStatus(state: .unavailable)) | ||
| return | ||
| } |
There was a problem hiding this comment.
My brain can't process these two guard statements. But, are their logic changed?
There was a problem hiding this comment.
I noticed an unit test failed, I think this guard change here might be the cause?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See discussion at
#777 (comment) with @crazytonyli
Testing Details
See green CI.
CHANGELOG.mdif necessary. — N.A.