SPM Prep - Use WordPressComRESTAPIInterfacing for all sync GET and POST requests in the Swift code
#777
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mokagio
changed the title
WordPressComRESTAPIInterfacing for all sync GET and POST requests in the Swift codeWordPressComRESTAPIInterfacing for all sync GET and POST requests in the Swift code
2 tasks
crazytonyli
approved these changes
Apr 4, 2024
| if error.domain == WordPressComRestApiEndpointError.errorDomain, error.code == WordPressComRestApiErrorCode.preconditionFailure.rawValue { | ||
| let status = RewindStatus(state: .unavailable) | ||
| success(status) | ||
| let nsError = error as NSError |
There was a problem hiding this comment.
Not a blocker, but IMO it's better to avoid casting to NSError here by using pattern matching.
if let apiError = error as? WordPressAPIError<WordPressRestApiEndpointError>,
case let .endpointError(endpointError) = apiError,
endpointError.code == .preconditionFailure {
// ....
}There was a problem hiding this comment.
Oh, right.
I guess you are suggesting to used the better typed error to ensure what we are handling is a legit API error. If the casting fails, we are in a edge case and should act differently.
Under that assumption, I opened #779 to address. Thanks!
| if let response = response as? [String: Bool], | ||
| let success = response[Constants.status] { | ||
| completion(success, nil) | ||
| } else { | ||
| completion(false, JetpackInstallError(type: .installResponseError)) | ||
| } | ||
| }) { (error: NSError, _: HTTPURLResponse?) in | ||
| }) { error, _ in | ||
| let error = error as NSError |
mokagio
added a commit
that referenced
this pull request
Apr 5, 2024
See discussion at #777 (comment) with @crazytonyli
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Follows up on #766 applying the same pattern to all the
.GETand.POSTusages.I changed each file/group of files with extensions in dedicated commits, in case one wants to review in chunks.
Testing Details
Not all code is covered by unit tests, unfortunately. But, these changes are really about swapping interfaces without changing the implementation. They should be safe—last famous words.
CHANGELOG.mdif necessary. — N.A.