Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use a path, not URL, in fetch posts from endpoint request #727

Open
wants to merge 1 commit into
base: trunk
Choose a base branch
from
Open

Use a path, not URL, in fetch posts from endpoint request #727

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion WordPressKit/ReaderPostServiceRemote.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -200,7 +200,7 @@ - (void)fetchPostsFromEndpoint:(NSURL *)endpoint
success:(void (^)(NSArray<RemoteReaderPost *> *posts, NSString *algorithm))success
failure:(void (^)(NSError *))failure
{
NSString *path = [endpoint absoluteString];
NSString *path = [endpoint path];
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder how many of these migration issues are left in the library, and what it would take to discover them on our side before they reach the users... 🤔

I suppose one way would be to audit each GET... call. There are "only" 118 of them...

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't looked where the app gets endpoint. If they are constructed by the app, I'm thinking maybe we can dumb down this fetchPostsFromEndpoint function to not accepting a URL argument?

[self.wordPressComRestApi GET:path
parameters:params
success:^(id responseObject, NSHTTPURLResponse *httpResponse) {
Expand Down