Use a path, not URL, in fetch posts from endpoint request #727
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The recent work on the WordPress.com API requires GET, POST, etc methods to be called using a path, but this method passed a whole URL.
mokagio
added a commit
to wordpress-mobile/WordPress-iOS
that referenced
this pull request
Feb 19, 2024
See how the UI tests failed in https://buildkite.com/automattic/wordpress-ios/builds/20452#018dbe88-2fc5-4998-ad35-1b455f547b59 The WordPressKit PR is wordpress-mobile/WordPressKit-iOS#727
mokagio
added a commit
to wordpress-mobile/WordPress-iOS
that referenced
this pull request
Feb 19, 2024
See how the UI tests failed in https://buildkite.com/automattic/wordpress-ios/builds/20452#018dbe88-2fc5-4998-ad35-1b455f547b59 The WordPressKit PR is wordpress-mobile/WordPressKit-iOS#727
mokagio
commented
Feb 19, 2024
| @@ -200,7 +200,7 @@ - (void)fetchPostsFromEndpoint:(NSURL *)endpoint | |||
| success:(void (^)(NSArray<RemoteReaderPost *> *posts, NSString *algorithm))success | |||
| failure:(void (^)(NSError *))failure | |||
| { | |||
| NSString *path = [endpoint absoluteString]; | |||
| NSString *path = [endpoint path]; | |||
There was a problem hiding this comment.
I wonder how many of these migration issues are left in the library, and what it would take to discover them on our side before they reach the users... 🤔
I suppose one way would be to audit each GET... call. There are "only" 118 of them...
There was a problem hiding this comment.
I haven't looked where the app gets endpoint. If they are constructed by the app, I'm thinking maybe we can dumb down this fetchPostsFromEndpoint function to not accepting a URL argument?
4 tasks
2 tasks
I have added one in #729. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The recent work on the WordPress.com API requires GET, POST, etc methods to be called using a path, but this method passed a whole URL.
Testing Details
The change didn't affect unit tests because there are no tests for this method 😢
See how wordpress-mobile/WordPress-iOS#22622 passes in CI:
I left a note about the Gutenberg Gallery block failure here: wordpress-mobile/WordPress-iOS#22612 (comment)
CHANGELOG.mdif necessary.