WIP (Do Not Merge!!): Belos Small Dense Matrix Abstraction #11837

…actory classes.

…Dense adapter and test. It compiles and runs

…ses basic tests.

…s dense. Made local randomSyncedMatrix function in the MVOP tester.

tests with both the dense Traits and the MV Traits! Notes: Also added const and non-const getRawPointer functions. Had to split the Tpetra MV traits into separate parts to maintain Teuchos functionality for backward compatibility.

…ame.

…assing on CPUgit status

…vel. Code builds and runs on CPU.

…Epetra (needs moved later), and fix sync needed after PutScalar is called to pass DenseMatTester on GPU.

… sync needed.

…ts. Commiting for reproducer.

…or debugging.

1. Fixes up dense matrix traits testing The dense matrix traits testing for Teuchos is being moved to the belos/test directory since it is not specific to Epetra. This test employs the dense matrix tester and also includes some tests inspired by the Teuchos::SerialDenseMatrix tester. The dense matrix tester has been cleaned up a little to eliminate compiler warnings and default arguments for the dense matrix object have been removed from both the dense matrix tester and matrix-vector-operator tester, which requires the modification of the tests that use these testers. 2. The Teuchos::SerialDenseVector is not used by any of these iteration classes, so it is being removed to reduce confusion on whether it is used. 3. The call to get strides from the Kokkos::DualView object expects an integer array of length 8. Since a raw pointer to that array is passed in, bounds checking is not performed, and filling in all the strides will result in a seg fault for any integer array of less than 8. This was causing a seg fault in the Kokkos dense matrix adapter even on CPUs. 4. There was a compiler warning about the creation and destruction of the svals array not matching in the Belos::TpetraTestFramework. 5. To avoid confusion and extra work later, the Teuchos implementation of the dense matrix traits has been removed from being included in the abstract dense matrix traits class. To address this change, the Teuchos adapter has been added to several classes that require it due to the default template parameter for dense matrices. Additional changes to remove the use of Teuchos::SerialDenseVector objects in exchange for std::vector objects have been made. This is mostly for the storage of Given's rotations within GMRES-type solvers.

This cleans up the integration of dense matrix traits to have some commonality with other solvers that have been modified. This includes removing the default template for the dense matrix to Teuchos::SerialDenseMatrix for the iteration and status test. Only the solver manager has the default template argument so that the solver interface to the user appears unchanged.

The BiCGStab and TFQMR solver now uses the dense matrix template, where the default is Teuchos::SerialDenseMatrix for the solver manager. The iteration classes now recognize the fourth dense matrix template argument, but do not have a default argument. A test for these two solvers has been added that uses Kokkos::DualView.

…u030.

The PCPG solver required a new method to be added to the traits that provides a conjugate-transposed copy of a dense matrix. Then the solver could use dense matrix traits. Additional tests and examples have been added to the repository for PCPG using Kokkos::DualView objects.

…trix traits All the standard Belos orthogonalization managers have been converted to using dense matrix traits. Furthermore, the orthogonalization factories and testers have also been converted to using these traits. This has enabled a more thorough testing of the orthogonalization implementations for Kokkos::DualView objects. New tests have been added that pass for all three major implementations: ICGS, IMGS, and DGKS. Also, with this chagne, the block GMRES solver test is now passing that uses Kokkos::DualView objects. Further cleanup is necessary, but this is a solid checkpoint on this work.

To avoid direct interrogation of values which may result in unnecessary synchronizations, the use of Subview and PutScalar methods are used.

…ment The TSQR orthogonalization class is a experimental capability in Belos. The infrastructure that connects the TSQR implementation in Tpetra to the Belos orthogonalization classes has been updated to use the new dense matrix traits mechanism. WARNING: This code will not compile with TSQR enabled because the TSQR implementation in Tpetra is based on Teuchos::SerialDenseMatrix object. This code will need to be extended to take different dense matrix objects, like Kokkos::DualView.

No dense matrix objects are used in the solver, so the effect of this change is negligible.

Also transitions pseudo block GMRES to use dense matrix traits

The single-vector CG, pseudo-block CG and stochastic CG can now use the dense matrix traits. Tests have been added that use the Kokkos dense adapter to execute these solvers.

The block CG solver requires a factorization and solve of the block projected system. This was done through the direct linear solver interfaces in Teuchos. So, a lightweight interface needs to replicate this capability for solvers like block CG and the GMRES polynomial that can be implemented for Kokkos DualView objects.

The pseudo-block and polynomial-preconditioned GMRES variants are integrated with dense matrix traits. All GMRES variants have been cleaned up to remove default templates where appropriate.

… tests.

Also fixes a typo in an output message, which infers the solver is GCRODR.

…erformance

The DenseMatrixTraits have been integrated into GCRODR such that the solver can use Kokkos::DualView objects for dense matrices.

This will simplify the transition to using the templated dense matrix type.

Coefficient vectors like alpha, beta, and d do not need to be dense matrix objects.

Only the multiply methods need to be converted to BLAS methods.

…ommit

…eing used.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

WIP (Do Not Merge!!): Belos Small Dense Matrix Abstraction #11837

WIP (Do Not Merge!!): Belos Small Dense Matrix Abstraction #11837

Commits on Oct 1, 2024

Commits on Oct 2, 2024

WIP (Do Not Merge!!): Belos Small Dense Matrix Abstraction #11837

Are you sure you want to change the base?

WIP (Do Not Merge!!): Belos Small Dense Matrix Abstraction #11837

Commits on Oct 1, 2024

Commits on Oct 2, 2024