Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP (Do Not Merge!!): Belos Small Dense Matrix Abstraction #11837

Draft
wants to merge 110 commits into
base: develop
Choose a base branch
from
Draft

WIP (Do Not Merge!!): Belos Small Dense Matrix Abstraction #11837

wants to merge 110 commits into from
+12,436 −3,736

Conversation

jennloe
Copy link
Contributor

@jennloe jennloe commented May 1, 2023

Belos small dense matrix refactor in progress...

@jennloe jennloe added pkg: Belos pkg: Anasazi AT: WIP Causes the PR autotester to not test the PR. (Remove to allow testing to occur.) labels May 1, 2023
jennloe
jennloe commented Jun 26, 2023
View reviewed changes
packages/belos/kokkos/example/bcsstk09.mtx Outdated Show resolved Hide resolved
packages/belos/kokkos/example/ex_real_A.cpp Outdated Show resolved Hide resolved
packages/belos/kokkos/example/CMakeLists.txt Outdated Show resolved Hide resolved
packages/belos/kokkos/example/gmres.hpp Outdated Show resolved Hide resolved
@jhux2 jhux2 mentioned this pull request Jul 10, 2023
Closed
@hkthorn hkthorn force-pushed the DenseAbstract branch 2 times, most recently from 109d85a to e15a45e Compare August 7, 2024 18:43
@hkthorn hkthorn force-pushed the DenseAbstract branch 2 times, most recently from 9fe0ad1 to 21240dc Compare September 25, 2024 17:24
@jennloe @hkthorn
Added DenseMatrix template param to Belos::MultiVecTraits.
f353a3d
@jennloe @hkthorn
Add Dense template paramter to solver manager base class and solver f…
4558b2c 
…actory classes.
@jennloe @hkthorn
Remove Serial Dense from ICGSOrthoMgr
aa21a51
@jennloe @hkthorn
Removed Serial Dense from MatOrthoMgr.
4cac21f
@jennloe @hkthorn
Removed SerialDense from OrthoMgr.
ecf4297
@jennloe @hkthorn
Added Dense param to blockGMRESIter.
fb75baa
@jennloe @hkthorn
Added template param to Gmres iterations.
a2f69ec
@jennloe @hkthorn
Add dense param to GMRES sol mgr and base class.
69a98fc
@jennloe @hkthorn
Added template param to FGmres iter and OrthoMgrFactory.
2ee9622
@jennloe @hkthorn
First attempt at outlining a few Dense Matrix Traits.
0833975
@jennloe @hkthorn
Add header file to Belos src needed for Thyra to compile.
04f69b7
@jennloe @hkthorn
Updated DenseMatrixAdapter functions. Wrote a partial Teuchos Serial …
a83a9c1 
…Dense adapter and test. It compiles and runs
@jennloe @hkthorn
Expanded MultiVec Traits and corresponding Teuchos adapter, which pas…
e182901 
…ses basic tests.
@jennloe @hkthorn
BlockGmres solver partially running through dense mat traits
0475c9c
@jennloe @hkthorn
Add default constructor to dense mat taits.
58f8e97
@jennloe @hkthorn
Update reshape traits fct to have init to zero option.
932b663
@jennloe @hkthorn
Added more functions for GMRES transition.
e271c5e
@jennloe @hkthorn
Converted BlockGmresIter outer layer to use abstract dense.
aa4fe14
@hkthorn
Add complex-valued tests for minres, bicgstab, and gcrodr
9ee594a
@hkthorn
Consolidates Teuchos::ScalarTraits typedefs
aaeb288
@hkthorn
Corrects use of DMT::Value to DMT::ValueConst.
23612ad
@hkthorn
Comments out failing BiCGStab test
95ea9c6
@hkthorn
Adding new tests to exercise orthogonalization options with GCRODR
806fb9d
@hkthorn
Adding method to debugging output to enable better understanding of p…
f49a0e6 
…erformance
@hkthorn
Completes integration of DenseMatrixTraits
2b92f8f 
The DenseMatrixTraits have been integrated into GCRODR such that
the solver can use Kokkos::DualView objects for dense matrices.
@hkthorn
Changes scalar values from SerialDenseMatrix to std::vector<>
a007d5a 
This will simplify the transition to using the templated dense
matrix type.
@hkthorn
Moves several dense matrix objects to std::vector objects
ac5c515 
Coefficient vectors like alpha, beta, and d do not need to be
dense matrix objects.
@hkthorn
Remove unnecessary header
fe52229
@hkthorn
Code cleanup to remove unnecessary dense matrix views
956ba09
@hkthorn
Final clean up before dense matrix traits transformation of RCG
51a5995
@hkthorn
Convert SerialDenseMatrix objects to dense matrix traits.
cd1e46c 
Only the multiply methods need to be converted to BLAS methods.
@hkthorn
Cleans up use of MvAddMv to use Assign when more appropriate
f42c362
@hkthorn
Finishes migration of GEMM calls to use Teuchos::BLAS class
8c73b96
@hkthorn
Removes unused one/zero definitions after MvAddMv -> Assign changes
6df1683
@hkthorn
Fixes RCG solver to be correct with Kokkos::DualView
2524f9c
@hkthorn
Removes unused zero and one definitions
f1979c8
@hkthorn
Fix deprecated std::random_shuffle call
4513c02
@hkthorn
Update pseudo-block solvers for dense matrix abstraction
d92bbf6
@hkthorn
Fixes block GCRODR to compile with updated dense matrix traits
ae03ed8
@hkthorn
Cleaning up unnecessary examples, per Jennifer's note, before final c…
c4b8a32 
…ommit
@hkthorn
Removes dependence of GmresIteration on Teuchos::SerialDenseMatrix
d584a2c
@hkthorn
Adds Teuchos_SerialDenseMatrix and Teuchos_SerialDenseVector headers
23d2aa8
@hkthorn
Adds some checks to avoid compiler errors on unused variables.
ba03404
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hkthorn hkthorn hkthorn left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
AT: WIP Causes the PR autotester to not test the PR. (Remove to allow testing to occur.) pkg: Anasazi pkg: Belos
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jennloe @hkthorn