fix_: hide mercuryo provider #6100
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jenkins Builds
|
mohsen-ghafouri
requested review from
dlipicar,
igor-sirotin,
saledjenic and
friofry
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #6100 +/- ##
============================================
+ Coverage 13.54% 60.91% +47.36%
============================================
Files 804 819 +15
Lines 107898 109471 +1573
============================================
+ Hits 14616 66679 +52063
+ Misses 91398 34961 -56437
- Partials 1884 7831 +5947
Flags with carried forward coverage won't be shown. Click here to find out more.
|
saledjenic
approved these changes
Nov 20, 2024
friofry
approved these changes
Nov 20, 2024
| @@ -29,4 +29,7 @@ type FeatureFlags struct { | |||
|
|
|||
| // EnableCelerBridge indicates whether we should enable the Celer bridge in the Router | |||
| EnableCelerBridge bool | |||
|
|
|||
| // EnableMercuryoProvider indicates whether we should enable the Mercuryo provider in the Wallet | |||
| EnableMercuryoProvider bool | |||
There was a problem hiding this comment.
Why do we need both feature flag and config field? 🤔
There was a problem hiding this comment.
I'm not familiar with the structure, i just did the same thing we had for EnableCelerBridge. should i remove config field?
There was a problem hiding this comment.
Looks to me that we want this to be disabled forever on build-time, so yes. But I'm also not familiar with this code, let's ping @dlipicar, hopefully he can shed some light 🙂
mohsen-ghafouri
force-pushed
the
fix/hide-mercuryo-provider
branch
from
2d41745
to
4305609
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rel status-mobile/issues/21615
Description
hide Mercuryo from the list of on-ramp providers
so that we stay compliant with UK law.