-
Notifications
You must be signed in to change notification settings - Fork 984
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#21615] fix: hide mercuryo provider #21626
Open
mohsen-ghafouri
wants to merge
2
commits into
develop
Choose a base branch
from
fix/hide-mercuryo
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+3
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mohsen-ghafouri
requested review from
vkjr,
briansztamfater and
smohamedjavid
November 14, 2024 14:22
Jenkins BuildsClick to see older builds (4)
|
vkjr
approved these changes
Nov 15, 2024
mohsen-ghafouri
force-pushed
the
fix/hide-mercuryo
branch
from
November 20, 2024 12:06
f20319b
to
e5330a5
Compare
62% of end-end tests have passed
Failed tests (2)Click to expandClass TestCommunityOneDeviceMerged:
Class TestOneToOneChatMultipleSharedDevicesNewUi:
Expected to fail tests (1)Click to expandClass TestCommunityMultipleDeviceMerged:
Passed tests (5)Click to expandClass TestWalletMultipleDevice:
Class TestWalletOneDevice:
Class TestCommunityOneDeviceMerged:
|
@mohsen-ghafouri Thanks for your PR! |
smohamedjavid
approved these changes
Nov 20, 2024
Hi @Horupa-Olena, all good now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #21615
Summary
hide Mercuryo from the list of on-ramp providers
so that we stay compliant with UK law.
Note: it only has status-go changes
Areas that maybe impacted
Result
status: ready