Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Throw abort errors from the channel in cases where the abort is clear #3354

Open
wants to merge 1 commit into
base: 10-02-a_subscriptions_transport_coalescer
Choose a base branch
from

Conversation

steveluscher
Copy link
Collaborator

Summary

We need to take a harder line on what happens when an abort signal is fired. When something is aborted, it's aborted. An AbortError must be thrown. Not a ‘connection failed to be made’ error. That is disingenous, when the real reason the app is throwing is because the developer aborted the connection.

Copy link

changeset-bot bot commented Oct 8, 2024

⚠️ No Changeset found

Latest commit: 6beb407

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@steveluscher steveluscher force-pushed the 10-02-a_subscriptions_transport_coalescer branch from eba9f01 to 6666c55 Compare October 9, 2024 00:25
@steveluscher steveluscher force-pushed the 10-08-throw_abort_errors_from_the_channel_in_cases_where_the_abort_is_clear branch from 6bcdea7 to 6beb407 Compare October 9, 2024 00:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants