-
Notifications
You must be signed in to change notification settings - Fork 852
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Throw abort errors from the channel in cases where the abort is clear #3354
base: 10-02-a_subscriptions_transport_coalescer
Are you sure you want to change the base?
Conversation
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @steveluscher and the rest of your teammates on Graphite |
adb6e86
to
be7e7e3
Compare
9001544
to
375cda6
Compare
be7e7e3
to
ba07109
Compare
375cda6
to
b9f4089
Compare
ba07109
to
eba9f01
Compare
b9f4089
to
6bcdea7
Compare
eba9f01
to
6666c55
Compare
6bcdea7
to
6beb407
Compare
Summary
We need to take a harder line on what happens when an abort signal is fired. When something is aborted, it's aborted. An
AbortError
must be thrown. Not a ‘connection failed to be made’ error. That is disingenous, when the real reason the app is throwing is because the developer aborted the connection.