Prevent false blockheight exceedence errors when transaction confirmations are aborted

[steveluscher]

Summary

I noticed that my application was getting blockheight exceedence errors when there definitely was not one. Turns out the reason was because my application was aborting the confirmation, which would cause all of this code to fall through to the BLOCKHEIGHT_EXCEEDENCE exception.

This PR introduces a throw of the abort after every await. After this change, this existing text becomes consequential:

solana-web3.js/packages/transaction-confirmation/src/__tests__/waiters-test.ts

Lines 146 to 157 in e9d1376

	it('throws when the block height exceedence promise throws', async () => {
	expect.assertions(1);
	getNonceInvalidationPromise.mockRejectedValue(new Error('o no'));
	const commitmentPromise = waitForDurableNonceTransactionConfirmation({
	abortSignal: new AbortController().signal,
	commitment: 'finalized',
	getNonceInvalidationPromise,
	getRecentSignatureConfirmationPromise,
	transaction: MOCK_DURABLE_NONCE_TRANSACTION,
	});
	await expect(commitmentPromise).rejects.toThrow('o no');
	});

[changeset-bot]

🦋 Changeset detected

Latest commit: a1be6f7

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[steveluscher]

• Delete the cached abortable iterable factory #3362
• Update @solana/eslint-config-solana and repair all the unresolved promise lint errors #3361
• Throw abort errors from the channel in cases where the abort is clear #3354
• A subscriptions transport coalescer #3316
• Convert the websocket transport to a channel #3314
• Prevent false blockheight exceedence errors when transaction confirmations are aborted #3353 👈
• Remove spurious abort() calls from the blockheight exceedence tests #3352
• master

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @steveluscher and the rest of your teammates on Graphite