Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix repair float intensity #3688

Merged
merged 2 commits into from
Jan 17, 2024
Merged

Commits on Jan 15, 2024

  1. Configuration menu
    Copy the full SHA
    9067fba View commit details
    Browse the repository at this point in the history

Commits on Jan 16, 2024

  1. fix(repair): get rid of float intensity in internals

    There are still some bugs (one described in the issue below) regarding using float intensity. In order to get rid of them, we should only tolerate float intensity at the entrypoint, but completely remove it from SM repair internals (both in service and progress display).
    
    We keep float intensity in task properties and in swagger endpoint parameters, but we convert it to int intensity as a first thing in internals, which happens in:
    - GetTarget (from task properties)
    - sctool repair control endpoint (from query param)
    
    Fixes #3665
    Michal-Leszczynski committed Jan 16, 2024
    Configuration menu
    Copy the full SHA
    0acf5b0 View commit details
    Browse the repository at this point in the history