Fix repair float intensity

[Michal-Leszczynski]

There are still some bugs (one described in the issue below) regarding using float intensity. In order to get rid of them, we should only tolerate float intensity at the entrypoint, but completely remove it from SM repair internals (both in service and progress display).

We keep float intensity in task properties and in swagger endpoint parameters, but we convert it to int intensity as a first thing in internals, which happens in:

• GetTarget (from task properties)
• sctool repair control endpoint (from query param)

Fixes #3665

[Michal-Leszczynski]

sctool progress output:

[miles@fedora scylla-manager]$ ./sctool repair -c myc --intensity 0.5
repair/7f3676d6-35ee-4958-9cb3-35f9a78e723e
[miles@fedora scylla-manager]$ ./sctool progress -c myc repair/7f3676d6-35ee-4958-9cb3-35f9a78e723e
Run:            51fc9f56-b3d2-11ee-ba36-0892040e83bb
Status:         RUNNING
Start time:     15 Jan 24 19:17:19 CET
Duration:       7s
Progress:       1%
Intensity:      1/1
Parallel:       3/3 (max)
Datacenters:    
  - dc1
  - dc2

╭───────────────────────────────┬────────────────────────────────┬──────────┬──────────╮
│ Keyspace                      │                          Table │ Progress │ Duration │
├───────────────────────────────┼────────────────────────────────┼──────────┼──────────┤
│ system_auth                   │                role_attributes │ 100%     │ 0s       │
│ system_auth                   │                   role_members │ 100%     │ 0s       │
│ system_auth                   │               role_permissions │ 100%     │ 0s       │
│ system_auth                   │                          roles │ 100%     │ 0s       │
├───────────────────────────────┼────────────────────────────────┼──────────┼──────────┤
│ system_distributed_everywhere │ cdc_generation_descriptions_v2 │ 0%       │ 0s       │
├───────────────────────────────┼────────────────────────────────┼──────────┼──────────┤
│ system_distributed            │      cdc_generation_timestamps │ 0%       │ 0s       │
│ system_distributed            │    cdc_streams_descriptions_v2 │ 0%       │ 0s       │
│ system_distributed            │                 service_levels │ 65%      │ 6s       │
│ system_distributed            │              view_build_status │ 0%       │ 0s       │
╰───────────────────────────────┴────────────────────────────────┴──────────┴──────────╯
[miles@fedora scylla-manager]$ ./sctool progress -c myc repair/7f3676d6-35ee-4958-9cb3-35f9a78e723e
Run:            51fc9f56-b3d2-11ee-ba36-0892040e83bb
Status:         DONE
Start time:     15 Jan 24 19:17:19 CET
End time:       15 Jan 24 19:17:58 CET
Duration:       39s
Progress:       100%
Intensity:      1
Parallel:       0
Datacenters:    
  - dc1
  - dc2

╭───────────────────────────────┬────────────────────────────────┬──────────┬──────────╮
│ Keyspace                      │                          Table │ Progress │ Duration │
├───────────────────────────────┼────────────────────────────────┼──────────┼──────────┤
│ system_auth                   │                role_attributes │ 100%     │ 0s       │
│ system_auth                   │                   role_members │ 100%     │ 0s       │
│ system_auth                   │               role_permissions │ 100%     │ 0s       │
│ system_auth                   │                          roles │ 100%     │ 0s       │
├───────────────────────────────┼────────────────────────────────┼──────────┼──────────┤
│ system_distributed_everywhere │ cdc_generation_descriptions_v2 │ 100%     │ 0s       │
├───────────────────────────────┼────────────────────────────────┼──────────┼──────────┤
│ system_distributed            │      cdc_generation_timestamps │ 100%     │ 9s       │
│ system_distributed            │    cdc_streams_descriptions_v2 │ 100%     │ 9s       │
│ system_distributed            │                 service_levels │ 100%     │ 10s      │
│ system_distributed            │              view_build_status │ 100%     │ 9s       │
╰───────────────────────────────┴────────────────────────────────┴──────────┴──────────╯

[karol-kokoszka]

👍