Skip to content
This repository has been archived by the owner on Dec 14, 2022. It is now read-only.

Add support for ROS Noetic #319

Merged
merged 2 commits into from
Jun 7, 2021

Conversation

TSC21
Copy link
Contributor

@TSC21 TSC21 commented Jun 5, 2021

Continues #290.

@TSC21 TSC21 requested a review from a team as a code owner June 5, 2021 11:39
@TSC21 TSC21 requested review from jaisontj and lucashan and removed request for a team June 5, 2021 11:39
Co-authored-by: Emerson Knapp <[email protected]>
Signed-off-by: TSC21 <[email protected]>
@codecov
Copy link

codecov bot commented Jun 5, 2021

Codecov Report

Merging #319 (8aa54a2) into master (86fc2bb) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #319   +/-   ##
=======================================
  Coverage   93.23%   93.23%           
=======================================
  Files          11       11           
  Lines         414      414           
=======================================
  Hits          386      386           
  Misses         28       28           
Flag Coverage Δ
unittests 93.23% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
ros_cross_compile/platform.py 100.00% <100.00%> (ø)
ros_cross_compile/sysroot_creator.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 86fc2bb...8aa54a2. Read the comment docs.

@TSC21
Copy link
Contributor Author

TSC21 commented Jun 5, 2021

For some reason, it fails to fetch the GPG keys for Noetic in Debian Buster in armhf. I don't know if this is a problem on the keys or if the packages are not available anymore on armhf for Debian, so I am marking them for now as not available. @emersonknapp let me know if this is acceptable to you.

Copy link
Contributor

@emersonknapp emersonknapp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmmm, I don't feel too awesome about copying the qemu binaries into this repo. But I think it gets the job done so I'm not going to complain too loudly.

An alternative approach might be to download from the place where they are stored for the multiarch image generation.

@emersonknapp emersonknapp merged commit d14b29a into ros-tooling:master Jun 7, 2021
@TSC21 TSC21 deleted the add_ros_noetic_support branch June 7, 2021 21:43
hidmic pushed a commit to hidmic/cross_compile that referenced this pull request Jun 9, 2021
* add support for ROS Noetic
* Use the same qemu binaries as the ones provided in https://github.com/osrf/multiarch-docker-image-generation
In order to work around https://bugs.launchpad.net/qemu/+bug/1805913 and so qemu supports renameat2() syscall.

Signed-off-by: TSC21 <[email protected]>
Co-authored-by: Emerson Knapp <[email protected]>
@emersonknapp emersonknapp mentioned this pull request Jun 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants