This repository has been archived by the owner on Dec 14, 2022. It is now read-only.
Add qemu binaries to package_data #324
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Michel Hidalgo <[email protected]>
hidmic
requested review from
jaisontj and
zmichaels11
and removed request for
a team
|
Test failures are unrelated to this patch. It's all |
emersonknapp
approved these changes
Jun 9, 2021
|
@emersonknapp it won't auto-merge with failing checks, will it? Test failures seem unrelated and preexisting (or maybe not?): test/test_colcon_mixins.py:24:1: error: Library stubs not installed for "pkg_resources" (or incompatible with Python 3.7)
test/test_colcon_mixins.py:24:1: note: Hint: "python3 -m pip install types-pkg_resources"
test/test_colcon_mixins.py:24:1: note: (or run "mypy --install-types" to install all missing stub packages)
test/test_colcon_mixins.py:24:1: note: See https://mypy.readthedocs.io/en/stable/running_mypy.html#missing-imports |
|
It appears issues are solved by #323. |
|
I've merged after visual analysis that it's the mypy issue - but would like to get that one fixed asap. Discussing on #323 |
|
@hidmic nice catch! Thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up after #319. Binaries do not have a file extension.