Handle distortion in the ipm #64
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Florian Vahl <[email protected]>
Signed-off-by: Florian Vahl <[email protected]>
|
Docs: ros-sports/ipm-docs#5 |
This was referenced Mar 19, 2024
jaagut
approved these changes
Mar 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, no distortion is considered in the IPM and we assume all inputs come from a rectified image. But this might not always be the case. Many CV approaches also perform well on unrectified images and skipping the rectification can be good in terms of performance. In cases like this, the distortion needs to be accounted for during the inverse perspective mapping. This pr introduces a dep to OpenCV to calculate the ray directions. This is able to account for the distortion. It is slightly slower compared to the previous approach, but it still only takes ~1/100 seconds to convert a reasonably sized image in its entirety (which is not the case most of the time).
Closes #11