Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RELEASE] rapids-cmake v24.10 #696

Open
wants to merge 32 commits into
base: main
Choose a base branch
from
Open

[RELEASE] rapids-cmake v24.10 #696

wants to merge 32 commits into from

Commits on Jul 19, 2024

  1. Configuration menu
    Copy the full SHA
    e457cd9 View commit details
    Browse the repository at this point in the history

Commits on Jul 22, 2024

  1. Merge pull request #649 from rapidsai/branch-24.08

    Forward-merge branch-24.08 into branch-24.10
    GPUtester authored Jul 22, 2024
    Configuration menu
    Copy the full SHA
    85c34ce View commit details
    Browse the repository at this point in the history
  2. Merge pull request #650 from rapidsai/branch-24.08

    Forward-merge branch-24.08 into branch-24.10
    GPUtester authored Jul 22, 2024
    Configuration menu
    Copy the full SHA
    fef5453 View commit details
    Browse the repository at this point in the history

Commits on Jul 23, 2024

  1. Merge pull request #653 from rapidsai/branch-24.08

    Forward-merge branch-24.08 into branch-24.10
    GPUtester authored Jul 23, 2024
    Configuration menu
    Copy the full SHA
    107273a View commit details
    Browse the repository at this point in the history

Commits on Jul 24, 2024

  1. Merge pull request #654 from rapidsai/branch-24.08

    Forward-merge branch-24.08 into branch-24.10
    GPUtester authored Jul 24, 2024
    Configuration menu
    Copy the full SHA
    65226e9 View commit details
    Browse the repository at this point in the history
  2. Merge pull request #656 from rapidsai/branch-24.08

    Forward-merge branch-24.08 into branch-24.10
    GPUtester authored Jul 24, 2024
    Configuration menu
    Copy the full SHA
    3cb2e5c View commit details
    Browse the repository at this point in the history

Commits on Jul 29, 2024

  1. Merge pull request #660 from rapidsai/branch-24.08

    Forward-merge branch-24.08 into branch-24.10
    GPUtester authored Jul 29, 2024
    Configuration menu
    Copy the full SHA
    4d1af72 View commit details
    Browse the repository at this point in the history
  2. Merge pull request #663 from rapidsai/branch-24.08

    Forward-merge branch-24.08 into branch-24.10
    GPUtester authored Jul 29, 2024
    Configuration menu
    Copy the full SHA
    4ab600c View commit details
    Browse the repository at this point in the history

Commits on Aug 2, 2024

  1. Remove 24.10 deprecated commands (#665)

    This PR removes the deprecated functions `rapids_cpm_thrust`,  `rapids_cpm_libcudacxx` and `rapids_cuda_patch_toolkit`.
    
    Merges together #664 and #661 together to have passing CI
    
    Authors:
      - Robert Maynard (https://github.com/robertmaynard)
      - Bradley Dice (https://github.com/bdice)
    
    Approvers:
      - Bradley Dice (https://github.com/bdice)
    
    URL: #665
    robertmaynard authored Aug 2, 2024
    Configuration menu
    Copy the full SHA
    120d1fa View commit details
    Browse the repository at this point in the history

Commits on Aug 5, 2024

  1. Remove deprecated rapids_export_find_package_* signatures (#666)

    Remove deprecated sigantures of `rapids_export_find_package_file` and `rapids_export_find_package_root`
    
    Authors:
      - Robert Maynard (https://github.com/robertmaynard)
    
    Approvers:
      - Bradley Dice (https://github.com/bdice)
    
    URL: #666
    robertmaynard authored Aug 5, 2024
    Configuration menu
    Copy the full SHA
    45e4597 View commit details
    Browse the repository at this point in the history

Commits on Aug 7, 2024

  1. Merge pull request #667 from rapidsai/branch-24.08

    Forward-merge branch-24.08 into branch-24.10
    GPUtester authored Aug 7, 2024
    Configuration menu
    Copy the full SHA
    49c361a View commit details
    Browse the repository at this point in the history
  2. Improve update-version.sh (#668)

    A few small tweaks to `update-version.sh` for alignment across RAPIDS.
    
    Authors:
      - Bradley Dice (https://github.com/bdice)
    
    Approvers:
      - James Lamb (https://github.com/jameslamb)
    
    URL: #668
    bdice authored Aug 7, 2024
    Configuration menu
    Copy the full SHA
    f84cb96 View commit details
    Browse the repository at this point in the history

Commits on Aug 8, 2024

  1. Update pre-commit hooks (#669)

    This PR updates pre-commit hooks to the latest versions that are supported without causing style check errors.
    
    Authors:
      - Kyle Edwards (https://github.com/KyleFromNVIDIA)
    
    Approvers:
      - James Lamb (https://github.com/jameslamb)
    
    URL: #669
    KyleFromNVIDIA authored Aug 8, 2024
    Configuration menu
    Copy the full SHA
    a0a7426 View commit details
    Browse the repository at this point in the history

Commits on Aug 12, 2024

  1. add ASSOCIATED_TARGETS to function signature in rapids_cython_create_…

    …modules() docs (#670)
    
    `rapids_cython_create_modules()` accepts an argument `ASSOCIATED_TARGETS` which is missing from the function signature in its docs.
    
    This fixes that.
    
    Authors:
      - James Lamb (https://github.com/jameslamb)
    
    Approvers:
      - Kyle Edwards (https://github.com/KyleFromNVIDIA)
      - Vyas Ramasubramani (https://github.com/vyasr)
    
    URL: #670
    jameslamb authored Aug 12, 2024
    Configuration menu
    Copy the full SHA
    4daac34 View commit details
    Browse the repository at this point in the history

Commits on Aug 14, 2024

  1. Configuration menu
    Copy the full SHA
    17927e9 View commit details
    Browse the repository at this point in the history

Commits on Aug 16, 2024

  1. Allow nested lib location for nvcomp (#675)

    Modify `rapids_cpm_nvcomp()` to allow `CMAKE_INSTALL_LIBDIR` and `CMAKE_INSTALL_INCLUDEDIR` to be nested directories. This is needed to support building wheels that set these variables in order to put their libraries in their own package directory.
    
    Authors:
      - Kyle Edwards (https://github.com/KyleFromNVIDIA)
    
    Approvers:
      - Robert Maynard (https://github.com/robertmaynard)
    
    URL: #675
    KyleFromNVIDIA authored Aug 16, 2024
    Configuration menu
    Copy the full SHA
    1f26d58 View commit details
    Browse the repository at this point in the history
  2. write_language now properly walks up the add_subdirectory call st…

    …ack (#671)
    
    Instead of assuming the filesystem directory layout matches `add_subdirectory` calls, we now walk the CMake
    `PARENT_DIRECTORY` property.
    
    This allows us to handle more custom layouts of CMake projects
    
    Authors:
      - Robert Maynard (https://github.com/robertmaynard)
    
    Approvers:
      - Vyas Ramasubramani (https://github.com/vyasr)
    
    URL: #671
    robertmaynard authored Aug 16, 2024
    Configuration menu
    Copy the full SHA
    20bb29b View commit details
    Browse the repository at this point in the history
  3. rapids_cpm_nvcomp has consistent behavior on every cmake execution (#676

    )
    
    Previously nvcomp wouldn't restore `nvcomp_proprietary_binary` and the install rules for nvcomp on the second execution of CMake. Now we properly restore all needed nvcomp related state so that for each execution of cmake we have consistent behavior.
    
    Authors:
      - Robert Maynard (https://github.com/robertmaynard)
    
    Approvers:
      - Kyle Edwards (https://github.com/KyleFromNVIDIA)
    
    URL: #676
    robertmaynard authored Aug 16, 2024
    Configuration menu
    Copy the full SHA
    2eb1c91 View commit details
    Browse the repository at this point in the history

Commits on Aug 19, 2024

  1. Bump cuco version to fetch several bug fixes (#677)

    This PR bumps the cuco version to the latest to fetch bug fixes for rapidsai/cudf#16405 and rapidsai/cudf#16526
    
    Authors:
      - Yunsong Wang (https://github.com/PointKernel)
    
    Approvers:
      - Vyas Ramasubramani (https://github.com/vyasr)
    
    URL: #677
    PointKernel authored Aug 19, 2024
    Configuration menu
    Copy the full SHA
    0e65a84 View commit details
    Browse the repository at this point in the history

Commits on Aug 20, 2024

  1. Update to CPM 0.40.2 to fix CMake 3.30 deprecation warnings (#678)

    Updated to CPM version 0.40.2 so that we don't se any policy CMP0169 ( `FetchContent_Populate() is deprecated` ) warnings
    
    Authors:
      - Robert Maynard (https://github.com/robertmaynard)
    
    Approvers:
      - Bradley Dice (https://github.com/bdice)
    
    URL: #678
    robertmaynard authored Aug 20, 2024
    Configuration menu
    Copy the full SHA
    2a80e4c View commit details
    Browse the repository at this point in the history
  2. Revert "Update to CPM 0.40.2 to fix CMake 3.30 deprecation warnings (#…

    …678)" (#679)
    
    Proposes reverting #678.
    
    See #680 for context.
    
    Authors:
      - James Lamb (https://github.com/jameslamb)
    
    Approvers:
      - Robert Maynard (https://github.com/robertmaynard)
      - Kyle Edwards (https://github.com/KyleFromNVIDIA)
    
    URL: #679
    jameslamb authored Aug 20, 2024
    Configuration menu
    Copy the full SHA
    82bc63b View commit details
    Browse the repository at this point in the history

Commits on Aug 21, 2024

  1. Update docs for overriding rapids-cmake (#681)

    #257 updated the readme, but forgot to update `basics.rst`. Copy the text from the readme.
    
    Authors:
      - Kyle Edwards (https://github.com/KyleFromNVIDIA)
    
    Approvers:
      - Bradley Dice (https://github.com/bdice)
      - James Lamb (https://github.com/jameslamb)
    
    URL: #681
    KyleFromNVIDIA authored Aug 21, 2024
    Configuration menu
    Copy the full SHA
    9a57b13 View commit details
    Browse the repository at this point in the history
  2. rapids-cmake tests no longer download CPM when NO_CPM_CACHE is set. (

    …#682)
    
    To help reduce the amount of network traffic, rapids-cmake now reuses the same CPM.cmake even when running no CPM cache tests. This elimates one source of network errors as we don't need to fetch the same CPM.cmake multiple times per CI run.
    
    Authors:
      - Robert Maynard (https://github.com/robertmaynard)
    
    Approvers:
      - Kyle Edwards (https://github.com/KyleFromNVIDIA)
    
    URL: #682
    robertmaynard authored Aug 21, 2024
    Configuration menu
    Copy the full SHA
    e6aee97 View commit details
    Browse the repository at this point in the history

Commits on Aug 22, 2024

  1. Reduce cpm tests network usage (#683)

    Updated some of the cpm tests to not clone `cccl` as it has the largest size, but instead using lighter repos.
    Also re-evaluated which tests exactly need `NO_CPM_CACHE` to reduce network traffic.
    
    Authors:
      - Robert Maynard (https://github.com/robertmaynard)
    
    Approvers:
      - Bradley Dice (https://github.com/bdice)
    
    URL: #683
    robertmaynard authored Aug 22, 2024
    Configuration menu
    Copy the full SHA
    2a2c63d View commit details
    Browse the repository at this point in the history
  2. Drop Python 3.9 support (#684)

    Contributes to rapidsai/build-planning#88
    
    Finishes the work of dropping Python 3.9 support.
    
    This project stopped building / testing against Python 3.9 as of rapidsai/shared-workflows#235.
    This PR updates configuration and docs to reflect that.
    
    ## Notes for Reviewers
    
    ### How I tested this
    
    Checked that there were no remaining uses like this:
    
    ```shell
    git grep -E '3\.9'
    git grep '39'
    git grep 'py39'
    ```
    
    And similar for variations on Python 3.8 (to catch things that were missed the last time this was done).
    
    Authors:
      - James Lamb (https://github.com/jameslamb)
    
    Approvers:
      - Bradley Dice (https://github.com/bdice)
    
    URL: #684
    jameslamb authored Aug 22, 2024
    Configuration menu
    Copy the full SHA
    e13d954 View commit details
    Browse the repository at this point in the history

Commits on Aug 27, 2024

  1. Add workaround for gcc bug in cuco (#685)

    We discovered an unfortunate bug in the gcc constexpr evaluator that broke the alignment calculations in cuco.
    
    There is a simple workaround so employ that to unbreak rapids with cccl ToT
    
    Authors:
      - Michael Schellenberger Costa (https://github.com/miscco)
    
    Approvers:
      - Bradley Dice (https://github.com/bdice)
      - Yunsong Wang (https://github.com/PointKernel)
    
    URL: #685
    miscco authored Aug 27, 2024
    Configuration menu
    Copy the full SHA
    eb4107d View commit details
    Browse the repository at this point in the history
  2. Update rapidsai/pre-commit-hooks (#686)

    This PR updates rapidsai/pre-commit-hooks to the version 0.4.0.
    
    Authors:
      - Kyle Edwards (https://github.com/KyleFromNVIDIA)
    
    Approvers:
      - James Lamb (https://github.com/jameslamb)
    
    URL: #686
    KyleFromNVIDIA authored Aug 27, 2024
    Configuration menu
    Copy the full SHA
    cb258cb View commit details
    Browse the repository at this point in the history

Commits on Sep 4, 2024

  1. Add support for Python 3.12 (#688)

    Contributes to rapidsai/build-planning#40
    
    This PR adds support for Python 3.12.
    
    ## Notes for Reviewers
    
    This is part of ongoing work to add Python 3.12 support across RAPIDS.
    It temporarily introduces a build/test matrix including Python 3.12, from rapidsai/shared-workflows#213.
    
    A follow-up PR will revert back to pointing at the `branch-24.10` branch of `shared-workflows` once all
    RAPIDS repos have added Python 3.12 support.
    
    ### This will fail until all dependencies have been updates to Python 3.12
    
    CI here is expected to fail until all of this project's upstream dependencies support Python 3.12.
    
    This can be merged whenever all CI jobs are passing.
    
    Authors:
      - James Lamb (https://github.com/jameslamb)
    
    Approvers:
      - Bradley Dice (https://github.com/bdice)
    
    URL: #688
    jameslamb authored Sep 4, 2024
    Configuration menu
    Copy the full SHA
    0652a0a View commit details
    Browse the repository at this point in the history

Commits on Sep 5, 2024

  1. Upgrade nvcomp to 4.0.1 (#633)

    Upgrade to nvcomp 4.0. As part of that change we need to refactor the `nvcomp.cmake` to be aware of the new CMake files and targets that nvcomp generates.
    
    Authors:
      - Vukasin Milovanovic (https://github.com/vuule)
      - Robert Maynard (https://github.com/robertmaynard)
      - Bradley Dice (https://github.com/bdice)
    
    Approvers:
      - Bradley Dice (https://github.com/bdice)
    
    URL: #633
    vuule authored Sep 5, 2024
    Configuration menu
    Copy the full SHA
    3c9bed0 View commit details
    Browse the repository at this point in the history

Commits on Sep 18, 2024

  1. Configuration menu
    Copy the full SHA
    d2a3054 View commit details
    Browse the repository at this point in the history

Commits on Sep 20, 2024

  1. Add INSTALL_TARGET argument to rapids_add_test() (#692)

    If another command, such as `mpiexec`, is used to execute a target, `rapids_add_test()` currently has no way of installing the target dependency. Add an `INSTALL_TARGET` argument to support this use case.
    
    Authors:
      - Kyle Edwards (https://github.com/KyleFromNVIDIA)
    
    Approvers:
      - Bradley Dice (https://github.com/bdice)
      - Vyas Ramasubramani (https://github.com/vyasr)
    
    URL: #692
    KyleFromNVIDIA authored Sep 20, 2024
    Configuration menu
    Copy the full SHA
    caf5dd6 View commit details
    Browse the repository at this point in the history

Commits on Sep 23, 2024

  1. update fmt (to 11.0.2) and spdlog (to 1.14.1) (#689)

    * Bump fmt (to 11.0.2) and spdlog (to 1.14.1)
    
    * fix fmt pin in dependencies.yaml
    
    * point at rmm testing branch
    
    * try patching fmt
    
    * move patch down into 'fmt' directory
    
    * avoid unrecognized-pragma errors when fmt headers are compiled by C/C++ compilers (only want this for nvcc)
    
    * revert testing-only changes [skip ci]
    
    * skip CI [skip ci]
    jameslamb authored Sep 23, 2024
    Configuration menu
    Copy the full SHA
    3815fab View commit details
    Browse the repository at this point in the history