Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RELEASE] rapids-cmake v24.10 #696

Open
wants to merge 32 commits into
base: main
Choose a base branch
from
Open

[RELEASE] rapids-cmake v24.10 #696

wants to merge 32 commits into from

Conversation

raydouglass
Copy link
Member

❄️ Code freeze for branch-24.10 and v24.10 release

What does this mean?

Only critical/hotfix level issues should be merged into branch-24.10 until release (merging of this PR).

What is the purpose of this PR?

  • Update documentation
  • Allow testing for the new release
  • Enable a means to merge branch-24.10 into main for the release

raydouglass and others added 30 commits July 19, 2024 14:49
@raydouglass
DOC v24.10 Updates [skip ci]
e457cd9
@GPUtester
Merge pull request #649 from rapidsai/branch-24.08
85c34ce 
Forward-merge branch-24.08 into branch-24.10
@GPUtester
Merge pull request #650 from rapidsai/branch-24.08
fef5453 
Forward-merge branch-24.08 into branch-24.10
@GPUtester
Merge pull request #653 from rapidsai/branch-24.08
107273a 
Forward-merge branch-24.08 into branch-24.10
@GPUtester
Merge pull request #654 from rapidsai/branch-24.08
65226e9 
Forward-merge branch-24.08 into branch-24.10
@GPUtester
Merge pull request #656 from rapidsai/branch-24.08
3cb2e5c 
Forward-merge branch-24.08 into branch-24.10
@GPUtester
Merge pull request #660 from rapidsai/branch-24.08
4d1af72 
Forward-merge branch-24.08 into branch-24.10
@GPUtester
Merge pull request #663 from rapidsai/branch-24.08
4ab600c 
Forward-merge branch-24.08 into branch-24.10
@robertmaynard
Remove 24.10 deprecated commands (#665)
120d1fa 
This PR removes the deprecated functions `rapids_cpm_thrust`,  `rapids_cpm_libcudacxx` and `rapids_cuda_patch_toolkit`.

Merges together #664 and #661 together to have passing CI

Authors:
  - Robert Maynard (https://github.com/robertmaynard)
  - Bradley Dice (https://github.com/bdice)

Approvers:
  - Bradley Dice (https://github.com/bdice)

URL: #665
@robertmaynard
Remove deprecated rapids_export_find_package_* signatures (#666)
45e4597 
Remove deprecated sigantures of `rapids_export_find_package_file` and `rapids_export_find_package_root`

Authors:
  - Robert Maynard (https://github.com/robertmaynard)

Approvers:
  - Bradley Dice (https://github.com/bdice)

URL: #666
@GPUtester
Merge pull request #667 from rapidsai/branch-24.08
49c361a 
Forward-merge branch-24.08 into branch-24.10
@bdice
Improve update-version.sh (#668)
f84cb96 
A few small tweaks to `update-version.sh` for alignment across RAPIDS.

Authors:
  - Bradley Dice (https://github.com/bdice)

Approvers:
  - James Lamb (https://github.com/jameslamb)

URL: #668
@KyleFromNVIDIA
Update pre-commit hooks (#669)
a0a7426 
This PR updates pre-commit hooks to the latest versions that are supported without causing style check errors.

Authors:
  - Kyle Edwards (https://github.com/KyleFromNVIDIA)

Approvers:
  - James Lamb (https://github.com/jameslamb)

URL: #669
@jameslamb
add ASSOCIATED_TARGETS to function signature in rapids_cython_create_…
4daac34 
…modules() docs (#670)

`rapids_cython_create_modules()` accepts an argument `ASSOCIATED_TARGETS` which is missing from the function signature in its docs.

This fixes that.

Authors:
  - James Lamb (https://github.com/jameslamb)

Approvers:
  - Kyle Edwards (https://github.com/KyleFromNVIDIA)
  - Vyas Ramasubramani (https://github.com/vyasr)

URL: #670
@robertmaynard
rapids-cmake generated C++ files have current copyright year (#674)
17927e9 
Fixes #657

Authors:
  - Robert Maynard (https://github.com/robertmaynard)
  - Kyle Edwards (https://github.com/KyleFromNVIDIA)

Approvers:
  - Kyle Edwards (https://github.com/KyleFromNVIDIA)

URL: #674
@KyleFromNVIDIA
Allow nested lib location for nvcomp (#675)
1f26d58 
Modify `rapids_cpm_nvcomp()` to allow `CMAKE_INSTALL_LIBDIR` and `CMAKE_INSTALL_INCLUDEDIR` to be nested directories. This is needed to support building wheels that set these variables in order to put their libraries in their own package directory.

Authors:
  - Kyle Edwards (https://github.com/KyleFromNVIDIA)

Approvers:
  - Robert Maynard (https://github.com/robertmaynard)

URL: #675
@robertmaynard
write_language now properly walks up the add_subdirectory call st…
20bb29b 
…ack (#671)

Instead of assuming the filesystem directory layout matches `add_subdirectory` calls, we now walk the CMake
`PARENT_DIRECTORY` property.

This allows us to handle more custom layouts of CMake projects

Authors:
  - Robert Maynard (https://github.com/robertmaynard)

Approvers:
  - Vyas Ramasubramani (https://github.com/vyasr)

URL: #671
@robertmaynard
rapids_cpm_nvcomp has consistent behavior on every cmake execution (#676
2eb1c91 
)

Previously nvcomp wouldn't restore `nvcomp_proprietary_binary` and the install rules for nvcomp on the second execution of CMake. Now we properly restore all needed nvcomp related state so that for each execution of cmake we have consistent behavior.

Authors:
  - Robert Maynard (https://github.com/robertmaynard)

Approvers:
  - Kyle Edwards (https://github.com/KyleFromNVIDIA)

URL: #676
@PointKernel
Bump cuco version to fetch several bug fixes (#677)
0e65a84 
This PR bumps the cuco version to the latest to fetch bug fixes for rapidsai/cudf#16405 and rapidsai/cudf#16526

Authors:
  - Yunsong Wang (https://github.com/PointKernel)

Approvers:
  - Vyas Ramasubramani (https://github.com/vyasr)

URL: #677
@robertmaynard
Update to CPM 0.40.2 to fix CMake 3.30 deprecation warnings (#678)
2a80e4c 
Updated to CPM version 0.40.2 so that we don't se any policy CMP0169 ( `FetchContent_Populate() is deprecated` ) warnings

Authors:
  - Robert Maynard (https://github.com/robertmaynard)

Approvers:
  - Bradley Dice (https://github.com/bdice)

URL: #678
@jameslamb
Revert "Update to CPM 0.40.2 to fix CMake 3.30 deprecation warnings (#…
82bc63b 
…678)" (#679)

Proposes reverting #678.

See #680 for context.

Authors:
  - James Lamb (https://github.com/jameslamb)

Approvers:
  - Robert Maynard (https://github.com/robertmaynard)
  - Kyle Edwards (https://github.com/KyleFromNVIDIA)

URL: #679
@KyleFromNVIDIA
Update docs for overriding rapids-cmake (#681)
9a57b13 
#257 updated the readme, but forgot to update `basics.rst`. Copy the text from the readme.

Authors:
  - Kyle Edwards (https://github.com/KyleFromNVIDIA)

Approvers:
  - Bradley Dice (https://github.com/bdice)
  - James Lamb (https://github.com/jameslamb)

URL: #681
@robertmaynard
rapids-cmake tests no longer download CPM when NO_CPM_CACHE is set. (…
e6aee97 
…#682)

To help reduce the amount of network traffic, rapids-cmake now reuses the same CPM.cmake even when running no CPM cache tests. This elimates one source of network errors as we don't need to fetch the same CPM.cmake multiple times per CI run.

Authors:
  - Robert Maynard (https://github.com/robertmaynard)

Approvers:
  - Kyle Edwards (https://github.com/KyleFromNVIDIA)

URL: #682
@robertmaynard
Reduce cpm tests network usage (#683)
2a2c63d 
Updated some of the cpm tests to not clone `cccl` as it has the largest size, but instead using lighter repos.
Also re-evaluated which tests exactly need `NO_CPM_CACHE` to reduce network traffic.

Authors:
  - Robert Maynard (https://github.com/robertmaynard)

Approvers:
  - Bradley Dice (https://github.com/bdice)

URL: #683
@jameslamb
Drop Python 3.9 support (#684)
e13d954 
Contributes to rapidsai/build-planning#88

Finishes the work of dropping Python 3.9 support.

This project stopped building / testing against Python 3.9 as of rapidsai/shared-workflows#235.
This PR updates configuration and docs to reflect that.

## Notes for Reviewers

### How I tested this

Checked that there were no remaining uses like this:

```shell
git grep -E '3\.9'
git grep '39'
git grep 'py39'
```

And similar for variations on Python 3.8 (to catch things that were missed the last time this was done).

Authors:
  - James Lamb (https://github.com/jameslamb)

Approvers:
  - Bradley Dice (https://github.com/bdice)

URL: #684
@miscco
Add workaround for gcc bug in cuco (#685)
eb4107d 
We discovered an unfortunate bug in the gcc constexpr evaluator that broke the alignment calculations in cuco.

There is a simple workaround so employ that to unbreak rapids with cccl ToT

Authors:
  - Michael Schellenberger Costa (https://github.com/miscco)

Approvers:
  - Bradley Dice (https://github.com/bdice)
  - Yunsong Wang (https://github.com/PointKernel)

URL: #685
@KyleFromNVIDIA
Update rapidsai/pre-commit-hooks (#686)
cb258cb 
This PR updates rapidsai/pre-commit-hooks to the version 0.4.0.

Authors:
  - Kyle Edwards (https://github.com/KyleFromNVIDIA)

Approvers:
  - James Lamb (https://github.com/jameslamb)

URL: #686
@jameslamb
Add support for Python 3.12 (#688)
0652a0a 
Contributes to rapidsai/build-planning#40

This PR adds support for Python 3.12.

## Notes for Reviewers

This is part of ongoing work to add Python 3.12 support across RAPIDS.
It temporarily introduces a build/test matrix including Python 3.12, from rapidsai/shared-workflows#213.

A follow-up PR will revert back to pointing at the `branch-24.10` branch of `shared-workflows` once all
RAPIDS repos have added Python 3.12 support.

### This will fail until all dependencies have been updates to Python 3.12

CI here is expected to fail until all of this project's upstream dependencies support Python 3.12.

This can be merged whenever all CI jobs are passing.

Authors:
  - James Lamb (https://github.com/jameslamb)

Approvers:
  - Bradley Dice (https://github.com/bdice)

URL: #688
@vuule
Upgrade nvcomp to 4.0.1 (#633)
3c9bed0 
Upgrade to nvcomp 4.0. As part of that change we need to refactor the `nvcomp.cmake` to be aware of the new CMake files and targets that nvcomp generates.

Authors:
  - Vukasin Milovanovic (https://github.com/vuule)
  - Robert Maynard (https://github.com/robertmaynard)
  - Bradley Dice (https://github.com/bdice)

Approvers:
  - Bradley Dice (https://github.com/bdice)

URL: #633
@jameslamb
Use CI workflow branch 'branch-24.10' again [skip ci] (#691)
d2a3054
KyleFromNVIDIA and others added 2 commits September 20, 2024 15:00
@KyleFromNVIDIA
Add INSTALL_TARGET argument to rapids_add_test() (#692)
caf5dd6 
If another command, such as `mpiexec`, is used to execute a target, `rapids_add_test()` currently has no way of installing the target dependency. Add an `INSTALL_TARGET` argument to support this use case.

Authors:
  - Kyle Edwards (https://github.com/KyleFromNVIDIA)

Approvers:
  - Bradley Dice (https://github.com/bdice)
  - Vyas Ramasubramani (https://github.com/vyasr)

URL: #692
@jameslamb
update fmt (to 11.0.2) and spdlog (to 1.14.1) (#689)
3815fab 
* Bump fmt (to 11.0.2) and spdlog (to 1.14.1)

* fix fmt pin in dependencies.yaml

* point at rmm testing branch

* try patching fmt

* move patch down into 'fmt' directory

* avoid unrecognized-pragma errors when fmt headers are compiled by C/C++ compilers (only want this for nvcc)

* revert testing-only changes [skip ci]

* skip CI [skip ci]
@raydouglass raydouglass requested review from a team as code owners September 27, 2024 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AyodeAwe AyodeAwe Awaiting requested review from AyodeAwe AyodeAwe is a code owner automatically assigned from rapidsai/packaging-codeowners

At least 3 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@raydouglass @GPUtester @robertmaynard @bdice @KyleFromNVIDIA @jameslamb @PointKernel @miscco @vuule