Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable pytest failures on FutureWarnings/DeprecationWarnings #5877

Merged
merged 4 commits into from
May 1, 2024
Merged

Enable pytest failures on FutureWarnings/DeprecationWarnings #5877

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
f51bb1e
Enable pytest failures on FutureWarnings/DeprecationWarnings
mroeschke Apr 30, 2024
5f5ffb4
Add todo ignores
mroeschke May 1, 2024
eb2cd06
Add github links for todos
mroeschke May 1, 2024
692b345
Update python/pyproject.toml
mroeschke May 1, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
33 changes: 31 additions & 2 deletions python/pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,13 +35,42 @@ markers = [
"no_bad_cuml_array_check: Test that should not check for bad CumlArray uses",
]

testpaths = "cuml/tests"
testpaths = [
"cuml/tests",
"cuml/tests/dask",
"cuml/tests/experimental",
"cuml/tests/explainer",
"cuml/tests/stemmer_tests",
"cuml/tests",
mroeschke marked this conversation as resolved.
Show resolved Hide resolved
]

filterwarnings = [
"error::FutureWarning:cuml[.*]", # Catch uses of deprecated positional args in testing
"error::FutureWarning",
"error::DeprecationWarning",
"error:::cudf",
"ignore:[^.]*ABCs[^.]*:DeprecationWarning:patsy[.*]",
"ignore:(.*)alias(.*):DeprecationWarning:hdbscan[.*]",
# TODO
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we open a GH issue with the content of this file there? Will be great to track tackling these.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea. Opened and linked #5879 #5878

"ignore:.*ndarray.scatter_[(max|add)].* is deprecated:DeprecationWarning:cupyx",
"ignore::FutureWarning:sklearn",
"ignore::DeprecationWarning:sklearn",
# https://github.com/pytest-dev/pytest-cov/issues/557
"ignore:The --rsyncdir command line argument:DeprecationWarning",
# https://github.com/scikit-learn/scikit-learn/pull/25157
"ignore:.* is deprecated. Use files:DeprecationWarning",
# https://github.com/scikit-learn/scikit-learn/pull/25741
"ignore:`product` is deprecated as of NumPy 1.25.0:DeprecationWarning",
# https://github.com/scikit-learn-contrib/hdbscan/pull/612
"ignore:`alltrue` is deprecated as of NumPy 1.25.0:DeprecationWarning",
# https://github.com/scikit-learn/scikit-learn/pull/26287
"ignore:is_sparse is deprecated and will be removed:DeprecationWarning",
# From dask-glm
"ignore:pkg_resources is deprecated as an API:DeprecationWarning",
"ignore:Deprecated call to `pkg_resources.declare_namespace:DeprecationWarning",
"ignore:`rcond` parameter will change to the default:FutureWarning",
"ignore:Dask configuration key 'fuse_ave_width':FutureWarning",
# From hdbscan
"ignore:Conversion of an array with ndim > 0:DeprecationWarning",
]

[project]
Expand Down
20 changes: 0 additions & 20 deletions python/pytest.ini
View file
Open in desktop

This file was deleted.

Loading