Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable pytest failures on FutureWarnings/DeprecationWarnings #5877

Merged
merged 4 commits into from
May 1, 2024

Conversation

mroeschke
Copy link
Contributor

The test suite will now fail on FutureWarnings and DeprecationWarnings as apart of rapidsai/build-planning#26.

pytest.ini was consolidated into pyproject.toml so there's only 1 place with these configs.

There are some TODOs including scikit-learn warnings, but I hope it's OK to potentially pass the baton to @betatim :)

@mroeschke mroeschke requested a review from a team as a code owner May 1, 2024 00:11
@github-actions github-actions bot added the Cython / Python Cython or Python issue label May 1, 2024
@dantegd dantegd added tests Unit testing for project improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels May 1, 2024
Copy link
Member

@dantegd dantegd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR looks great, thanks for the help @mroeschke! Very excited to merge this

"error:::cudf",
"ignore:[^.]*ABCs[^.]*:DeprecationWarning:patsy[.*]",
"ignore:(.*)alias(.*):DeprecationWarning:hdbscan[.*]",
# TODO
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we open a GH issue with the content of this file there? Will be great to track tackling these.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea. Opened and linked #5879 #5878

python/pyproject.toml Outdated Show resolved Hide resolved
@dantegd
Copy link
Member

dantegd commented May 1, 2024

/merge

@rapids-bot rapids-bot bot merged commit 48d9f3b into rapidsai:branch-24.06 May 1, 2024
59 checks passed
@mroeschke mroeschke deleted the test/fail/warnings branch May 1, 2024 22:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Cython / Python Cython or Python issue improvement Improvement / enhancement to an existing function non-breaking Non-breaking change tests Unit testing for project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants