Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove IS_MSVC bool and build_host_info().compiler usage #3204

Closed
wants to merge 1 commit into from
Closed

Remove IS_MSVC bool and build_host_info().compiler usage #3204

wants to merge 1 commit into from

Commits on Oct 1, 2024

  1. Remove IS_MSVC bool and build_host_info().compiler usage (pytorch#3204) 

    Summary:
X-link: facebookresearch/FBGEMM#303

Pull Request resolved: pytorch#3204

`build_host_info()` checks come from buck1, as in buck1 we didn't have a concept of a 'host select()', whereas on buck2 it is preferred to use `select()` after doing a proper configuration transition to the execution platform.

Replace the call to `build_host_info().compiler` here with a select(). Note we still retain function arguments like `msvc` and `buck` as these are apparently used in the CMake build flow.

Reviewed By: 8Keep

Differential Revision: D63710016
    @jdonald @facebook-github-bot
    jdonald authored and facebook-github-bot committed Oct 1, 2024
    Configuration menu
    Copy the full SHA
    2a4ad77 View commit details
    Browse the repository at this point in the history