Remove IS_MSVC bool and build_host_info().compiler usage #3204
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for pytorch-fbgemm-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
This pull request was exported from Phabricator. Differential Revision: D63710016 |
|
This pull request was exported from Phabricator. Differential Revision: D63710016 |
jdonald
added a commit
to jdonald/FBGEMM-1
that referenced
this pull request
Oct 1, 2024
Summary: X-link: facebookresearch/FBGEMM#303 Pull Request resolved: pytorch#3204 `build_host_info()` checks come from buck1, as in buck1 we didn't have a concept of a 'host select()', whereas on buck2 it is preferred to use `select()` after doing a proper configuration transition to the execution platform. Replace the call to `build_host_info().compiler` here with a select(). Note we still retain function arguments like `msvc` and `buck` as these are apparently used in the CMake build flow. Differential Revision: D63710016
jdonald
force-pushed
the
export-D63710016
branch
from
142f6d8
to
95e77d4
Compare
Summary: X-link: facebookresearch/FBGEMM#303 Pull Request resolved: pytorch#3204 `build_host_info()` checks come from buck1, as in buck1 we didn't have a concept of a 'host select()', whereas on buck2 it is preferred to use `select()` after doing a proper configuration transition to the execution platform. Replace the call to `build_host_info().compiler` here with a select(). Note we still retain function arguments like `msvc` and `buck` as these are apparently used in the CMake build flow. Reviewed By: 8Keep Differential Revision: D63710016
|
This pull request was exported from Phabricator. Differential Revision: D63710016 |
jdonald
force-pushed
the
export-D63710016
branch
from
95e77d4
to
2a4ad77
Compare
|
This pull request has been merged in 7c2bfb8. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
build_host_info()checks come from buck1, as in buck1 we didn't have a concept of a 'host select()', whereas on buck2 it is preferred to useselect()after doing a proper configuration transition to the execution platform.Replace the call to
build_host_info().compilerhere with a select(). Note we still retain function arguments likemsvcandbuckas these are apparently used in the CMake build flow.Differential Revision: D63710016