Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

translate reference/datamodel.po #941

Merged
merged 4 commits into from
Sep 24, 2024
Merged

translate reference/datamodel.po #941

merged 4 commits into from
Sep 24, 2024

Conversation

kisaragi-hiu
Copy link
Contributor

@kisaragi-hiu kisaragi-hiu commented Aug 5, 2024 •
edited
Loading

273/804 (33%) -> 307/804 (38%)

Closes #940.

  • I added the previous translator to the Translators: list.
Preview datamodelpreview

mattwang44
mattwang44 reviewed Aug 13, 2024
View reviewed changes
Copy link
Collaborator

@mattwang44 mattwang44 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: 在（除了括號以外的）全形標點符號旁不用放 \\
（以前認知錯誤所以有些地方還沒修正，但加上去的話 render 也不會有問題）

reference/datamodel.po Outdated Show resolved Hide resolved
reference/datamodel.po Outdated Show resolved Hide resolved
reference/datamodel.po Outdated Show resolved Hide resolved
reference/datamodel.po Outdated Show resolved Hide resolved
reference/datamodel.po Outdated Show resolved Hide resolved
reference/datamodel.po Outdated Show resolved Hide resolved
reference/datamodel.po Outdated Show resolved Hide resolved
@kisaragi-hiu
Copy link
Contributor Author

移除了不必要的 \\ 。（太習慣 Org-mode 對全形標點符號的不支援了）

mattwang44
mattwang44 reviewed Aug 14, 2024
View reviewed changes
Copy link
Collaborator

@mattwang44 mattwang44 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

review part 2

reference/datamodel.po Outdated Show resolved Hide resolved
reference/datamodel.po Outdated Show resolved Hide resolved
reference/datamodel.po Outdated Show resolved Hide resolved
reference/datamodel.po Outdated Show resolved Hide resolved
reference/datamodel.po Outdated Show resolved Hide resolved
@mattwang44
Copy link
Collaborator

因應下週 python 正式 release 3.13，main branch 已經切換成 3.13 文件，要再麻煩你 rebase 並切換 target branch 🙏🏽

@kisaragi-hiu kisaragi-hiu changed the base branch from 3.12 to 3.13 September 24, 2024 10:13
kisaragi-hiu and others added 3 commits September 24, 2024 19:15
@kisaragi-hiu
translate reference/datamodel.po
bbbf522
@kisaragi-hiu @mattwang44
Remove extraneous syntax escape as suggested
099e189 
Co-authored-by: Wei-Hsiang (Matt) Wang <[email protected]>
@kisaragi-hiu
Address review
c0a2015 
- Mutable and Immutable are 可變 and 不可變 when being defined
- 你 is used here and not 您
- Apply Matt's review for GC:

  垃圾回收如何進行完全是各個實作自己的事項，唯一擔保是仍然可存取的物件絕不會被回收。
  ->
  垃圾回收如何進行完全取決於各個實作，只要沒有被回收的物件仍是可達的。

- Revise away "單層"
- Apply review for 型別幾乎影響物件行為的所有面向
@kisaragi-hiu
Copy link
Contributor Author

已 rebase、修改 target 並回應 review; sorry for the delayed response

mattwang44
mattwang44 reviewed Sep 24, 2024
View reviewed changes
reference/datamodel.po Outdated Show resolved Hide resolved
mattwang44
mattwang44 approved these changes Sep 24, 2024
View reviewed changes
Copy link
Collaborator

@mattwang44 mattwang44 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mattwang44 mattwang44 merged commit b1e2866 into python:3.13 Sep 24, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattwang44 mattwang44 mattwang44 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Translate reference/datamodel.po
2 participants
@kisaragi-hiu @mattwang44