Pass --proxy to build subprocesses #13124
Open
+25
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Similar to --cert and --client-cert, the --proxy flag was not passed down to the isolated build environment. This was simply an oversight. I opted to store the original proxy string in a new attribute on the session as digging into the .proxies dictionary felt janky, and so did passing the proxy string to the finder as an argument. Co-authored-by: lcmartin <[email protected]>
|
Hi @martinezlc99, I took your PR and effectively rewrote it. I think it's cleaner to simply add a new attribute on the pip session to store the proxy, similar to how other network configuration (trusted-hosts, TLS certificates) is already passed through the finder. I also added a test. Anyway, I did add you as a co-author as I'm still building off of your work. PTAL! |
|
@ichard26 thanks! I am not super familiar with the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to
--certand--client-cert, the --proxy flag was not passed down to the isolated build environment. This was simply an oversight.I opted to store the original proxy string in a new attribute on the session as digging into the .proxies dictionary felt janky, and so did passing the proxy string to the finder as an argument.
Fixes #6018. This supersedes and closes #13075.