Pass --proxy Option To Build Environment #13075
Open
+10
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm going to add this to the 25.0 milestone so it's not forgotten, but someone will still need to volunteer to review and/or accept. |
1 task
|
See #13124 which supersedes this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6018
I have ran into this issue a few times when my corporate proxy was not set in my shell. As mentioned in #6018 (comment), I can reliably replicate this issue in my corporate environment, although I do not make use of any
pipenvironmental variables.My environment makes use of a private PyPI server and associated extra index URL(s) and trusted host(s). Note in my case, it was only the
--proxyoption that was missing. I mention this since I cannot say for sure if this will solve all issues, although it seems environmental variables are available in the build environment - hence the workaround mentioned in #6018 (comment).I did not add any tests as I was not sure how to test the use of a proxy in the build environment. The existing tests for the
--proxyoption seemed adequate. Glad to add a test for a specific scenario if anyone has any ideas.