Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

metrics: add col/idx name(s) for BackfillProgressGauge and BackfillTotalCounter (#58380) #58530

Merged

Conversation

ti-chi-bot
Copy link
Member

@ti-chi-bot ti-chi-bot commented Dec 25, 2024

This is an automated cherry-pick of #58380

What problem does this PR solve?

Issue Number: close #58114

Problem Summary:

For BackfillProgressGauge and BackfillTotalCounter, tidb only shows the database name and table name in the metrics. If we add multiple indexes on a single table, it would be difficult to know the rate and progress of each index.

What changed and how does it work?

  • Add column names and index names for metrics.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Test script:

mysql -h 127.0.0.1 -P4000 -uroot -e'create database test1; create database test2;'

sysbench oltp_read_write prepare --db-driver=mysql --mysql-host=127.0.0.1 --mysql-port=4000 --mysql-user=root --mysql-db=test1 --threads=16 --tables=2 --table-size=1000000
sysbench oltp_read_write prepare --db-driver=mysql --mysql-host=127.0.0.1 --mysql-port=4000 --mysql-user=root --mysql-db=test2 --threads=16 --tables=2 --table-size=1000000

# Add Index
mysql -h 127.0.0.1 -P4000 -uroot -e'create index k_pad on test1.sbtest1(pad); alter table test1.sbtest2 add index k_pad(pad), add index k_comp(c, pad);'
mysql -h 127.0.0.1 -P4000 -uroot -e'create index k_pad on test2.sbtest1(pad); alter table test2.sbtest2 add index k_pad(pad), add index k_comp(c, pad);'

# Modify Column
mysql -h 127.0.0.1 -P4000 -uroot -e'alter table test1.sbtest1 change column k k varchar(64); alter table test1.sbtest2 change column k k varchar(64);'
mysql -h 127.0.0.1 -P4000 -uroot -e'alter table test2.sbtest1 change column k k varchar(64); alter table test2.sbtest2 change column k k varchar(64);'
image

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. type/cherry-pick-for-release-8.1 This PR is cherry-picked to release-8.1 from a source PR. labels Dec 25, 2024
@ti-chi-bot ti-chi-bot bot added do-not-merge/cherry-pick-not-approved size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Dec 25, 2024
@ti-chi-bot ti-chi-bot bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Dec 25, 2024
@CbcWestwolf CbcWestwolf force-pushed the cherry-pick-58380-to-release-8.1 branch from 285e9df to c238237 Compare December 25, 2024 13:02
Copy link

codecov bot commented Dec 25, 2024

Codecov Report

Attention: Patch coverage is 89.79592% with 10 lines in your changes missing coverage. Please review.

Please upload report for BASE (release-8.1@80db670). Learn more about missing BASE report.

Additional details and impacted files
@@               Coverage Diff                @@
##             release-8.1     #58530   +/-   ##
================================================
  Coverage               ?   71.1999%           
================================================
  Files                  ?       1468           
  Lines                  ?     423794           
  Branches               ?          0           
================================================
  Hits                   ?     301741           
  Misses                 ?     101519           
  Partials               ?      20534           
Flag Coverage Δ
unit 71.1999% <89.7959%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.9656% <0.0000%> (?)
parser ∅ <0.0000%> (?)
br 41.2572% <0.0000%> (?)

@CbcWestwolf
Copy link
Member

/retest

@CbcWestwolf CbcWestwolf force-pushed the cherry-pick-58380-to-release-8.1 branch from c238237 to 2072983 Compare December 26, 2024 05:36
@CbcWestwolf CbcWestwolf force-pushed the cherry-pick-58380-to-release-8.1 branch from 2072983 to da31a9b Compare December 26, 2024 05:49
@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Dec 26, 2024
Copy link

ti-chi-bot bot commented Dec 26, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: CbcWestwolf, tangenta

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Dec 26, 2024
Copy link

ti-chi-bot bot commented Dec 26, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-12-26 06:28:44.382447094 +0000 UTC m=+1715914.471249633: ☑️ agreed by tangenta.
  • 2024-12-26 06:36:57.527517793 +0000 UTC m=+1716407.616320333: ☑️ agreed by CbcWestwolf.

@ti-chi-bot ti-chi-bot bot added cherry-pick-approved Cherry pick PR approved by release team. and removed do-not-merge/cherry-pick-not-approved labels Dec 26, 2024
@ti-chi-bot ti-chi-bot bot merged commit f3f44da into pingcap:release-8.1 Dec 26, 2024
18 checks passed
@CbcWestwolf CbcWestwolf deleted the cherry-pick-58380-to-release-8.1 branch December 26, 2024 07:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved cherry-pick-approved Cherry pick PR approved by release team. lgtm release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. type/cherry-pick-for-release-8.1 This PR is cherry-picked to release-8.1 from a source PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants