-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
metrics: add col/idx name(s) for BackfillProgressGauge and BackfillTotalCounter (#58380) #58530
metrics: add col/idx name(s) for BackfillProgressGauge and BackfillTotalCounter (#58380) #58530
Conversation
Signed-off-by: ti-chi-bot <[email protected]>
This reverts commit 2c98dec.
285e9df
to
c238237
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## release-8.1 #58530 +/- ##
================================================
Coverage ? 71.1999%
================================================
Files ? 1468
Lines ? 423794
Branches ? 0
================================================
Hits ? 301741
Misses ? 101519
Partials ? 20534
Flags with carried forward coverage won't be shown. Click here to find out more.
|
/retest |
c238237
to
2072983
Compare
2072983
to
da31a9b
Compare
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: CbcWestwolf, tangenta The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
This is an automated cherry-pick of #58380
What problem does this PR solve?
Issue Number: close #58114
Problem Summary:
For BackfillProgressGauge and BackfillTotalCounter, tidb only shows the database name and table name in the metrics. If we add multiple indexes on a single table, it would be difficult to know the rate and progress of each index.
What changed and how does it work?
Check List
Tests
Test script:
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.