Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes suggested by Jordan / Luke #650

Merged
merged 14 commits into from
Apr 10, 2024
Merged

Fixes suggested by Jordan / Luke #650

merged 14 commits into from
Apr 10, 2024

Conversation

AaDalal
Copy link
Contributor

@AaDalal AaDalal commented Apr 9, 2024

  • support for fulfilling with 3 digit codes
  • make the general course search more clear on the UI
  • make the root font-size smaller so the UI is less cramped
  • make year a free input field
  • make edit mode not turn off when you add or delete a semester
  • course credits are sometimes wrong. Two potential root causes:
    • credits sql is wrong (e.g., MATH 1400 is not 2 credits)
    • course with no credits defaults to 1 CU on the frontend. Need to make sure we get the course of that code with credits from the backend.

For a later pr:

  • add clear course dock button -> need to make sure this doesn't lead to some weird state with fulfillments (jordan in Add a dock clear button #648)
  • fix issues with radix ui select menus being partially hidden

@JHawk0224
Copy link
Member

❤️

@AaDalal AaDalal merged commit 0d78349 into master Apr 10, 2024
13 checks passed
@AaDalal AaDalal deleted the aag/jordan-fixes branch April 10, 2024 07:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants