add dnd support to search panel, highlight searched rule, UI adjustments #640
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
yuntongf
commented
Apr 9, 2024
yuntongf
commented
- Can now drag a course from search result to plan panel, req panel, dock
- When user clicks search for a specific rule, the rule will be highlighted on the req panel as the search panel displays search results
- Reduce gap between req and search panels
AaDalal
reviewed
Apr 9, 2024
| ${props => !!props.$isSearched && ` | ||
| border-radius: 10px; | ||
| box-shadow: 8px 6px 10px 8px #00000026; | ||
| `} |
There was a problem hiding this comment.
I think this shadow looks a little weird bc it's so strong. Maybe we could change the color or apply some other effect to the surface of the search condition when clicked? let me know what you think
There was a problem hiding this comment.
I changed this to lighter and less aggressive shadow, similar to the one shown for droppable boxes
Revert "Aug/add semester popup"
AaDalal
reviewed
Apr 10, 2024
| const handleCloseSearch = () => { | ||
| setQueryString(""); | ||
| setSearchPanelOpen(false); | ||
| setSearchedRuleId(-1); |
There was a problem hiding this comment.
I think the value should be null instead of -1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.