Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Try to use Boost 1.86 instead to fix MacOS failures. #4950

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

Try to use Boost 1.86 instead to fix MacOS failures. #4950

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
32cc8b8
Try to use Boost 1.86 instead to fix MacOS failures.
fruffy Oct 8, 2024
e868a81
Try an approach using --overwrite.
fruffy Oct 8, 2024
617db0b
Try an approach using --ignore-dependencies.
fruffy Oct 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion tools/install_mac_deps.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
# Script to install P4C dependencies on MacOS.

set -e # Exit on error.
set -x # Make command execution verbose

# Installation helper.
brew_install() {
Expand Down Expand Up @@ -41,12 +42,14 @@ BOOST_LIB="[email protected]"
REQUIRED_PACKAGES=(
autoconf automake ccache cmake libtool
openssl pkg-config coreutils bison grep ninja
${BOOST_LIB}
)
for package in "${REQUIRED_PACKAGES[@]}"; do
brew_install ${package}
done

# The boost installation is flaky, do not fail if it fails.
brew_install ${BOOST_LIB} || echo "Failed to install ${BOOST_LIB}"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But how does the build work without boost?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The problem is that boost is installed fine but the installation of a dependency of that brew package fails (Python 3.12). Unclear to me how to fix that. Maybe there is a flag for that problem.


# Check if linking is needed.
if ! brew ls --linked --formula ${BOOST_LIB} > /dev/null 2>&1; then
brew link ${BOOST_LIB}
Expand Down
Loading