Try to use Boost 1.86 instead to fix MacOS failures. #4950
+2
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fruffy
added
the
infrastructure
fruffy
force-pushed
the
fruffy/macos_fix
branch
from
824cd2a
to
702e3b8
Compare
fruffy
force-pushed
the
fruffy/macos_fix
branch
from
702e3b8
to
2f8843d
Compare
Signed-off-by: fruffy <[email protected]>
fruffy
force-pushed
the
fruffy/macos_fix
branch
from
2f8843d
to
32cc8b8
Compare
vlstill
reviewed
Oct 8, 2024
tools/install_mac_deps.sh
Outdated
| ) | ||
| for package in "${REQUIRED_PACKAGES[@]}"; do | ||
| brew_install ${package} | ||
| done | ||
|
|
||
| # The boost installation is flaky, do not fail if it fails. | ||
| brew_install ${BOOST_LIB} || echo "Failed to install ${BOOST_LIB}" |
There was a problem hiding this comment.
But how does the build work without boost?
There was a problem hiding this comment.
The problem is that boost is installed fine but the installation of a dependency of that brew package fails (Python 3.12). Unclear to me how to fix that. Maybe there is a flag for that problem.
Signed-off-by: fruffy <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.