pkgconfig: minor fixes #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…l candidates PkgConfig.load might fail, which would cause the cache to be corrupted.
This was referenced Jun 9, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is now three versions of this fix
Alex: #29
Mine: 28052ae
Thomas: #31
Alex is IMO too generic (not matching specifically the pattern)
Thomas' is broken (Ruby regexp are mostly perl-compatible, i.e. no need to quote +)
It's left with mine. I was stupid and did not extract it into a separate PR (I'm waiting for next week's demos at DFKI to pass before I merge #30 and related pull requests). This is what this PR is about, with some additional bugfixes to get the test suite to pass on my system.