pkgconfig: adapt FOUND_PATH_RX to handle debug out of pkgconfig<=0.29.1 #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
|
There are already two versions of this fix (this is the third). Admittedly, mine was hidden in a different, more invasive, PR but Alex wasn't (hint hint ... check the list of open pull requests ...) Anyways, here's the final take on this: #32. I'm closing your PR and Alex's. (For the record, yours is broken, ruby and perl regexp do not need to quote '+', moreover there were no unit tests) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the broken Utilrb::PkgConfig.default_search_path on Ubuntu Xenial
pkgconfig version 0.26: Scanning directory '/usr/share/pkgconfig'
pkgconfig version 0.29.1: Scanning directory #6 'usr/share/pkgconfig'