Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

numpy, flask, jsonschema versionfreezing #693

Merged
merged 8 commits into from
Jun 21, 2024
Merged

numpy, flask, jsonschema versionfreezing #693

merged 8 commits into from
Jun 21, 2024

Conversation

burnout87
Copy link
Collaborator

No description provided.

@burnout87 burnout87 changed the title bokeh version bokeh, flask, jsonschema versionfreezing Jun 20, 2024
Copy link

codecov bot commented Jun 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 62.34%. Comparing base (e4b7784) to head (63347bb).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #693   +/-   ##
=======================================
  Coverage   62.34%   62.34%           
=======================================
  Files          50       50           
  Lines        8950     8950           
=======================================
  Hits         5580     5580           
  Misses       3370     3370           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@burnout87 burnout87 marked this pull request as ready for review June 20, 2024 12:56
@dsavchenko
Copy link
Member

  • Could you briefly describe what problem does it fix?
  • Would be better to have more loose restrictions in setup.py and freeze only in requirements.txt if possible
  • The snyk test is failing (but I can't see the problem, it's only @volodymyrss who has access)
  • So bokeh is not finally freezed?

@burnout87
Copy link
Collaborator Author

  • Could you briefly describe what problem does it fix?

When using python 3.10 (and above) it installs the version 2.0.0 of numpy, which causes the error seen here, a compatibility one between the version of bokeh (2.4.2, which is frozen) and the newer version of numpy. So, by freezing the version to 1.24.4, this does not happen

* So bokeh is not finally freezed?

It is actually already frozen, to the version 2.4.2

@burnout87 burnout87 changed the title bokeh, flask, jsonschema versionfreezing numpy, flask, jsonschema versionfreezing Jun 20, 2024
@burnout87
Copy link
Collaborator Author

also, some issues with the versioning of flask and jsonschema came out while I was testing,hence the freezing of those libraries too

@volodymyrss
Copy link
Member

  • Could you briefly describe what problem does it fix?

When using python 3.10 (and above) it installs the version 2.0.0 of numpy, which causes the error seen here, a compatibility one between the version of bokeh (2.4.2, which is frozen) and the newer version of numpy. So, by freezing the version to 1.24.4, this does not happen

could be better to put <2.0.0 constraint for numpy.

* So bokeh is not finally freezed?

It is actually already frozen, to the version 2.4.2

setup.py Outdated Show resolved Hide resolved
@burnout87
Copy link
Collaborator Author

I tried to change the restrictions on flask (given the warning from snyk) but I am not really successful...

Copy link
Member

@volodymyrss volodymyrss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, well, if that's the best that seems possible.

@burnout87
Copy link
Collaborator Author

Ok, well, if that's the best that seems possible.

we'll certainly have to deal again with those dependencies in the future (eg with new versions of other libraries), then we'll see

@burnout87 burnout87 merged commit e8f8082 into master Jun 21, 2024
16 of 17 checks passed
This was referenced Jun 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants