Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

validators version issue? #692

Closed
volodymyrss opened this issue Jun 19, 2024 · 8 comments
Closed

validators version issue? #692

volodymyrss opened this issue Jun 19, 2024 · 8 comments
Assignees

Comments

@volodymyrss
Copy link
Member

validators==0.28.3

this breaks in here

https://github.com/oda-hub/oda_api/actions/runs/9135072621/job/26304556424

Why could it be?

@burnout87
Copy link
Collaborator

burnout87 commented Jun 19, 2024

That happens because there is an attempt to installs the library validators at the latest version, with python 3.7, which is not compatible .

We never saw on the dispatcher because we run out github workflows using python 3.8 and up, never 3.7.

Can we remove the support to that python version ?

@volodymyrss
Copy link
Member Author

there is now a problem with bokeh - numpy compatibility.
Can we safely upgrade bokeh or should we freeze numpy?

@burnout87
Copy link
Collaborator

I quickly tried to install the latest versions of bokeh and numpy and I don't see that error, but of course it is not a guarantee

@volodymyrss
Copy link
Member Author

I quickly tried to install the latest versions of bokeh and numpy and I don't see that error, but of course it is not a guarantee

If it works for the dispatcher visualization, if you tried that on your dev instance, lets upgrade. Could you check if it works on a dev instance?

@burnout87
Copy link
Collaborator

no, I spoke a bit too early, and it seems there would be more problems upgrading bokeh https://github.com/oda-hub/dispatcher-app/actions/runs/9584813165/job/26429259309?pr=693

@volodymyrss
Copy link
Member Author

no, I spoke a bit too early, and it seems there would be more problems upgrading bokeh https://github.com/oda-hub/dispatcher-app/actions/runs/9584813165/job/26429259309?pr=693

need to pick one that works I guess

@burnout87
Copy link
Collaborator

it seems like that by freezing the numpy version the issue is solved:

numpy==1.24.4

@burnout87
Copy link
Collaborator

ok, it seems that #693 fixed it
I guess we can close this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants