Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sensory corpuscle #3295

Merged
merged 11 commits into from
Sep 3, 2024
Merged

Add sensory corpuscle #3295

merged 11 commits into from
Sep 3, 2024

Conversation

lubianat
Copy link
Contributor

Adds sensory corpuscle and positions Meissner, Pacinian, Ruffini and Herbst's under it.

Related to #3290 .

Note: required for lamellar cell:

PS: Some other modifications happened on the file by the time of saving. Not sure how to avoid them.

Adds sensory corpuscle and positions Meissner, Pacinian, Ruffini and Herbst's under it.
@aleixpuigb aleixpuigb assigned aleixpuigb and lubianat and unassigned aleixpuigb Jun 12, 2024
synonym: "COEC" EXACT [PMID:35356056]
synonym: "cutaneous end-organ complex" EXACT [PMID:35356056]
xref: http://www.wikidata.org/entity/Q126363978
is_a: UBERON:0005162 ! multi cell part structure
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The definition of multi cell part structure is:

A structure consisting of multiple cell components but which is not itself a cell and does not have (complete) cells as a part.

In sensory corpuscles there are some complete cells. I'm not aware if there is a term that comprises parts of cells and complete cells, but I will have a look.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The definition of multi cell part structure is:

A structure consisting of multiple cell components but which is not itself a cell and does not have (complete) cells as a part.

In sensory corpuscles there are some complete cells. I'm not aware if there is a term that comprises parts of cells and complete cells, but I will have a look.

Oh, curious. I had not seen the definition, I interpreted quite the oposite from the label!!

So apparently the capsule of the Pacinian corpuscle is being excluded altogether from the Pacinian corpuscle itself.

I'll copy that in the issue.

Copy link
Collaborator

@aleixpuigb aleixpuigb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ruffini nerve ending seems to refer to Ruffini corpuscle. I think it should be relabeled, but in another ticket.
Once the branch is updated, I will approve.

aleixpuigb
aleixpuigb previously approved these changes Jun 25, 2024
Copy link
Collaborator

@aleixpuigb aleixpuigb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

src/ontology/uberon-edit.obo Outdated Show resolved Hide resolved
With new OWL API 4.5.29 we can now define idspaces for NIF_Subcellular.
Its terms were mistakenly changed to the OBO namespace when using
Protégé 5.6.5. This commit fixes that.
Copy link

github-actions bot commented Aug 2, 2024

This PR has not seen any activity in the past month; if nobody comments or reviews it in the next week, the PR creator will be allowed to proceed with merging without explicit approval, should they wish to do so.

@anitacaron anitacaron linked an issue Aug 14, 2024 that may be closed by this pull request
@aleixpuigb
Copy link
Collaborator

@anitacaron what is missing in this PR?

@anitacaron anitacaron self-requested a review September 2, 2024 14:55
@anitacaron
Copy link
Collaborator

From my part, it looks good. You can go ahead and finish your review.

Copy link
Collaborator

@aleixpuigb aleixpuigb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@anitacaron anitacaron merged commit 8134063 into master Sep 3, 2024
1 check passed
@anitacaron anitacaron deleted the issue-3290 branch September 3, 2024 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[NTR] New Term Request: sensory corpuscle
4 participants