Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix method name and comment #322

Closed
wants to merge 7 commits into from
Closed

fix method name and comment #322

Show file tree
Hide file tree
Changes from 6 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
6bbed47
Microsoft.Extensions.ServiceDiscovery support
ZUOXIANGE Sep 17, 2024
fd1c7d0
Merge branch 'dev' of github.com:ZUOXIANGE/nacos-sdk-csharp into dev
ZUOXIANGE Sep 17, 2024
e727a9d
comment fix
ZUOXIANGE Sep 19, 2024
f2a24b7
comment fix
ZUOXIANGE Sep 20, 2024
32a6870
Merge branch 'nacos-group:dev' into dev
ZUOXIANGE Sep 22, 2024
dd72828
fix method name and comment
ZUOXIANGE Sep 22, 2024
928ae2e
fix readme
ZUOXIANGE Sep 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion samples/App3/Program.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@
o.RefreshPeriod = TimeSpan.FromSeconds(60);
})
.AddConfigurationServiceEndpointProvider()
.AddNacosSrvServiceEndpointProvider();
.AddNacosServiceEndpointProvider();

builder.Services.ConfigureHttpClientDefaults(static http =>
{
Expand Down
7 changes: 6 additions & 1 deletion src/Nacos.Microsoft.Extensions.ServiceDiscovery/NacosServiceDiscoveryExtensions.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,12 @@ namespace Microsoft.Extensions.Hosting;

public static class NacosServiceDiscoveryExtensions
{
public static IServiceCollection AddNacosSrvServiceEndpointProvider(this IServiceCollection services)
/// <summary>
/// Configures a service discovery endpoint provider which uses <see cref="T:Nacos.V2.INacosNamingService" /> to resolve endpoints.
/// </summary>
/// <param name="services">The service collection.</param>
/// <returns>The service collection.</returns>
public static IServiceCollection AddNacosServiceEndpointProvider(this IServiceCollection services)
{
ArgumentNullException.ThrowIfNull(services);

Expand Down
Loading