Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix method name and comment #322

Closed
wants to merge 7 commits into from
Closed

fix method name and comment #322

wants to merge 7 commits into from

Conversation

ZUOXIANGE
Copy link
Contributor

关联 #317

catcherwong
catcherwong requested changes Sep 22, 2024
View reviewed changes
Copy link
Collaborator

@catcherwong catcherwong left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nacos/Microsoft.Extensions.ServiceDiscovery 目录下面的 Readme 也改一下，那个是nuget包会展示的信息，用法要保证是正确的。

另外， 最好 rebase 一下，我看前面几个commit 是上一个 pr 的。

@ZUOXIANGE
Copy link
Contributor Author

ZUOXIANGE commented Sep 22, 2024 •
edited
Loading

用法改了,这个rebase应该怎么操作,我搞了一会儿没整明白,可能和我一开始用了merge有关

@catcherwong
Copy link
Collaborator

参考一下 https://juejin.cn/post/6969101234338791432

如果实在不行，考虑重新 fork ，然后 PR

@ZUOXIANGE ZUOXIANGE closed this by deleting the head repository Sep 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@catcherwong catcherwong catcherwong requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ZUOXIANGE @catcherwong