Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More clearly define how seller trusted signals fetching works #4

Open
wants to merge 65 commits into
base: rework-fetch
Choose a base branch
from

Commits on Jul 8, 2024

  1. Very vague spec of proper batcher.

    Maks Orlovich committed Jul 8, 2024
    Configuration menu
    Copy the full SHA
    6940b92 View commit details
    Browse the repository at this point in the history

Commits on Jul 9, 2024

  1. Fill out the algorithm and wire it through

    Maks Orlovich committed Jul 9, 2024
    Configuration menu
    Copy the full SHA
    909fde1 View commit details
    Browse the repository at this point in the history

Commits on Jul 11, 2024

  1. Merge branch 'rework-fetch' into fetcher-more-spec

    Maks Orlovich committed Jul 11, 2024
    Configuration menu
    Copy the full SHA
    820f892 View commit details
    Browse the repository at this point in the history
  2. Merge branch 'rework-fetch' into fetcher-more-spec

    Maks Orlovich committed Jul 11, 2024
    Configuration menu
    Copy the full SHA
    23a06d9 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    c2b58d4 View commit details
    Browse the repository at this point in the history

Commits on Jul 15, 2024

  1. Configuration menu
    Copy the full SHA
    5198bde View commit details
    Browse the repository at this point in the history

Commits on Jul 16, 2024

  1. Configuration menu
    Copy the full SHA
    743537d View commit details
    Browse the repository at this point in the history
  2. [Spec] Fix spacing (WICG#1223)

    * [Spec] Fix spacing
    
    * Update spec.bs
    
    Co-authored-by: qingxinwu <[email protected]>
    
    ---------
    
    Co-authored-by: qingxinwu <[email protected]>
    caraitto and qingxinwu authored Jul 16, 2024
    Configuration menu
    Copy the full SHA
    2ec2eac View commit details
    Browse the repository at this point in the history

Commits on Jul 22, 2024

  1. More explicit representation of script fetch parallelism (WICG#1225)

    * Specify support for cross-origin trusted signals,
    
    and the bundled queryFeatureSupport('*'). This also includes
    fixes to some bugs in parsing of these URLs (some of the
    checks were missing).
    
    * Simpler part of feedback
    
    * Refactor trustedBiddingSignalsURL config.
    
    * Update scoring, also remove some diff noise.
    
    * Split function.
    
    * Apply feedback
    
    * Apply feedback.
    
    * Apply suggestions I didn't need to ask follow ups on
    
    * Apply a typo fix Qingxin pointed out which I missed because
    there was another comment about the same line.
    
    * Fix same origin checks
    
    * varify ignored placeholders
    
    * Rework the merging language.
    
    * Some first steps towards expression some fetch parallelism.
    
    * Improve some phrasing as suggested
    
    * Fix wrong indentation level, now I can see in a preview diff.
    
    * Fix missing comma.
    
    ---------
    
    Co-authored-by: Maks Orlovich <[email protected]>
    morlovich and Maks Orlovich authored Jul 22, 2024
    Configuration menu
    Copy the full SHA
    032f159 View commit details
    Browse the repository at this point in the history
  2. Merge branch 'main' into rework-fetch

    Maks Orlovich committed Jul 22, 2024
    Configuration menu
    Copy the full SHA
    764002a View commit details
    Browse the repository at this point in the history
  3. Merge branch 'rework-fetch' into fetcher-more-spec

    Maks Orlovich committed Jul 22, 2024
    Configuration menu
    Copy the full SHA
    c735f94 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    e596a47 View commit details
    Browse the repository at this point in the history

Commits on Jul 23, 2024

  1. Mention filtering ID in the Private Aggregation extensions explainer (W…

    …ICG#1129)
    
    Adds a filtering ID to `contributeToHistogramOnEvent()` and links to the existing flexible filtering explainer.
    alexmturner authored Jul 23, 2024
    Configuration menu
    Copy the full SHA
    83b01c4 View commit details
    Browse the repository at this point in the history

Commits on Jul 24, 2024

  1. Configuration menu
    Copy the full SHA
    4417b49 View commit details
    Browse the repository at this point in the history

Commits on Jul 25, 2024

  1. Apply feedback

    Maks Orlovich committed Jul 25, 2024
    Configuration menu
    Copy the full SHA
    a2501fb View commit details
    Browse the repository at this point in the history
  2. Better wait.

    Maks Orlovich committed Jul 25, 2024
    Configuration menu
    Copy the full SHA
    c7d842f View commit details
    Browse the repository at this point in the history

Commits on Jul 28, 2024

  1. Configuration menu
    Copy the full SHA
    71ade67 View commit details
    Browse the repository at this point in the history

Commits on Jul 30, 2024

  1. Configuration menu
    Copy the full SHA
    fcc8c17 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    132f20d View commit details
    Browse the repository at this point in the history
  3. Update real time reporting explainer. (WICG#1226)

    * Update real time reporting explainer.
    
    * little cleanup
    
    * typo
    
    * small fixes.
    
    * Change decimal to hex in example.
    
    * Apply suggestions from code review
    
    Co-authored-by: Paul Jensen <[email protected]>
    
    * small cleanup
    
    * 1024 -> first platform bucket
    
    ---------
    
    Co-authored-by: Qingxin Wu <[email protected]>
    Co-authored-by: Paul Jensen <[email protected]>
    3 people authored Jul 30, 2024
    Configuration menu
    Copy the full SHA
    1cd0495 View commit details
    Browse the repository at this point in the history
  4. Be clear that reportResult()'s output needs to be json serializable (W…

    …ICG#1236)
    
    * reportResult()'s output needs to be json serializable
    
    * Update FLEDGE.md
    
    Co-authored-by: Paul Jensen <[email protected]>
    
    ---------
    
    Co-authored-by: Qingxin Wu <[email protected]>
    Co-authored-by: Paul Jensen <[email protected]>
    3 people authored Jul 30, 2024
    Configuration menu
    Copy the full SHA
    2a0590c View commit details
    Browse the repository at this point in the history

Commits on Jul 31, 2024

  1. [Spec] Real time reporting (WICG#1212)

    * real time reproting first try.
    
    * progress.
    
    * More progress
    
    * more progress
    
    * Almost done.
    
    * Finish
    
    * Add todo for rate limiting.
    
    * Address comments.
    
    * address comments.
    
    * small cleanups.
    
    * use () instead of <<>> for tuple
    
    * Set request's origin to frame origin.
    
    * fix rebase error
    
    ---------
    
    Co-authored-by: Qingxin Wu <[email protected]>
    qingxinwu and Qingxin Wu authored Jul 31, 2024
    Configuration menu
    Copy the full SHA
    b6be38d View commit details
    Browse the repository at this point in the history

Commits on Aug 6, 2024

  1. Add feature detection for real time reporting (WICG#1238)

    * Add feature detection for real time reporting
    
    Also added several I2S links which are available now.
    
    * add I2S link
    
    * address comment: remove extra space.
    qingxinwu authored Aug 6, 2024
    Configuration menu
    Copy the full SHA
    e159770 View commit details
    Browse the repository at this point in the history
  2. Add optional dataVersion field in the response schema and example. (W…

    …ICG#1241)
    
    * Add optional dataVersion field in the response schema and example.
    
    * Update FLEDGE_Key_Value_Server_API.md
    xtlsheep authored Aug 6, 2024
    Configuration menu
    Copy the full SHA
    c6ca9f8 View commit details
    Browse the repository at this point in the history
  3. Add updateIfOlderThanMs to the Key Value server API explainer (WICG#1235

    )
    
    * Add updateIfOlderThanMs to the Key Value server API explainer
    
    * Make curly brace consistent
    
    ---------
    
    Co-authored-by: Paul Jensen <[email protected]>
    lx3-g and JensenPaul authored Aug 6, 2024
    Configuration menu
    Copy the full SHA
    4a47c6b View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    a597e60 View commit details
    Browse the repository at this point in the history
  5. docs: remove version from ohttp media type (WICG#1243)

    * docs: remove version from ohttp media type
    
    * Update FLEDGE_Key_Value_Server_API.md
    
    Co-authored-by: Paul Jensen <[email protected]>
    
    * Update FLEDGE_Key_Value_Server_API.md
    
    * add missing new line
    
    ---------
    
    Co-authored-by: Paul Jensen <[email protected]>
    lx3-g and JensenPaul authored Aug 6, 2024
    Configuration menu
    Copy the full SHA
    44a00e4 View commit details
    Browse the repository at this point in the history

Commits on Aug 8, 2024

  1. Clarify when POST request is made (WICG#725)

    * Clarify when POST request is made
    
    Request for clarification disguised as a document update, want to make sure we're understanding the timing correctly.
    
    * Suggestion taken!
    thegreatfatzby authored Aug 8, 2024
    Configuration menu
    Copy the full SHA
    0cc7427 View commit details
    Browse the repository at this point in the history
  2. Add clarifying notes about reasons an IG might not be included for bi…

    …dding. (WICG#1044)
    
    * Add notes about reasons an IG might not be included for bidding.
    
    * Update FLEDGE.md
    
    ---------
    
    Co-authored-by: Paul Jensen <[email protected]>
    thegreatfatzby and JensenPaul authored Aug 8, 2024
    Configuration menu
    Copy the full SHA
    21abf2a View commit details
    Browse the repository at this point in the history
  3. [Spec] Add realTimeReporting in feature detection. (WICG#1245)

    Co-authored-by: Qingxin Wu <[email protected]>
    qingxinwu and Qingxin Wu authored Aug 8, 2024
    Configuration menu
    Copy the full SHA
    2845de2 View commit details
    Browse the repository at this point in the history
  4. Fix example in Fenced_Frames_Ads_Reporting.md (WICG#1231)

    explainer states that only 2 beacons are available but the example doesn't match
    sinnew authored Aug 8, 2024
    Configuration menu
    Copy the full SHA
    eae7160 View commit details
    Browse the repository at this point in the history
  5. Add reportResult in Multi Seller Case Clarity (WICG#965)

    * Add reportResult in Multi Seller Case Clarity
    
    From what I'm seeing in 9.5.11/19 [here](https://wicg.github.io/turtledove/#generate-and-score-bids), I believe this should be correct, and having this called out explicitly is worthwhile I'd say. @rdgordon-index seems to be seeing each reportResult triggered as well.
    
    * Adding in other relevant spots
    thegreatfatzby authored Aug 8, 2024
    Configuration menu
    Copy the full SHA
    94c7e50 View commit details
    Browse the repository at this point in the history

Commits on Aug 13, 2024

  1. Configuration menu
    Copy the full SHA
    1c6f58a View commit details
    Browse the repository at this point in the history
  2. Mention window.fence.getNestedConfigs() in explainer (WICG#1117)

    Update explainer's component ad documentation to mention how to get fenced frame configs via getNestedConfigs() when using fenced frames rather than iframes.  This isn't new information, it's just been missing from the explainer.
    
    Co-authored-by: Paul Jensen <[email protected]>
    MattMenke2 and JensenPaul authored Aug 13, 2024
    Configuration menu
    Copy the full SHA
    ea8e19f View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    83757e4 View commit details
    Browse the repository at this point in the history
  4. [Spec] Set correct initiator (origin) of requests. (WICG#1246)

    Co-authored-by: Dominic Farolino <[email protected]>
    qingxinwu and domfarolino authored Aug 13, 2024
    Configuration menu
    Copy the full SHA
    c0ac4a8 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    4c6ec74 View commit details
    Browse the repository at this point in the history
  6. Fix broken link to k-anonymity developer doc (WICG#1247)

    Fix broken link to k-anonymity developer doc and unify language around it.
    JensenPaul authored Aug 13, 2024
    Configuration menu
    Copy the full SHA
    f7fc5b6 View commit details
    Browse the repository at this point in the history
  7. Move lifetimeMs from GenerateBidInterestGroup to AuctionAdInterestGro…

    …up (WICG#843)
    
    Move lifetimeMs from GenerateBidInterestGroup to AuctionAdInterestGroup because of concerns about ambiguity and providing a high accuracy timer when executionMode allows multiple same-origin interest groups to share state.
    
    Note that lifetimeMs was never provided to generateBid() in Chrome, anyways, so no consumers should be broken by this change.
    
    Co-authored-by: Paul Jensen <[email protected]>
    MattMenke2 and JensenPaul authored Aug 13, 2024
    Configuration menu
    Copy the full SHA
    46d9eb5 View commit details
    Browse the repository at this point in the history

Commits on Aug 14, 2024

  1. Configuration menu
    Copy the full SHA
    1647301 View commit details
    Browse the repository at this point in the history

Commits on Aug 15, 2024

  1. Merge branch 'main' into fetcher-more-spec

    Maks Orlovich committed Aug 15, 2024
    Configuration menu
    Copy the full SHA
    4f72b3d View commit details
    Browse the repository at this point in the history
  2. Fix merge mistake

    Maks Orlovich committed Aug 15, 2024
    Configuration menu
    Copy the full SHA
    55dc68d View commit details
    Browse the repository at this point in the history

Commits on Aug 19, 2024

  1. [Spec] Add size API surface to joinAdInterestGroup (WICG#1210)

    * update idl
    
    * update idl
    
    * add interest group struct fields
    
    * use existing object
    
    * parse sizeGroup in AuctionAd
    
    * fix rebase
    
    * fix rebase
    
    * more fixes
    
    * parsing stub
    
    * update stub
    
    * add to interest group ad
    
    * add to interest group ad
    
    * fix compile
    
    * flesh out
    
    * convert ad size
    
    * fill out todos
    
    * add size group validity check
    
    * fix container size todo
    
    * fix refs
    
    * update find matching ad
    
    * Fix strings -> lists of strings
    
    * Add default null for size group
    
    Co-authored-by: qingxinwu <[email protected]>
    
    * Change 1. to *
    
    Co-authored-by: qingxinwu <[email protected]>
    
    * Change 1. to *
    
    Co-authored-by: qingxinwu <[email protected]>
    
    * Flatten 2 lines
    
    * Flatten 2 lines
    
    * USVString to DOMString
    
    * Change "throw type error" to "jump to abort step"
    
    * "groupName" -> "sizeGroupName"
    
    * Add estimated size
    
    * reference |size|
    
    * Fix formatting
    
    * Revert change
    
    * Unrevert change
    
    * Un-unrevert change
    
    * move note on DOMString vs USVString into spec
    
    * fix issue number
    
    Co-authored-by: qingxinwu <[email protected]>
    
    * chromium -> initial
    
    ---------
    
    Co-authored-by: Garrett Tanzer <[email protected]>
    Co-authored-by: qingxinwu <[email protected]>
    Co-authored-by: Paul Jensen <[email protected]>
    4 people authored Aug 19, 2024
    Configuration menu
    Copy the full SHA
    8721b57 View commit details
    Browse the repository at this point in the history

Commits on Aug 21, 2024

  1. Clarify trusted bidding signals request coalescing (WICG#727)

    * Update FLEDGE.md
    
    Looking for clarity disguised as commit, not clear if this is done automatically or if the IG owner needs to take some action (i.e. include interestGroupNames as a key in the trusted keys or some such.
    
    * add note on what Chrome does
    
    ---------
    
    Co-authored-by: Paul Jensen <[email protected]>
    thegreatfatzby and JensenPaul authored Aug 21, 2024
    Configuration menu
    Copy the full SHA
    86f10ca View commit details
    Browse the repository at this point in the history
  2. Add Some Clarification on Reporting IDs, Origin (WICG#837)

    * Add Some Clarification on Reporting IDs, Origin
    
    Wanted to add some clarity, which also will serve as a confirmation for a question we've had internally, on any limitations on buyer/seller reporting IDs. Added a few others in the neighborhood while at it.
    
    I do want to point out that the buyer/seller reporting IDs are listed in the full spec (https://wicg.github.io/turtledove/) as USVStrings for object declaration, but then DOMString when passed into reporting functions as browser signals. I do see other values go into browser signals as USVStrings, so it seems like either can go in...is that difference intentional?
    
    * Update FLEDGE.md
    
    Co-authored-by: Paul Jensen <[email protected]>
    
    ---------
    
    Co-authored-by: Paul Jensen <[email protected]>
    thegreatfatzby and JensenPaul authored Aug 21, 2024
    Configuration menu
    Copy the full SHA
    8e9812f View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    3c49e51 View commit details
    Browse the repository at this point in the history

Commits on Aug 22, 2024

  1. Add spec for Bidding and Auction Services API (WICG#1200)

    * Add spec for Bidding and Auction Services API
    
    * Fix typo
    
    * address comments
    
    * A few more fixes
    
    * Apply suggestions from code review
    
    Co-authored-by: qingxinwu <[email protected]>
    
    * Apply suggestions from code review
    
    Co-authored-by: qingxinwu <[email protected]>
    Co-authored-by: Paul Jensen <[email protected]>
    
    * Move decision logic parsing out of otherwise
    
    * Add explanation for null decision logic
    
    * Update spec.bs
    
    Co-authored-by: qingxinwu <[email protected]>
    
    ---------
    
    Co-authored-by: Paul Jensen <[email protected]>
    Co-authored-by: qingxinwu <[email protected]>
    3 people authored Aug 22, 2024
    Configuration menu
    Copy the full SHA
    4d02ec0 View commit details
    Browse the repository at this point in the history

Commits on Aug 23, 2024

  1. Add omit-user-bidding-signals enum for auctionServerRequestFlags in F…

    …LEDGE explainer (WICG#1255)
    
    Co-authored-by: Paul Jensen <[email protected]>
    brusshamilton and JensenPaul authored Aug 23, 2024
    Configuration menu
    Copy the full SHA
    eff30c1 View commit details
    Browse the repository at this point in the history
  2. Describe B&A payload size optimization options (WICG#1183)

    * Describe B&A payload size optimization options
    
    * Add Request Size and Configuration section
    
    * Address comments
    brusshamilton authored Aug 23, 2024
    Configuration menu
    Copy the full SHA
    e30fcac View commit details
    Browse the repository at this point in the history

Commits on Aug 25, 2024

  1. Configuration menu
    Copy the full SHA
    cee45e7 View commit details
    Browse the repository at this point in the history

Commits on Aug 27, 2024

  1. Apply feedback

    Maks Orlovich committed Aug 27, 2024
    Configuration menu
    Copy the full SHA
    e61116d View commit details
    Browse the repository at this point in the history
  2. Update to a renaming in fenced frame spec, to fix build. (WICG#1261)

    Co-authored-by: Maks Orlovich <[email protected]>
    morlovich and Maks Orlovich authored Aug 27, 2024
    Configuration menu
    Copy the full SHA
    7717cd1 View commit details
    Browse the repository at this point in the history
  3. Merge branch 'main' into fetcher-more-spec

    Maks Orlovich committed Aug 27, 2024
    Configuration menu
    Copy the full SHA
    b5fd043 View commit details
    Browse the repository at this point in the history
  4. Fix return capitalization, as per feedback

    Maks Orlovich committed Aug 27, 2024
    Configuration menu
    Copy the full SHA
    1c1f216 View commit details
    Browse the repository at this point in the history

Commits on Aug 29, 2024

  1. Configuration menu
    Copy the full SHA
    25066c6 View commit details
    Browse the repository at this point in the history
  2. Add k-anonymity cache (WICG#1005)

    * Add k-anonymity cache
    
    * Fix missing /div
    
    * Fix some other issues
    
    * add missing /
    
    * fix var names
    
    * fix var names again
    
    * Address comments
    
    * Add ,
    
    * Address comments
    
    * fix build
    
    * Address comments
    
    * Fix merge issues
    
    * Update spec.bs
    
    Co-authored-by: Dominic Farolino <[email protected]>
    
    * Remove extra assertions about [=in parallel=]
    
    ---------
    
    Co-authored-by: Dominic Farolino <[email protected]>
    brusshamilton and domfarolino authored Aug 29, 2024
    Configuration menu
    Copy the full SHA
    bf20967 View commit details
    Browse the repository at this point in the history
  3. Apply feedback

    Maks Orlovich committed Aug 29, 2024
    Configuration menu
    Copy the full SHA
    3e06bf5 View commit details
    Browse the repository at this point in the history
  4. [Spec] Add policy container field to requests. (WICG#1253)

    * Add policy container field to requests.
    
    * finish
    
    * address comments.
    
    * Add policy container to trusted signals fetch
    
    * unset embedder policy, but set ip address space
    
    * Fix permissions check request
    
    ---------
    
    Co-authored-by: Qingxin Wu <[email protected]>
    qingxinwu and Qingxin Wu authored Aug 29, 2024
    Configuration menu
    Copy the full SHA
    815f0f1 View commit details
    Browse the repository at this point in the history

Commits on Sep 3, 2024

  1. Merge branch 'main' into fetcher-more-spec, and pass policyContainer

    to trusted seller signals fetches.
    Maks Orlovich committed Sep 3, 2024
    Configuration menu
    Copy the full SHA
    77f52e0 View commit details
    Browse the repository at this point in the history

Commits on Sep 4, 2024

  1. Deals explainer (WICG#1237)

    * Deals explainer
    
    * Pluralize selectableBuyerAndSellerReportingIds
    
    * beginnings of a table
    
    * fill in table and use abreviations
    
    * add line breaks
    
    * improve language and text
    
    * fixed problems
    
    * fix typos
    
    * add note about buyerReportingId in reportWin()'s browserSignals
    
    * add more links to more details
    
    * fix typos
    
    * add note about matching list in IG
    
    * add text about generateBid and scoreAd and examples
    
    * update wording on k-anon rebidding
    
    * fix typos and add another example
    
    * A little clarification
    
    * Resolve some of Orr's comments
    
    * Merge in the last of Orr's edits
    
    * Update FLEDGE.md
    
    * remove old words about size
    
    * clarify wording
    
    * Address Orr's last comments
    JensenPaul authored Sep 4, 2024
    Configuration menu
    Copy the full SHA
    e409744 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    56fef80 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    f2f8805 View commit details
    Browse the repository at this point in the history
  4. Fix previous wins and ad render ID (WICG#1258)

    * Fix previous wins and ad render ID
    
    * Apply suggestions from code review
    
    Co-authored-by: qingxinwu <[email protected]>
    
    * Address comments
    
    * fix references
    
    * address comments
    
    * Update spec.bs
    
    Co-authored-by: qingxinwu <[email protected]>
    
    ---------
    
    Co-authored-by: qingxinwu <[email protected]>
    Co-authored-by: Paul Jensen <[email protected]>
    3 people authored Sep 4, 2024
    Configuration menu
    Copy the full SHA
    d9ad4d1 View commit details
    Browse the repository at this point in the history

Commits on Sep 5, 2024

  1. Notes changes

    Maks Orlovich committed Sep 5, 2024
    Configuration menu
    Copy the full SHA
    ceee609 View commit details
    Browse the repository at this point in the history

Commits on Sep 6, 2024

  1. Configuration menu
    Copy the full SHA
    f484b9b View commit details
    Browse the repository at this point in the history