More clearly define how seller trusted signals fetching works #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
morlovich
changed the title
morlovich
changed the title
morlovich
commented
Jul 11, 2024
spec.bs
Outdated
| To <dfn>batch and fetch trusted scoring signals</dfn> given a [=trusted scoring signals batcher=] | ||
| |batcher|: | ||
|
|
||
| 1. Until this object is no longer needed: |
There was a problem hiding this comment.
So this function has basically all the weird things, so it may be helpful if you could eyeball it...
* [Spec] Fix spacing * Update spec.bs Co-authored-by: qingxinwu <[email protected]> --------- Co-authored-by: qingxinwu <[email protected]>
* Specify support for cross-origin trusted signals,
and the bundled queryFeatureSupport('*'). This also includes
fixes to some bugs in parsing of these URLs (some of the
checks were missing).
* Simpler part of feedback
* Refactor trustedBiddingSignalsURL config.
* Update scoring, also remove some diff noise.
* Split function.
* Apply feedback
* Apply feedback.
* Apply suggestions I didn't need to ask follow ups on
* Apply a typo fix Qingxin pointed out which I missed because
there was another comment about the same line.
* Fix same origin checks
* varify ignored placeholders
* Rework the merging language.
* Some first steps towards expression some fetch parallelism.
* Improve some phrasing as suggested
* Fix wrong indentation level, now I can see in a preview diff.
* Fix missing comma.
---------
Co-authored-by: Maks Orlovich <[email protected]>
|
Superseded by WICG#1230 |
…ICG#1129) Adds a filtering ID to `contributeToHistogramOnEvent()` and links to the existing flexible filtering explainer.
* Update real time reporting explainer. * little cleanup * typo * small fixes. * Change decimal to hex in example. * Apply suggestions from code review Co-authored-by: Paul Jensen <[email protected]> * small cleanup * 1024 -> first platform bucket --------- Co-authored-by: Qingxin Wu <[email protected]> Co-authored-by: Paul Jensen <[email protected]>
…ICG#1236) * reportResult()'s output needs to be json serializable * Update FLEDGE.md Co-authored-by: Paul Jensen <[email protected]> --------- Co-authored-by: Qingxin Wu <[email protected]> Co-authored-by: Paul Jensen <[email protected]>
* real time reproting first try. * progress. * More progress * more progress * Almost done. * Finish * Add todo for rate limiting. * Address comments. * address comments. * small cleanups. * use () instead of <<>> for tuple * Set request's origin to frame origin. * fix rebase error --------- Co-authored-by: Qingxin Wu <[email protected]>
* Add feature detection for real time reporting Also added several I2S links which are available now. * add I2S link * address comment: remove extra space.
…ICG#1241) * Add optional dataVersion field in the response schema and example. * Update FLEDGE_Key_Value_Server_API.md
) * Add updateIfOlderThanMs to the Key Value server API explainer * Make curly brace consistent --------- Co-authored-by: Paul Jensen <[email protected]>
Co-authored-by: Dominic Farolino <[email protected]>
Fix broken link to k-anonymity developer doc and unify language around it.
…up (WICG#843) Move lifetimeMs from GenerateBidInterestGroup to AuctionAdInterestGroup because of concerns about ambiguity and providing a high accuracy timer when executionMode allows multiple same-origin interest groups to share state. Note that lifetimeMs was never provided to generateBid() in Chrome, anyways, so no consumers should be broken by this change. Co-authored-by: Paul Jensen <[email protected]>
* update idl * update idl * add interest group struct fields * use existing object * parse sizeGroup in AuctionAd * fix rebase * fix rebase * more fixes * parsing stub * update stub * add to interest group ad * add to interest group ad * fix compile * flesh out * convert ad size * fill out todos * add size group validity check * fix container size todo * fix refs * update find matching ad * Fix strings -> lists of strings * Add default null for size group Co-authored-by: qingxinwu <[email protected]> * Change 1. to * Co-authored-by: qingxinwu <[email protected]> * Change 1. to * Co-authored-by: qingxinwu <[email protected]> * Flatten 2 lines * Flatten 2 lines * USVString to DOMString * Change "throw type error" to "jump to abort step" * "groupName" -> "sizeGroupName" * Add estimated size * reference |size| * Fix formatting * Revert change * Unrevert change * Un-unrevert change * move note on DOMString vs USVString into spec * fix issue number Co-authored-by: qingxinwu <[email protected]> * chromium -> initial --------- Co-authored-by: Garrett Tanzer <[email protected]> Co-authored-by: qingxinwu <[email protected]> Co-authored-by: Paul Jensen <[email protected]>
* Update FLEDGE.md Looking for clarity disguised as commit, not clear if this is done automatically or if the IG owner needs to take some action (i.e. include interestGroupNames as a key in the trusted keys or some such. * add note on what Chrome does --------- Co-authored-by: Paul Jensen <[email protected]>
* Add Some Clarification on Reporting IDs, Origin Wanted to add some clarity, which also will serve as a confirmation for a question we've had internally, on any limitations on buyer/seller reporting IDs. Added a few others in the neighborhood while at it. I do want to point out that the buyer/seller reporting IDs are listed in the full spec (https://wicg.github.io/turtledove/) as USVStrings for object declaration, but then DOMString when passed into reporting functions as browser signals. I do see other values go into browser signals as USVStrings, so it seems like either can go in...is that difference intentional? * Update FLEDGE.md Co-authored-by: Paul Jensen <[email protected]> --------- Co-authored-by: Paul Jensen <[email protected]>
* Add spec for Bidding and Auction Services API * Fix typo * address comments * A few more fixes * Apply suggestions from code review Co-authored-by: qingxinwu <[email protected]> * Apply suggestions from code review Co-authored-by: qingxinwu <[email protected]> Co-authored-by: Paul Jensen <[email protected]> * Move decision logic parsing out of otherwise * Add explanation for null decision logic * Update spec.bs Co-authored-by: qingxinwu <[email protected]> --------- Co-authored-by: Paul Jensen <[email protected]> Co-authored-by: qingxinwu <[email protected]>
…LEDGE explainer (WICG#1255) Co-authored-by: Paul Jensen <[email protected]>
* Describe B&A payload size optimization options * Add Request Size and Configuration section * Address comments
Co-authored-by: Maks Orlovich <[email protected]>
* Add k-anonymity cache * Fix missing /div * Fix some other issues * add missing / * fix var names * fix var names again * Address comments * Add , * Address comments * fix build * Address comments * Fix merge issues * Update spec.bs Co-authored-by: Dominic Farolino <[email protected]> * Remove extra assertions about [=in parallel=] --------- Co-authored-by: Dominic Farolino <[email protected]>
* Add policy container field to requests. * finish * address comments. * Add policy container to trusted signals fetch * unset embedder policy, but set ip address space * Fix permissions check request --------- Co-authored-by: Qingxin Wu <[email protected]>
to trusted seller signals fetches.
* Deals explainer * Pluralize selectableBuyerAndSellerReportingIds * beginnings of a table * fill in table and use abreviations * add line breaks * improve language and text * fixed problems * fix typos * add note about buyerReportingId in reportWin()'s browserSignals * add more links to more details * fix typos * add note about matching list in IG * add text about generateBid and scoreAd and examples * update wording on k-anon rebidding * fix typos and add another example * A little clarification * Resolve some of Orr's comments * Merge in the last of Orr's edits * Update FLEDGE.md * remove old words about size * clarify wording * Address Orr's last comments
* Fix previous wins and ad render ID * Apply suggestions from code review Co-authored-by: qingxinwu <[email protected]> * Address comments * fix references * address comments * Update spec.bs Co-authored-by: qingxinwu <[email protected]> --------- Co-authored-by: qingxinwu <[email protected]> Co-authored-by: Paul Jensen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.