Catch regex config errors in AWS proxy; fix logic for proxying S3 requests with host-based addressing #80
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adjust regex logic to catch config errors in AWS proxy.
Addresses an issue where we've recently seen errors like this:
We are not changing the logic per se in here, but at least make the error message more human-readable.
The PR also enhances the logic for proxying S3 requests with host-based addressing. This is required for AWS SDK S3 clients that are using host-based bucket addressing (e.g., AWS JavaScript SDK v2/v3 by default). We are now passing a
x-ls-host-original
from the original request handler to the proxy handler, and then extract the bucket name from that header value, to form the final request path (/<bucket>/<path>
).The tests have been extended with additional parametrization to cover this case (host-based as well as path-based bucket addressing) as well.