Fix logic to proxy S3 requests against *amazonaws.com #83
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix logic to proxy S3 requests against
*.s3.amazonaws.comrequests.Follow up for recent PR #80 , which introduced extraction of bucket names from hostnames in proxied requests. The previous PR only extracted the bucket from
<bucket>.s3.localhost.localstack.cloudhosts, and with this PR we are now also supporting<bucket>.s3.amazonaws.comhosts. This can be required if, e.g., a request is being made from a Lambda using transparent endpoint injection.A simple test has been added to cover the functionality - using a modified boto3 client that mimicks a local request using transparent endpoint injection, targeting the real AWS hostname locally.